[FFmpeg-devel] [PATCH v2] avformat/dump: Print all possible Stereo3D info

[FFmpeg-devel] [PATCH v2] avformat/dump: Print all possible Stereo3D info

[Derek Buitenhuis]

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 libavformat/dump.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/libavformat/dump.c b/libavformat/dump.c
index 059fb84522..61a2c6a29f 100644
--- a/libavformat/dump.c
+++ b/libavformat/dump.c
@@ -259,7 +259,16 @@ static void dump_stereo3d(void *ctx, const AVPacketSideData *sd, int log_level)
 
     stereo = (const AVStereo3D *)sd->data;
 
-    av_log(ctx, log_level, "%s", av_stereo3d_type_name(stereo->type));
+    av_log(ctx, log_level, "%s, view: %s, primary eye: %s",
+           av_stereo3d_type_name(stereo->type), av_stereo3d_view_name(stereo->view),
+           av_stereo3d_primary_eye_name(stereo->primary_eye));
+    if (stereo->baseline)
+        av_log(ctx, log_level, ", baseline: %"PRIu32"", stereo->baseline);
+    if (stereo->horizontal_disparity_adjustment.num && stereo->horizontal_disparity_adjustment.den)
+        av_log(ctx, log_level, ", horizontal_disparity_adjustment: %d/%d",
+               stereo->horizontal_disparity_adjustment.num, stereo->horizontal_disparity_adjustment.den);
+    if (stereo->horizontal_field_of_view)
+        av_log(ctx, log_level, ", horizontal_field_of_view: %"PRIu32"", stereo->horizontal_field_of_view);
 
     if (stereo->flags & AV_STEREO3D_FLAG_INVERT)
         av_log(ctx, log_level, " (inverted)");
-- 
2.43.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avformat/dump: Print all possible Stereo3D info

[James Almer]

On 6/18/2024 3:55 PM, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
>   libavformat/dump.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/dump.c b/libavformat/dump.c
> index 059fb84522..61a2c6a29f 100644
> --- a/libavformat/dump.c
> +++ b/libavformat/dump.c
> @@ -259,7 +259,16 @@ static void dump_stereo3d(void *ctx, const AVPacketSideData *sd, int log_level)
>   
>       stereo = (const AVStereo3D *)sd->data;
>   
> -    av_log(ctx, log_level, "%s", av_stereo3d_type_name(stereo->type));
> +    av_log(ctx, log_level, "%s, view: %s, primary eye: %s",
> +           av_stereo3d_type_name(stereo->type), av_stereo3d_view_name(stereo->view),
> +           av_stereo3d_primary_eye_name(stereo->primary_eye));
> +    if (stereo->baseline)
> +        av_log(ctx, log_level, ", baseline: %"PRIu32"", stereo->baseline);
> +    if (stereo->horizontal_disparity_adjustment.num && stereo->horizontal_disparity_adjustment.den)
> +        av_log(ctx, log_level, ", horizontal_disparity_adjustment: %d/%d",
> +               stereo->horizontal_disparity_adjustment.num, stereo->horizontal_disparity_adjustment.den);
> +    if (stereo->horizontal_field_of_view)
> +        av_log(ctx, log_level, ", horizontal_field_of_view: %"PRIu32"", stereo->horizontal_field_of_view);
>   
>       if (stereo->flags & AV_STEREO3D_FLAG_INVERT)
>           av_log(ctx, log_level, " (inverted)");

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".