From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/dump: Print all possible Stereo3D info
Date: Tue, 18 Jun 2024 15:56:25 -0300
Message-ID: <246e98b6-018e-40a3-ad64-cde64dd13732@gmail.com> (raw)
In-Reply-To: <20240618185502.680197-1-derek.buitenhuis@gmail.com>
On 6/18/2024 3:55 PM, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
> libavformat/dump.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/dump.c b/libavformat/dump.c
> index 059fb84522..61a2c6a29f 100644
> --- a/libavformat/dump.c
> +++ b/libavformat/dump.c
> @@ -259,7 +259,16 @@ static void dump_stereo3d(void *ctx, const AVPacketSideData *sd, int log_level)
>
> stereo = (const AVStereo3D *)sd->data;
>
> - av_log(ctx, log_level, "%s", av_stereo3d_type_name(stereo->type));
> + av_log(ctx, log_level, "%s, view: %s, primary eye: %s",
> + av_stereo3d_type_name(stereo->type), av_stereo3d_view_name(stereo->view),
> + av_stereo3d_primary_eye_name(stereo->primary_eye));
> + if (stereo->baseline)
> + av_log(ctx, log_level, ", baseline: %"PRIu32"", stereo->baseline);
> + if (stereo->horizontal_disparity_adjustment.num && stereo->horizontal_disparity_adjustment.den)
> + av_log(ctx, log_level, ", horizontal_disparity_adjustment: %d/%d",
> + stereo->horizontal_disparity_adjustment.num, stereo->horizontal_disparity_adjustment.den);
> + if (stereo->horizontal_field_of_view)
> + av_log(ctx, log_level, ", horizontal_field_of_view: %"PRIu32"", stereo->horizontal_field_of_view);
>
> if (stereo->flags & AV_STEREO3D_FLAG_INVERT)
> av_log(ctx, log_level, " (inverted)");
LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-18 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 18:55 Derek Buitenhuis
2024-06-18 18:56 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=246e98b6-018e-40a3-ad64-cde64dd13732@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git