From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7B653475F2 for ; Thu, 14 Sep 2023 19:10:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4CA4468C78A; Thu, 14 Sep 2023 22:10:28 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2011468C709 for ; Thu, 14 Sep 2023 22:10:22 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 64E82403BC2 for ; Thu, 14 Sep 2023 21:10:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1694718620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7qHiXxFpnn3eIGfwRqVJ2O5YIq6jlWESSx3BbW/+2PQ=; b=cVKL334n+x5cTxU5Ktw1twj2CT4EQliRMXtuEfgzF3yb6Irhj174CTGdnJEZfIkPJ7Wx42 ZuzcP8S/w7T8UOGWjHImzgrvuEpNpmxvHtxwOJeJCWDfdRVsXbOhtUKkE+A2MAhHC5SjGn Bzc+q/pL8K48Xsz0wT4Zxi9FO7PF9Alr/CGcjLjcF67+ZodzIVqRQOiEy/e+pelxuJjZTh k/0IFjXn2ESee1yDfGiWwKWTV0WiK34AdYS6LtsywXRevZkLvhKdrdwxJJgrPbYMtKOgGc KZ05bXmIEM4nQDpn2hA0Q+1MES16OG3XKuV1yjRdlMnn9Odhu8iIgdw7ADNUyw== Message-ID: <2433f96f-f2c4-457a-924b-db2bbf096452@rothenpieler.org> Date: Thu, 14 Sep 2023 21:10:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <97c138ad-457f-d098-e145-983bdd3e7f69@rothenpieler.org> <74ca77b7-5b84-9d4d-2baa-0223418fd9d6@rothenpieler.org> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 14.09.2023 20:59, Kyle Swanson wrote: > Problem was slightly different, there is no `libvmaf_cuda`, just > `libvmaf` built with the cuda apis optionally enabled. `./configure` > is fixed now and I've tested all the possible combinations, updated > patch attached. This looks more complicated than necessary to me. My idea would have been to change, in the previous original patch, > libvmaf_cuda_filter_deps="libvmaf ffnvcodec" to > libvmaf_cuda_filter_deps="libvmaf libvmaf_cuda ffnvcodec" And the pkg_config check would then enable/disable libvmaf_cuda: > enabled libvmaf_cuda && require_pkg_config libvmaf_cuda "libvmaf >= 2.0.0" libvmaf_cuda.h vmaf_cuda_state_init One unrelated thing I just thought of: The macro you'll want to check in the filter itself isn't CONFIG_LIBVMAF_CUDA, but CONFIG_LIBVMAF_CUDA_FILTER. Since it's in theory possible for someone to do the slightly silly thing of doing --enable-vmaf-cuda but then manually disabling the filter. Likewise it's possible for someone to ONLY build the libvmaf_cuda filter, and disable the non-cuda variant. So its "const AVFilter ..." part, and everything only used by it, should be wrapped in #if CONFIG_LIBVMAF_FILTER _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".