From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 505F04003F
for <ffmpegdev@gitmailbox.com>; Tue, 18 Mar 2025 18:28:52 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D2579687A90;
Tue, 18 Mar 2025 20:28:48 +0200 (EET)
Received: from btbn.de (btbn.de [144.76.60.213])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F5E2687A29
for <ffmpeg-devel@ffmpeg.org>; Tue, 18 Mar 2025 20:28:42 +0200 (EET)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id
E0DD62819FCD7
for <ffmpeg-devel@ffmpeg.org>; Tue, 18 Mar 2025 19:28:41 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
s=mail; t=1742322521;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=4TtQncQBrk5ubkhE6zmQNvL3YZ0Fnfy1ygcJbDadg60=;
b=THSd3d0caGkLcpeENRIe58oeMMEWt1cq/JiwG6tX1Q4glrRDheTVYRFQtDlKJ08ky9VBot
PXQ1vz4UQloDOzFmQjOlYQ1rKtlSSP6xrpGZwacjDx0WWZiUhfFM1cTHcPFs5Y+dIdm+Ep
9tqzNIyaPgjvW3gCyK19xaYmFw4hYdHzV8vjavqXUs2N5uiOp/yP2M1Jz+TXFOdmmI/xhn
2SicU1JuG/PGZ4XTuA2MeWqZosMigPg3/s8+QY9Knw8UMlkpsNrJTTnLXHj9Au1ak7/zlS
lSovoAlP9+0SIl8sxBkUXnVF6KGgE8GYR9BEIuZ17febyUPWBjsBD2mhKGM+fA==
Message-ID: <24329a79-dd95-418a-a0af-b949f86a21af@rothenpieler.org>
Date: Tue, 18 Mar 2025 19:28:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20250318154924.356-1-ffmpeg@gyani.pro>
<DAA17F01-E0A9-4EC2-9A69-4769A7BBF3E9@gmail.com>
Content-Language: en-US
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <DAA17F01-E0A9-4EC2-9A69-4769A7BBF3E9@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for
response files
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/24329a79-dd95-418a-a0af-b949f86a21af@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On 18.03.2025 19:11, Marvin Scholz wrote:
>
>
> On 18 Mar 2025, at 16:49, Gyan Doshi wrote:
>
>> ---
>> configure | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure b/configure
>> index d84e32196d..14f7bcde0e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5230,12 +5230,6 @@ else
>> ar_o='$@'
>> fi
>>
>> -if $ar 2>&1 | grep -qi "@.*file"; then
>> - ar_objs="true"
>> -else
>> - ar_objs=""
>> -fi
>> -
>> add_cflags $extra_cflags
>> add_cxxflags $extra_cxxflags
>> add_objcflags $extra_objcflags
>> @@ -7759,6 +7753,13 @@ case $ld_type in
>> ;;
>> esac
>>
>> +{
>> +ar_out=${FFTMPDIR}/test$LIBSUF
>> +respfile="@/dev/null"
>> +out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")"
>> +test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" || ar_objs=""
>> +}
>
> Wouldn't that break on Windows where you don't have /dev/null?
Every single bash/sh environment for Windows provides the standard dev
nodes.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".