Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files

[Timo Rothenpieler <timo@rothenpieler.org>]

On 18.03.2025 19:11, Marvin Scholz wrote:
> 
> 
> On 18 Mar 2025, at 16:49, Gyan Doshi wrote:
> 
>> ---
>>   configure | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure b/configure
>> index d84e32196d..14f7bcde0e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5230,12 +5230,6 @@ else
>>       ar_o='$@'
>>   fi
>>
>> -if $ar 2>&1 | grep -qi  "@.*file"; then
>> -    ar_objs="true"
>> -else
>> -    ar_objs=""
>> -fi
>> -
>>   add_cflags $extra_cflags
>>   add_cxxflags $extra_cxxflags
>>   add_objcflags $extra_objcflags
>> @@ -7759,6 +7753,13 @@ case $ld_type in
>>       ;;
>>   esac
>>
>> +{
>> +ar_out=${FFTMPDIR}/test$LIBSUF
>> +respfile="@/dev/null"
>> +out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")"
>> +test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" || ar_objs=""
>> +}
> 
> Wouldn't that break on Windows where you don't have /dev/null?

Every single bash/sh environment for Windows provides the standard dev 
nodes.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".