From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CDD3F434D2 for ; Sat, 13 Aug 2022 20:56:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BB6E868B7FA; Sat, 13 Aug 2022 23:55:57 +0300 (EEST) Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8822D68B71B for ; Sat, 13 Aug 2022 23:55:50 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1660424156; x=1691960156; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=DDiauKB0by5MpJ/XT0ZNL6XouT7FIFJXXgJTlnPqijc=; b=nbWz9270gYi4n/dg5wD+Qa1VOW+Nbz+x5ugjMYUvP+BTLonLvg4VFD+S A/Iuc56iLkYrf6wxdGKYoKQphXFQ+zQu+695qjI5syVkgPU3r40YP69JE F5y8pCotyq7+tUNtZOqAZUzDtxbsRNtR0fdCVkunMNOuhzlUQKImP/nNL c=; X-IronPort-AV: E=Sophos;i="5.93,236,1654560000"; d="scan'208";a="229333548" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1e-7dac3c4d.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2022 20:55:49 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-7dac3c4d.us-east-1.amazon.com (Postfix) with ESMTPS id 181BE100069; Sat, 13 Aug 2022 20:55:49 +0000 (UTC) Received: from EX19D007UWB004.ant.amazon.com (10.13.138.60) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Sat, 13 Aug 2022 20:55:48 +0000 Received: from EX19D007UWB001.ant.amazon.com (10.13.138.75) by EX19D007UWB004.ant.amazon.com (10.13.138.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Sat, 13 Aug 2022 20:55:48 +0000 Received: from EX19D007UWB001.ant.amazon.com ([fe80::bcaa:e18f:a569:3851]) by EX19D007UWB001.ant.amazon.com ([fe80::bcaa:e18f:a569:3851%6]) with mapi id 15.02.1118.012; Sat, 13 Aug 2022 20:55:48 +0000 From: "Swinney, Jonathan" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH v3 0/3] checkasm: updated tests for sw_scale Thread-Index: AdivVmNDXnpXI9vlTJiw4QwcOY5XWw== Date: Sat, 13 Aug 2022 20:55:48 +0000 Message-ID: <241b0204d8e34436b8fc785654ce48c8@amazon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.43.162.134] MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 0/3] checkasm: updated tests for sw_scale X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-1?Q?Martin_Storsj=F6?= , Hubert Mazur Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > We don't generally use stdbool in ffmpeg, even if it's C99 - just use a > plain int and 0/1. Updated this. > Other than that, the checkasm changes look fine (I coauthored part of > them - and your cleanup of my WIP patch looks good!). Yes, thank you for the help on that! > Hmm, can you elaborate on this bit? With only the first patch applied, the > checkasm test still succeeds. That was leftover from when my test was broken. Is that that with the fixed test, it works fine. > Could we split this improvement for the existing codepath into a separate > preceding patch, to keep things a bit clearer? I split it out. Let me know if I didn't split like you intended. Thanks again for your review! Jonathan Swinney _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".