From: "Swinney, Jonathan" <jswinney@amazon.com>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: "Martin Storsjö" <martin@martin.st>, "Hubert Mazur" <hum@semihalf.com>
Subject: [FFmpeg-devel] [PATCH v3 0/3] checkasm: updated tests for sw_scale
Date: Sat, 13 Aug 2022 20:55:48 +0000
Message-ID: <241b0204d8e34436b8fc785654ce48c8@amazon.com> (raw)
> We don't generally use stdbool in ffmpeg, even if it's C99 - just use a
> plain int and 0/1.
Updated this.
> Other than that, the checkasm changes look fine (I coauthored part of
> them - and your cleanup of my WIP patch looks good!).
Yes, thank you for the help on that!
> Hmm, can you elaborate on this bit? With only the first patch applied, the
> checkasm test still succeeds.
That was leftover from when my test was broken. Is that that with the fixed
test, it works fine.
> Could we split this improvement for the existing codepath into a separate
> preceding patch, to keep things a bit clearer?
I split it out. Let me know if I didn't split like you intended.
Thanks again for your review!
Jonathan Swinney
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-08-13 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 20:55 Swinney, Jonathan [this message]
2022-08-16 10:41 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=241b0204d8e34436b8fc785654ce48c8@amazon.com \
--to=jswinney@amazon.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=hum@semihalf.com \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git