* [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
@ 2024-02-23 14:45 flow gg
2024-02-23 17:17 ` Rémi Denis-Courmont
2024-03-03 14:39 ` Rémi Denis-Courmont
0 siblings, 2 replies; 9+ messages in thread
From: flow gg @ 2024-02-23 14:45 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: 0001-lavc-vp8dsp-R-V-V-put_bilin_h.patch --]
[-- Type: text/x-patch, Size: 3339 bytes --]
From b773a2b640ba38a106539da7f3414d6892364c4f Mon Sep 17 00:00:00 2001
From: sunyuechi <sunyuechi@iscas.ac.cn>
Date: Fri, 23 Feb 2024 13:27:42 +0800
Subject: [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
C908:
vp8_put_bilin4_h_c: 373.5
vp8_put_bilin4_h_rvv_i32: 158.7
vp8_put_bilin8_h_c: 1437.7
vp8_put_bilin8_h_rvv_i32: 318.7
vp8_put_bilin16_h_c: 2845.7
vp8_put_bilin16_h_rvv_i32: 374.7
---
libavcodec/riscv/vp8dsp_init.c | 11 +++++++
libavcodec/riscv/vp8dsp_rvv.S | 54 ++++++++++++++++++++++++++++++++++
2 files changed, 65 insertions(+)
diff --git a/libavcodec/riscv/vp8dsp_init.c b/libavcodec/riscv/vp8dsp_init.c
index c364de3dc9..32cb4893a4 100644
--- a/libavcodec/riscv/vp8dsp_init.c
+++ b/libavcodec/riscv/vp8dsp_init.c
@@ -34,6 +34,10 @@ VP8_EPEL(16, rvv);
VP8_EPEL(8, rvv);
VP8_EPEL(4, rvv);
+VP8_BILIN(16, rvv);
+VP8_BILIN(8, rvv);
+VP8_BILIN(4, rvv);
+
av_cold void ff_vp78dsp_init_riscv(VP8DSPContext *c)
{
#if HAVE_RVV
@@ -47,6 +51,13 @@ av_cold void ff_vp78dsp_init_riscv(VP8DSPContext *c)
c->put_vp8_bilinear_pixels_tab[0][0][0] = ff_put_vp8_pixels16_rvv;
c->put_vp8_bilinear_pixels_tab[1][0][0] = ff_put_vp8_pixels8_rvv;
c->put_vp8_bilinear_pixels_tab[2][0][0] = ff_put_vp8_pixels4_rvv;
+
+ c->put_vp8_bilinear_pixels_tab[0][0][1] = ff_put_vp8_bilin16_h_rvv;
+ c->put_vp8_bilinear_pixels_tab[0][0][2] = ff_put_vp8_bilin16_h_rvv;
+ c->put_vp8_bilinear_pixels_tab[1][0][1] = ff_put_vp8_bilin8_h_rvv;
+ c->put_vp8_bilinear_pixels_tab[1][0][2] = ff_put_vp8_bilin8_h_rvv;
+ c->put_vp8_bilinear_pixels_tab[2][0][1] = ff_put_vp8_bilin4_h_rvv;
+ c->put_vp8_bilinear_pixels_tab[2][0][2] = ff_put_vp8_bilin4_h_rvv;
}
#endif
}
diff --git a/libavcodec/riscv/vp8dsp_rvv.S b/libavcodec/riscv/vp8dsp_rvv.S
index 063ab7110c..c8d265e516 100644
--- a/libavcodec/riscv/vp8dsp_rvv.S
+++ b/libavcodec/riscv/vp8dsp_rvv.S
@@ -98,3 +98,57 @@ func ff_put_vp8_pixels4_rvv, zve32x
vsetivli zero, 4, e8, mf4, ta, ma
put_vp8_pixels
endfunc
+
+.macro bilin_h_load dst len
+.ifc \len,4
+ vsetivli zero, 5, e8, mf2, ta, ma
+.elseif \len == 8
+ vsetivli zero, 9, e8, m1, ta, ma
+.else
+ vsetivli zero, 17, e8, m2, ta, ma
+.endif
+
+ vle8.v \dst, (a2)
+ vslide1down.vx v2, \dst, t5
+
+.ifc \len,4
+ vsetivli zero, 4, e8, mf4, ta, ma
+.elseif \len == 8
+ vsetivli zero, 8, e8, mf2, ta, ma
+.else
+ vsetivli zero, 16, e8, m1, ta, ma
+.endif
+
+ vwmulu.vx v28, \dst, t1
+ vwmaccu.vx v28, a5, v2
+ vwaddu.wx v24, v28, t4
+ vnsra.wi \dst, v24, 3
+.endm
+
+.macro put_vp8_bilin_h len
+ li t1, 8
+ li t4, 4
+ li t5, 1
+ sub t1, t1, a5
+1:
+ addi a4, a4, -1
+ bilin_h_load v0, \len
+ vse8.v v0, (a0)
+ add a2, a2, a3
+ add a0, a0, a1
+ bnez a4, 1b
+
+ ret
+.endm
+
+func ff_put_vp8_bilin16_h_rvv, zve32x
+ put_vp8_bilin_h 16
+endfunc
+
+func ff_put_vp8_bilin8_h_rvv, zve32x
+ put_vp8_bilin_h 8
+endfunc
+
+func ff_put_vp8_bilin4_h_rvv, zve32x
+ put_vp8_bilin_h 4
+endfunc
--
2.43.2
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
2024-02-23 14:45 [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h flow gg
@ 2024-02-23 17:17 ` Rémi Denis-Courmont
2024-02-24 1:07 ` flow gg
2024-03-03 14:39 ` Rémi Denis-Courmont
1 sibling, 1 reply; 9+ messages in thread
From: Rémi Denis-Courmont @ 2024-02-23 17:17 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Hi,
+
+.macro bilin_h_load dst len
+.ifc \len,4
+ vsetivli zero, 5, e8, mf2, ta, ma
Don't use fractional multipliers if you don't mix element widths.
+.elseif \len == 8
+ vsetivli zero, 9, e8, m1, ta, ma
+.else
+ vsetivli zero, 17, e8, m2, ta, ma
+.endif
+
+ vle8.v \dst, (a2)
+ vslide1down.vx v2, \dst, t5
+
+.ifc \len,4
+ vsetivli zero, 4, e8, mf4, ta, ma
Same as above.
+.elseif \len == 8
+ vsetivli zero, 8, e8, mf2, ta, ma
Also.
+.else
+ vsetivli zero, 16, e8, m1, ta, ma
+.endif
+ vwmulu.vx v28, \dst, t1
+ vwmaccu.vx v28, a5, v2
+ vwaddu.wx v24, v28, t4
+ vnsra.wi \dst, v24, 3
+.endm
+
+.macro put_vp8_bilin_h len
+ li t1, 8
+ li t4, 4
+ li t5, 1
+ sub t1, t1, a5
+1:
+ addi a4, a4, -1
+ bilin_h_load v0, \len
+ vse8.v v0, (a0)
+ add a2, a2, a3
+ add a0, a0, a1
+ bnez a4, 1b
+
+ ret
+.endm
+
+func ff_put_vp8_bilin16_h_rvv, zve32x
+ put_vp8_bilin_h 16
+endfunc
+
+func ff_put_vp8_bilin8_h_rvv, zve32x
+ put_vp8_bilin_h 8
+endfunc
+
+func ff_put_vp8_bilin4_h_rvv, zve32x
+ put_vp8_bilin_h 4
+endfunc
--
レミ・デニ-クールモン
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
2024-02-23 17:17 ` Rémi Denis-Courmont
@ 2024-02-24 1:07 ` flow gg
2024-02-24 7:38 ` Rémi Denis-Courmont
0 siblings, 1 reply; 9+ messages in thread
From: flow gg @ 2024-02-24 1:07 UTC (permalink / raw)
To: FFmpeg development discussions and patches
.ifc \len,4
- vsetivli zero, 5, e8, mf2, ta, ma
+ vsetivli zero, 5, e8, m1, ta, ma
.elseif \len == 8
vsetivli zero, 9, e8, m1, ta, ma
.else
@@ -112,9 +112,9 @@ endfunc
vslide1down.vx v2, \dst, t5
.ifc \len,4
- vsetivli zero, 4, e8, mf4, ta, ma
+ vsetivli zero, 4, e8, m1, ta, ma
.elseif \len == 8
- vsetivli zero, 8, e8, mf2, ta, ma
+ vsetivli zero, 8, e8, m1, ta, ma
What are the benefits of not using fractional multipliers here? Making this
change would result in a 10%-20% slowdown.
mf2/4 m1
vp8_put_bilin4_h_rvv_i32: 158.7 193.7
vp8_put_bilin4_hv_rvv_i32: 255.7 302.7
vp8_put_bilin8_h_rvv_i32: 318.7 358.7
vp8_put_bilin8_hv_rvv_i32: 528.7 569.7
Rémi Denis-Courmont <remi@remlab.net> 于2024年2月24日周六 01:18写道:
> Hi,
>
> +
> +.macro bilin_h_load dst len
> +.ifc \len,4
> + vsetivli zero, 5, e8, mf2, ta, ma
>
> Don't use fractional multipliers if you don't mix element widths.
>
> +.elseif \len == 8
> + vsetivli zero, 9, e8, m1, ta, ma
> +.else
> + vsetivli zero, 17, e8, m2, ta, ma
> +.endif
> +
> + vle8.v \dst, (a2)
> + vslide1down.vx v2, \dst, t5
> +
>
> +.ifc \len,4
> + vsetivli zero, 4, e8, mf4, ta, ma
>
> Same as above.
>
> +.elseif \len == 8
> + vsetivli zero, 8, e8, mf2, ta, ma
>
> Also.
>
> +.else
> + vsetivli zero, 16, e8, m1, ta, ma
> +.endif
>
> + vwmulu.vx v28, \dst, t1
> + vwmaccu.vx v28, a5, v2
> + vwaddu.wx v24, v28, t4
> + vnsra.wi \dst, v24, 3
> +.endm
> +
> +.macro put_vp8_bilin_h len
> + li t1, 8
> + li t4, 4
> + li t5, 1
> + sub t1, t1, a5
> +1:
> + addi a4, a4, -1
> + bilin_h_load v0, \len
> + vse8.v v0, (a0)
> + add a2, a2, a3
> + add a0, a0, a1
> + bnez a4, 1b
> +
> + ret
> +.endm
> +
> +func ff_put_vp8_bilin16_h_rvv, zve32x
> + put_vp8_bilin_h 16
> +endfunc
> +
> +func ff_put_vp8_bilin8_h_rvv, zve32x
> + put_vp8_bilin_h 8
> +endfunc
> +
> +func ff_put_vp8_bilin4_h_rvv, zve32x
> + put_vp8_bilin_h 4
> +endfunc
>
> --
> レミ・デニ-クールモン
> http://www.remlab.net/
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
2024-02-24 1:07 ` flow gg
@ 2024-02-24 7:38 ` Rémi Denis-Courmont
2024-02-24 8:31 ` flow gg
0 siblings, 1 reply; 9+ messages in thread
From: Rémi Denis-Courmont @ 2024-02-24 7:38 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Hi,
Le 24 février 2024 03:07:36 GMT+02:00, flow gg <hlefthleft@gmail.com> a écrit :
> .ifc \len,4
>- vsetivli zero, 5, e8, mf2, ta, ma
>+ vsetivli zero, 5, e8, m1, ta, ma
> .elseif \len == 8
> vsetivli zero, 9, e8, m1, ta, ma
> .else
>@@ -112,9 +112,9 @@ endfunc
> vslide1down.vx v2, \dst, t5
>
> .ifc \len,4
>- vsetivli zero, 4, e8, mf4, ta, ma
>+ vsetivli zero, 4, e8, m1, ta, ma
> .elseif \len == 8
>- vsetivli zero, 8, e8, mf2, ta, ma
>+ vsetivli zero, 8, e8, m1, ta, ma
>
>What are the benefits of not using fractional multipliers here?
Insofar as E8/MF4 is guaranteed to work for Zve32x, there are no benefits per se.
However fractional multipliers were added to the specification to enable addressing invididual vectors whilst the effective multiplier is larger than one. This can only happen with mixed widths. Fractions were not intended to make vector shorter - there is the vector length for that already.
That's why "E64/MF2" doesn't work, even though it's the same vector bit size as "E8/MF2".
> Making this
>change would result in a 10%-20% slowdown.
That's kind of odd. This may be caused by the slides, but it's strange to go out of the way for hardware to optimise a case that's not even intended.
> mf2/4 m1
>vp8_put_bilin4_h_rvv_i32: 158.7 193.7
>vp8_put_bilin4_hv_rvv_i32: 255.7 302.7
>vp8_put_bilin8_h_rvv_i32: 318.7 358.7
>vp8_put_bilin8_hv_rvv_i32: 528.7 569.7
>
>Rémi Denis-Courmont <remi@remlab.net> 于2024年2月24日周六 01:18写道:
>
>> Hi,
>>
>> +
>> +.macro bilin_h_load dst len
>> +.ifc \len,4
>> + vsetivli zero, 5, e8, mf2, ta, ma
>>
>> Don't use fractional multipliers if you don't mix element widths.
>>
>> +.elseif \len == 8
>> + vsetivli zero, 9, e8, m1, ta, ma
>> +.else
>> + vsetivli zero, 17, e8, m2, ta, ma
>> +.endif
>> +
>> + vle8.v \dst, (a2)
>> + vslide1down.vx v2, \dst, t5
>> +
>>
>> +.ifc \len,4
>> + vsetivli zero, 4, e8, mf4, ta, ma
>>
>> Same as above.
>>
>> +.elseif \len == 8
>> + vsetivli zero, 8, e8, mf2, ta, ma
>>
>> Also.
>>
>> +.else
>> + vsetivli zero, 16, e8, m1, ta, ma
>> +.endif
>>
>> + vwmulu.vx v28, \dst, t1
>> + vwmaccu.vx v28, a5, v2
>> + vwaddu.wx v24, v28, t4
>> + vnsra.wi \dst, v24, 3
>> +.endm
>> +
>> +.macro put_vp8_bilin_h len
>> + li t1, 8
>> + li t4, 4
>> + li t5, 1
>> + sub t1, t1, a5
>> +1:
>> + addi a4, a4, -1
>> + bilin_h_load v0, \len
>> + vse8.v v0, (a0)
>> + add a2, a2, a3
>> + add a0, a0, a1
>> + bnez a4, 1b
>> +
>> + ret
>> +.endm
>> +
>> +func ff_put_vp8_bilin16_h_rvv, zve32x
>> + put_vp8_bilin_h 16
>> +endfunc
>> +
>> +func ff_put_vp8_bilin8_h_rvv, zve32x
>> + put_vp8_bilin_h 8
>> +endfunc
>> +
>> +func ff_put_vp8_bilin4_h_rvv, zve32x
>> + put_vp8_bilin_h 4
>> +endfunc
>>
>> --
>> レミ・デニ-クールモン
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel@ffmpeg.org
>https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>To unsubscribe, visit link above, or email
>ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
2024-02-24 7:38 ` Rémi Denis-Courmont
@ 2024-02-24 8:31 ` flow gg
2024-02-28 20:25 ` Rémi Denis-Courmont
0 siblings, 1 reply; 9+ messages in thread
From: flow gg @ 2024-02-24 8:31 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Okay, Thanks for clarifying.
I have used many fractional multipliers, mostly not for correctness, but
often for performance improvements (though I don't know why),
and there are no obvious downsides, How about leaving this code?
Rémi Denis-Courmont <remi@remlab.net> 于2024年2月24日周六 15:39写道:
> Hi,
>
> Le 24 février 2024 03:07:36 GMT+02:00, flow gg <hlefthleft@gmail.com> a
> écrit :
> > .ifc \len,4
> >- vsetivli zero, 5, e8, mf2, ta, ma
> >+ vsetivli zero, 5, e8, m1, ta, ma
> > .elseif \len == 8
> > vsetivli zero, 9, e8, m1, ta, ma
> > .else
> >@@ -112,9 +112,9 @@ endfunc
> > vslide1down.vx v2, \dst, t5
> >
> > .ifc \len,4
> >- vsetivli zero, 4, e8, mf4, ta, ma
> >+ vsetivli zero, 4, e8, m1, ta, ma
> > .elseif \len == 8
> >- vsetivli zero, 8, e8, mf2, ta, ma
> >+ vsetivli zero, 8, e8, m1, ta, ma
> >
> >What are the benefits of not using fractional multipliers here?
>
> Insofar as E8/MF4 is guaranteed to work for Zve32x, there are no benefits
> per se.
>
> However fractional multipliers were added to the specification to enable
> addressing invididual vectors whilst the effective multiplier is larger
> than one. This can only happen with mixed widths. Fractions were not
> intended to make vector shorter - there is the vector length for that
> already.
>
> That's why "E64/MF2" doesn't work, even though it's the same vector bit
> size as "E8/MF2".
>
> > Making this
> >change would result in a 10%-20% slowdown.
>
> That's kind of odd. This may be caused by the slides, but it's strange to
> go out of the way for hardware to optimise a case that's not even intended.
>
> > mf2/4 m1
> >vp8_put_bilin4_h_rvv_i32: 158.7 193.7
> >vp8_put_bilin4_hv_rvv_i32: 255.7 302.7
> >vp8_put_bilin8_h_rvv_i32: 318.7 358.7
> >vp8_put_bilin8_hv_rvv_i32: 528.7 569.7
> >
> >Rémi Denis-Courmont <remi@remlab.net> 于2024年2月24日周六 01:18写道:
> >
> >> Hi,
> >>
> >> +
> >> +.macro bilin_h_load dst len
> >> +.ifc \len,4
> >> + vsetivli zero, 5, e8, mf2, ta, ma
> >>
> >> Don't use fractional multipliers if you don't mix element widths.
> >>
> >> +.elseif \len == 8
> >> + vsetivli zero, 9, e8, m1, ta, ma
> >> +.else
> >> + vsetivli zero, 17, e8, m2, ta, ma
> >> +.endif
> >> +
> >> + vle8.v \dst, (a2)
> >> + vslide1down.vx v2, \dst, t5
> >> +
> >>
> >> +.ifc \len,4
> >> + vsetivli zero, 4, e8, mf4, ta, ma
> >>
> >> Same as above.
> >>
> >> +.elseif \len == 8
> >> + vsetivli zero, 8, e8, mf2, ta, ma
> >>
> >> Also.
> >>
> >> +.else
> >> + vsetivli zero, 16, e8, m1, ta, ma
> >> +.endif
> >>
> >> + vwmulu.vx v28, \dst, t1
> >> + vwmaccu.vx v28, a5, v2
> >> + vwaddu.wx v24, v28, t4
> >> + vnsra.wi \dst, v24, 3
> >> +.endm
> >> +
> >> +.macro put_vp8_bilin_h len
> >> + li t1, 8
> >> + li t4, 4
> >> + li t5, 1
> >> + sub t1, t1, a5
> >> +1:
> >> + addi a4, a4, -1
> >> + bilin_h_load v0, \len
> >> + vse8.v v0, (a0)
> >> + add a2, a2, a3
> >> + add a0, a0, a1
> >> + bnez a4, 1b
> >> +
> >> + ret
> >> +.endm
> >> +
> >> +func ff_put_vp8_bilin16_h_rvv, zve32x
> >> + put_vp8_bilin_h 16
> >> +endfunc
> >> +
> >> +func ff_put_vp8_bilin8_h_rvv, zve32x
> >> + put_vp8_bilin_h 8
> >> +endfunc
> >> +
> >> +func ff_put_vp8_bilin4_h_rvv, zve32x
> >> + put_vp8_bilin_h 4
> >> +endfunc
> >>
> >> --
> >> レミ・デニ-クールモン
> >> http://www.remlab.net/
> >>
> >>
> >>
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel@ffmpeg.org
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >>
> >_______________________________________________
> >ffmpeg-devel mailing list
> >ffmpeg-devel@ffmpeg.org
> >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> >To unsubscribe, visit link above, or email
> >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
2024-02-24 8:31 ` flow gg
@ 2024-02-28 20:25 ` Rémi Denis-Courmont
0 siblings, 0 replies; 9+ messages in thread
From: Rémi Denis-Courmont @ 2024-02-28 20:25 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Le lauantaina 24. helmikuuta 2024, 10.31.36 EET flow gg a écrit :
> Okay, Thanks for clarifying.
>
> I have used many fractional multipliers, mostly not for correctness, but
> often for performance improvements (though I don't know why),
> and there are no obvious downsides, How about leaving this code?
In this case, it does not affect the baseline requirements. It will be
problematic if performance ends up worse on other future designs, but we can
cross that bridge if and then.
--
レミ・デニ-クールモン
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
2024-02-23 14:45 [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h flow gg
2024-02-23 17:17 ` Rémi Denis-Courmont
@ 2024-03-03 14:39 ` Rémi Denis-Courmont
2024-03-03 15:03 ` flow gg
1 sibling, 1 reply; 9+ messages in thread
From: Rémi Denis-Courmont @ 2024-03-03 14:39 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Le perjantaina 23. helmikuuta 2024, 16.45.46 EET flow gg a écrit :
>
Looks like this needs rebasing, or otherwise does not apply.
--
Rémi Denis-Courmont
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
2024-03-03 14:39 ` Rémi Denis-Courmont
@ 2024-03-03 15:03 ` flow gg
2024-03-17 16:42 ` flow gg
0 siblings, 1 reply; 9+ messages in thread
From: flow gg @ 2024-03-03 15:03 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Sorry since I did not send the emails all at once, so cannot apply all 4
patches together with git am *.patch. Instead, it needs to first apply the
patch with 'git am '[PATCH] lavc/vp8dsp: R-V V put_vp8_pixels'', and then
apply the patches 1-3 in the series with 'git am *.patch'.
Rémi Denis-Courmont <remi@remlab.net> 于2024年3月3日周日 22:39写道:
> Le perjantaina 23. helmikuuta 2024, 16.45.46 EET flow gg a écrit :
> >
>
> Looks like this needs rebasing, or otherwise does not apply.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h
2024-03-03 15:03 ` flow gg
@ 2024-03-17 16:42 ` flow gg
0 siblings, 0 replies; 9+ messages in thread
From: flow gg @ 2024-03-17 16:42 UTC (permalink / raw)
To: FFmpeg development discussions and patches
ping
flow gg <hlefthleft@gmail.com> 于2024年3月3日周日 23:03写道:
> Sorry since I did not send the emails all at once, so cannot apply all 4
> patches together with git am *.patch. Instead, it needs to first apply the
> patch with 'git am '[PATCH] lavc/vp8dsp: R-V V put_vp8_pixels'', and then
> apply the patches 1-3 in the series with 'git am *.patch'.
>
> Rémi Denis-Courmont <remi@remlab.net> 于2024年3月3日周日 22:39写道:
>
>> Le perjantaina 23. helmikuuta 2024, 16.45.46 EET flow gg a écrit :
>> >
>>
>> Looks like this needs rebasing, or otherwise does not apply.
>>
>> --
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-03-17 16:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-23 14:45 [FFmpeg-devel] [PATCH 1/3] lavc/vp8dsp: R-V V put_bilin_h flow gg
2024-02-23 17:17 ` Rémi Denis-Courmont
2024-02-24 1:07 ` flow gg
2024-02-24 7:38 ` Rémi Denis-Courmont
2024-02-24 8:31 ` flow gg
2024-02-28 20:25 ` Rémi Denis-Courmont
2024-03-03 14:39 ` Rémi Denis-Courmont
2024-03-03 15:03 ` flow gg
2024-03-17 16:42 ` flow gg
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git