From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 20349436C2 for ; Fri, 22 Jul 2022 02:55:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A837868B697; Fri, 22 Jul 2022 05:55:17 +0300 (EEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 26D2B689B11 for ; Fri, 22 Jul 2022 05:55:09 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658458515; x=1689994515; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=VvTI4FRftnyxWoNbQ7L9Ib/vUYKfr+FXFZDLdTsYGx0=; b=UTeLiost1kf2LL29EI+Sz6peAmmpdRLhi+ayCRsNXnFIYofR118coDn6 hA8Z0Rm75FS2Da4rmnH4slxzyPXkBJUMy+2RNFmGnywatLwruI76hYMAI wGHOQhddQ1auZykUPVDaxBJa2t8oJ0F/vMuEfj8P6NiJ+v/ktXaU8E1mq WtF3Aa9Faron271gSl+QxP2YfsTyxnsvdwQJCNVFtTU8WAaHJut8+R2AB D+knZnwIT6E4TscyNxaqb07P4sNA1dSFIpzWD35kCPw7eO+aa2mEysNPW PCmXxholfNkMzzjyID1zEqoNJo2h6EvpR5IkoC7ccp3ohNjRUmSZIsCFQ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10415"; a="274077896" X-IronPort-AV: E=Sophos;i="5.93,184,1654585200"; d="scan'208";a="274077896" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2022 19:55:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,184,1654585200"; d="scan'208";a="549018160" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 21 Jul 2022 19:55:07 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 21 Jul 2022 19:55:07 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 21 Jul 2022 19:55:06 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 21 Jul 2022 19:55:06 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 21 Jul 2022 19:54:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HGXBoZsR3Utad0ERIkSDKkUKdcc2wPre7qz3qNsDqz+SuD8XwXx4RLVBlZqbzcVMTT8/rLePrTwYzfQ7bNnpXdBHQZnx2jdje8bz7wX9ac/ZXKFmz9YsyOkOjvNyKPI5nDTcIedZWjp9Nw5tzHZLAayu8T/uF4I/iMEkmFHrNQ1slQMk/zyF7uNoekdjd3g89COpgxehRxg9uChy1pVsNGS4cAKWr6auUKLdsCDlKGvN/suTQcgVk2DvrVCYJgn6IzlNq5/nfrSL4GaxA60GivvH9YYjoYOCIOz2SUtWU9Ep8aE8r0Kqv2f5wFoW3ujfMIAlSrOGUVM4FHgmosU12g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VvTI4FRftnyxWoNbQ7L9Ib/vUYKfr+FXFZDLdTsYGx0=; b=c/dONKfCWBrk/Pc/S3C8mAXDTd42jAaXaGJx91SYu9nhRgofOT7rZ4UxlBXXvBK2sQ7d/5+jc3D4M/U8lnLx8wkdTB4USsbwTPRb0SYWp8MDmxG9aKnB/jdsaxjyWwR1sfzQmsiQaI1VMzOQ2GWnW3vA4DjS8KFK1qVn2PXZzz2zMmNwSamQ5AO9Qs+Izytu+EyT5oiYxeVlVetxZDvf0IxZzkQhDddWdJw+IkQqZjefRS5UgFyEdwFwQYFtciqI6pKYTgUGZEyVXqsrjgmcuVooBYP6B0wIIhFHzca1rXrBp7oNQuE8h30E+kvCE2EMl7zLAGnUgLbwKhVPnBMrOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN9PR11MB5225.namprd11.prod.outlook.com (2603:10b6:408:132::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 02:54:51 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5458.018; Fri, 22 Jul 2022 02:54:51 +0000 From: "Xiang, Haihao" To: "anton@khirnov.net" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL Thread-Index: AQHYlbiWkh+MsRsxrU+Jvg1jZyJRRq2EIewAgAEyPICABAH4AIAAa0AA Date: Fri, 22 Jul 2022 02:54:51 +0000 Message-ID: <23fa98e9bd1515b01231d9c6741b27bbe930fc5e.camel@intel.com> References: <20220712062735.20339-1-haihao.xiang@intel.com> <20220712062735.20339-11-haihao.xiang@intel.com> <165814937028.25016.15272296385260114959@lain.khirnov.net> <265318ba163c41537a8a0ad57e7b57671e4211f0.camel@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17eae6ac-7b9e-4af1-6c3e-08da6b8d8c56 x-ms-traffictypediagnostic: BN9PR11MB5225:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kLvPZHhprTlYa4m4s7wEOg/JBwPoG08NOAjjuiujpfbXq2p21Sb5r8UvYb5Ymy2B47A2xR1q0wFuPQsfmOXzDdcZ9sYTDOTDdSU+1OkVTdQE74u3Mqkqigl356sMegLEepT6SrYL3/nmko+EoWxTJglq8WcWKkhVzmf95ZDFWKoTuQJ/zQfMtXSVMq4huT9Q1O+bWytfvDiM26x6uzBJLsJJY/qRQDiZp1l7oeJ7ucougpqJ4ipa8MyHG5Na97hHWrVThd5t0qHh0dRf/dw+7/FP/Rw1TubL4m9hZ/6vfFEjxUFT+KBmOpB3DZ9vHF9kMJlejX+acET0plctgyTSG/Z5Vct5jzESeNzTT8bYzX+KEVOIZ53AwmIkLMiZ81T3esEpdLtxMNA3VvgQvCwWW3JT44UtiWy1M/qHxGBbU6Amyew9qSB7mvPZ8VUxt7TrzZlp8uxv4U7F1N0ZXjgCLsFhU5PzAkCq8d6gAt5m5dHMACcg22l4QZRiMu0ukWFN+2Rk57bfy8Vd5TGltnMvRb7r36K5RNbPP9+ohTJ6DFrZWF8vtafiIGakLJF22KqkAdWRXNJtedgeLab68ei3AOcMBXA3ZTFu4Hq1OihFAFc3AZ7MjI+SGWoOuk5df+klF6Uj0baRv+RV3rjeKy+xWJMn4L+hLmKfaimWwRthz2ARp5qli/MTzr0msv16cLu6AXSnTtyc2s4WAWozAxc1GEj2okuZTeHjC9pPVOaxvEDXqeLMQpXIhgCdjxf8GrLC/GTqRu9TFR/TzHYok6DqIwa9w9Jr6Qy9qyW7+nsTc9OcTeEZcDV0hKnG20eyCaK2XnQi7iPvK578lr+GOC/q7g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(366004)(396003)(136003)(376002)(346002)(36756003)(122000001)(38070700005)(86362001)(6506007)(8936002)(5660300002)(2616005)(26005)(107886003)(82960400001)(53546011)(186003)(83380400001)(6512007)(38100700002)(478600001)(110136005)(91956017)(19627235002)(316002)(41300700001)(71200400001)(64756008)(66476007)(8676002)(76116006)(66556008)(66446008)(4326008)(66946007)(2906002)(6486002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VjZjSlI1OFN5U0tHQjgxMngyTTEzWktUdHBLNWJ2Z2pDZkdzSDJmSWg0dGRU?= =?utf-8?B?K3lFV2lUT1kwZnRudFNVYWt3OXRBbnZiQVJ6SXp4WDdDL0JwMFFkVTVPK1RI?= =?utf-8?B?Z1Ewc3ZkT1kxUHh4Q3F3T0k3TGl6WC95Nys4U3dYL3Q2bDhQU0hEVEZtZlRj?= =?utf-8?B?Zk5UVXptOXkrZ0R6WGlnZzMwMWxsYW1JaVNXaDI5b0xCTEJjbmR3UHVuZGw2?= =?utf-8?B?ZWIzbkQwM0NQOFRjMTRUL011bFdXcVZxMUVlSCtlcmF5SUtITU1QUHRJTGU0?= =?utf-8?B?KzdTYVM1TzlLQm9ieUQzcHF0RWtLYkFzUUcrejJCNU1HZzVHYXlvRnlXTHo1?= =?utf-8?B?MWpPRW1GbDk5TnM4dWxVMG0zdm9hNnpBNysvb0lhNHJKaXdOUzl2S0tlZUNW?= =?utf-8?B?RjBYbU02S3YrTUFjdjNLbFN4RDFZeHE4Qzh3YzIyYmFnR2Jvd0hUTXpRT0FC?= =?utf-8?B?WEk2THB4Tm5RTXlibXk2c2ZIbnUrTzkrYUY0YWRxeVhISm1Qb1VpcDM4Z05W?= =?utf-8?B?TGswYXgrT2tmOWYwNTNBU0xmeURwZU43RFg3dW9KdGUvd2hIcVYvTXdacXhO?= =?utf-8?B?eUgybnoyWW5NNXVBaVEwK0lZb0dKcStCOXM2dkEvUHRGTm1CL3BZRVJhWnFi?= =?utf-8?B?WjBEbWY3YjRoT0cySEw1QThwekR3WDkyalpFekE2NzZzdjBJY0pXUTRKOHlM?= =?utf-8?B?NTJsb1VqclUwNnlqTzQvclFxK3hNcVh0WHUvM3l6RXZkUWQzaGloUG9ZYktn?= =?utf-8?B?YVVhN20vaXltTkpoQThNWUw1YUliNkNxVnFkSGRQMVhjcHpsZVlKR1oycGE3?= =?utf-8?B?VTdZWHBpUzNLRWIvRHM2d3JhVnhmeWtQL3pVVkswWUpyYlVNdVVrRC9RMThv?= =?utf-8?B?KzhFQnArOExDR1FEUHlOQlR3Z0l1c2dxa3FJRUlKcUxpcnZ1cDgwVnN1alhS?= =?utf-8?B?d09lcjh1MEd6dDRLNnczOWR2c1VHM1U4M3IyQk9jZ2F6djdtU1NNK3o5OThG?= =?utf-8?B?OEMrcm1kb0lVQlowaEZJNjkyNmpxeUgxeXRJUkdkd1Z5Mk83K1Z1eDNvQlRG?= =?utf-8?B?amV4S0paeGZ3eWZvdmlDUkV5Y2ZmVDFZaE50SnBIZkdNWnVFU3FPaC9FQW9h?= =?utf-8?B?L3BEazFtQWZMNEhDWUoySnJEQWU1enVJU0Y0SkJDaUN6V2M4bkZsWi8xMmd5?= =?utf-8?B?d1VSb1ZSTjlNK0RYYTNJUC9peGpPUmNGZnQ3dFJPMVlFY0pUbHJWQ1lEdlN5?= =?utf-8?B?MzBuMlZnWk1PNHNwd2ZTeElxbXJpOFRNd0l0Z2o2YlJBVWNML1lvUGovUFJw?= =?utf-8?B?Q2lMbzM2TDU0VG5RaWlPSi9UREVGbFo0NWdTRXBsSlN6ZXBaT3VmdDY0L0lJ?= =?utf-8?B?SVNXdnljbnBsQkFydDQzUSs3cXVBUm43STAvZjNydkhyZ1ROVVA4WnhwT0RL?= =?utf-8?B?WUh4aUZJcXF1bkpuV0hPNGZ1d3RxK1gxdjdSakVobVhqY0I4akdwZnpyQUt6?= =?utf-8?B?WTR0Y3pXUXkvMjdla3R2a0VxSnNIUnhHbGRVZ2F6QlVhU3FPOG5qekRFNisv?= =?utf-8?B?empNdWpaNkdGdTJHUFpydUtIa0RtVlBHRnJ3UURkb0UyZkYybXF4U1RRSncv?= =?utf-8?B?cmVORHdjSlNBbmx2R1lDSm4zZ2JsNE8rY25IcVkwSkdSKyt3MW5nYUNFNTBs?= =?utf-8?B?d1cxalByUzJvdjRvOHR5MmRzV09scjFUeWVnWm1VOEx5MXo5dWRRM3pHSW9D?= =?utf-8?B?YXVralN2UTdOdFpBZ2h5UzgvamZUTUpCTVhqU0xCZ1h3U2pxOURpK2lxQXBj?= =?utf-8?B?bW8wOXpSQ1RKcVpiSzI0UmhOdjZ5SlIrLy9vV3ZLTG1qYkFhcThiV2RUZU5k?= =?utf-8?B?MDlWTzJYeUhVc1VzWXc0UWdYSjNNcTNqMXAwWEtNN2MzUGtFd254a01WK3dK?= =?utf-8?B?RitwM2xTUzUydUNyc21ZcEh0Qkp5d1RKUFJiWEdRUnVhL2NONy9sQVJjeEk1?= =?utf-8?B?ZEE4SVh0Tm5ReEhGQUNSMEFuREpxQ2gva0xTTlZ6TnNadnA0S01pdUQ0YS9G?= =?utf-8?B?UU9EY1lXc2t2TTViK3lHdDVUQ3VjcjRtSk5aY1k3VnVPc3NlcUV3T3NRdHdh?= =?utf-8?B?U3BDd05hVDNsSHN6T2RFN0h1TE81cEF3a21IZ2xQTUp6VjFrSGdaR0ZoUm1E?= =?utf-8?B?OGc9PQ==?= Content-ID: <6F4CDD19F528444B8841264165828C4B@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17eae6ac-7b9e-4af1-6c3e-08da6b8d8c56 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2022 02:54:51.5225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fo83F1WuMacKgHM2d629Jc0v2jntc52O2X6yWjeS9q2DN7CiDH8ORKO8DPfWX2MzjS9SoN7FHDr2rwTM+PDVUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5225 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Galin, Artem" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-07-21 at 20:30 +0000, Soft Works wrote: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Xiang, Haihao > > Sent: Tuesday, July 19, 2022 9:19 AM > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > Cc: Galin, Artem > > Subject: Re: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: > > make qsv hwdevice works with oneVPL > > > > On Mon, 2022-07-18 at 15:02 +0200, Anton Khirnov wrote: > > > Quoting Xiang, Haihao (2022-07-12 08:27:32) > > > > +static int qsv_va_update_config(void *ctx, mfxHDL handle, > > > > mfxConfig cfg) > > > > +{ > > > > +#if CONFIG_VAAPI > > > > +#if VA_CHECK_VERSION(1, 5, 0) > > > > +#define LOCAL_VADISPLAYPCIID VADisplayPCIID > > > > +#else > > > > +#define LOCAL_VADISPLAYPCIID 21 > > > > +#endif > > > > + mfxStatus sts; > > > > + VADisplay dpy = handle; > > > > + VAStatus vas; > > > > + VADisplayAttribute attr = { > > > > + .type = LOCAL_VADISPLAYPCIID > > > > + }; > > > > + mfxVariant impl_value; > > > > + > > > > + vas = vaGetDisplayAttributes(dpy, &attr, 1); > > > > + if (vas == VA_STATUS_SUCCESS && attr.flags != > > > > VA_DISPLAY_ATTRIB_NOT_SUPPORTED) { > > > > + impl_value.Type = MFX_VARIANT_TYPE_U16; > > > > + impl_value.Data.U16 = (attr.value & 0xFFFF); > > > > + sts = MFXSetConfigFilterProperty(cfg, > > > > + (const mfxU8 > > > > *)"mfxExtendedDeviceId.DeviceID", impl_value); > > > > + if (sts != MFX_ERR_NONE) { > > > > + av_log(ctx, AV_LOG_ERROR, "Error adding a MFX > > > > configuration" > > > > + "DeviceID property: %d.\n", sts); > > > > + goto fail; > > > > + } > > > > + } else > > > > + av_log(ctx, AV_LOG_WARNING, "Cannot get device id from > > > > the driver, > > > > the default " > > > > + "MFX implementation will be loaded for this > > > > device. Please > > > > consider to " > > > > + "upgrade the driver to support VAAPI 1.5.0. \n"); > > > > > > I would still prefer to fail here. The user requested a specific > > > > device, > > > disregarding that request is evil. > > > > Thanks for the comment. There is only one available device for most > > users, so > > the default one and the given one from user should be the same, > > otherwise it > > won't work. I don't want to make them in trouble if they don't have a > > driver to > > support the new interface. However I agree with you it is a little > > evil to > > ignore the request. I'll update the patch to return error here. > > I'm not a fan of that kind of automagic behavior. Quick success > experiences are surely desirable in general, but we also need to > consider the effects of such behavior - in this case, that would > mean: It doesn't really matter what a user specifies for the parameter, > because it will always work anyway. > > In turn, users may start to think that their wrong command with the > wrong ID would be right, and then, in a subsequent command > use that wrong ID again in different context, where it might fail, > while in turn maximizing confusion. > > When it is possible to internally retrieve potentially valid > values, why not output something useful like: "XXID failed, you > might want to try A, B or C" (or similar)? Agree, and this is fixed in the new version. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".