From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2192743BA3 for ; Wed, 20 Jul 2022 08:57:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4DA4968B638; Wed, 20 Jul 2022 11:57:08 +0300 (EEST) Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C917668B462 for ; Wed, 20 Jul 2022 11:57:02 +0300 (EEST) Message-ID: <23e2a9d3-34cf-9cd1-62ef-f2d8686c4688@zanevaniperen.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zanevaniperen.com; s=key1; t=1658307422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7oe7OCkgXz4QTHX6Ow6zmmhXJrIxLhrlWQKbRcm0rQ4=; b=T2YK+B+RbiqzIAqsgrgSxW+tVFHXT6q1AoC+6C2OEa4ZSXj6+X5bLqJ5Al0aHD1yhnLxLu mjotLhABZnV0DGRdNAmfKF3+ZtOgw56hIM/dGT7Io68MsxlTtBJyJEK8hZYk3QxHBVe9UX eq627+kG94QKS1ZciP4/F9+vRLcRWklrCgsICxExOfzxLaZs6dqpeCELXwIWDox6ljK7+l 3saXM+n+vfrHQggiumcZGw9jnTJRUX37RK/6b/zdepso+RFTVGlsxUN7fedyynYTGHgBS9 gDX1nVzN5WeqsXMEy15Gju5V/0CR97908xYOdbyo0c25iq1nCkmXdbg+FksIPQ== Date: Wed, 20 Jul 2022 18:56:56 +1000 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20220717133143.881124-1-zane@zanevaniperen.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zane van Iperen In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: zanevaniperen.com Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/argo_cvg: name unk{1, 2} fields correctly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 18/7/2022 11:45 pm, Andreas Rheinhardt wrote: >> av_log(s, AV_LOG_TRACE, "size = %u\n", ctx->header.size); >> - av_log(s, AV_LOG_TRACE, "unk = %u, %u\n", ctx->header.unk1, ctx->header.unk2); >> + av_log(s, AV_LOG_TRACE, "loop = %u\n", ctx->header.loop); >> + av_log(s, AV_LOG_TRACE, "reverb = %u\n", ctx->header.reverb); > > %u is for unsigned, yet these variables are of type uint32_t. It is not > guaranteed that these two types are the same (yet they typically are). > That's why the PRI-macros exist. Good catch, I'll rectify that. > (Apart from that: Does this have to be three separate av_logs?) > I can probably just remove them, now that I know what the fields are. Although, I wouldn't mind exposing them as additional metadata... _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".