From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id F3E8941A08
	for <ffmpegdev@gitmailbox.com>; Fri, 20 May 2022 10:17:30 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E8D5568B4A0;
	Fri, 20 May 2022 13:17:19 +0300 (EEST)
Received: from btbn.de (btbn.de [136.243.74.85])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D50768B142
 for <ffmpeg-devel@ffmpeg.org>; Fri, 20 May 2022 13:17:13 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id EFC692D4497
 for <ffmpeg-devel@ffmpeg.org>; Fri, 20 May 2022 12:17:12 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1653041833;
 bh=cAtSgbFeT6xS498XoQ/8pVBSeRAxT2DSLU1gL12SJFo=;
 h=Date:Subject:To:References:From:In-Reply-To;
 b=sCpU/RioxSF03LSYAWbewTaq2OP0JetqOe1417rq1nF6P9aXRhps104QgCJ3RYYGL
 ess8paRkumQjhhusuiZcmT/NJ0cyXAMj9lz7NdjnbZnURJiBrxzI7PBJo7dUCVLp4y
 oZkRn3mzMfgr/R8oPGsgG2bGCcKwSk2Rni6h74C23fEzspw+mUkYYrhM717bwnic8L
 FJoEQjBtFhU+bkwCSEBq5I15qGl250AT7ZFNZK0yPnTD9+0SCi6CeLEdbMFxdMrlFL
 022ualv9kOz2NCEF2W1x+hMLVcIgSQq6tX4ONpZMIJr0viCrEdfDGvMFfaMd0yfS3m
 qmpw+dYn4QIXA==
Message-ID: <23cc0bf5-9cef-5b8d-7e4d-440776cd2e5f@rothenpieler.org>
Date: Fri, 20 May 2022 12:18:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <pull.29.ffstaging.FFmpeg.1653000752870.ffmpegagent@gmail.com>
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <pull.29.ffstaging.FFmpeg.1653000752870.ffmpegagent@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define
 X264_API_IMPORTS when compiling static
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/23cc0bf5-9cef-5b8d-7e4d-440776cd2e5f@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 20/05/2022 00:52, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> 
> The definition of X264_API_IMPORTS is required for shared linking
> (when MSVC is used) but it must not be defined in case of static
> builds as is stated in x264.h:

This doesn't seem right. It's about shared or static linking of libx264 
itself, not ffmpeg.
The correct flag should come via pkg-config at configure time.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".