From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0A1DA42657 for ; Mon, 21 Mar 2022 21:03:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23C0368B14F; Mon, 21 Mar 2022 23:03:23 +0200 (EET) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 04A4068A8A0 for ; Mon, 21 Mar 2022 23:03:17 +0200 (EET) Received: by mail-oo1-f44.google.com with SMTP id p10-20020a056820044a00b00320d7d4af22so20687358oou.4 for ; Mon, 21 Mar 2022 14:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=vr2N/UyDfjn1vkfKVrt0A15uL2/h0V+3o4AVFdb4j2w=; b=R67N/UjDgvOdztFsQNlqpcyc9XcFLbVUfmRQle4P19ewL9UQ7cb8P1YYrYgsSkBmIh pZ6/G72ShlMaC1E436+5C0QojcL74G3n8LygguJFZbsi+8nd5OPxbkbWY0xAsCSZXNRi iIG0BPi5loFKnSUi850KZvADbxQwwsqar4LZcVuknOcb7rgCKUzZVQgeoc7/8QuMQ3bX 1RWHaWEbCh0iwqlNsCWBWFJ6BbVi1qbY4liW3cNFAt2MrOfCF9+MdBZ7P+Rx+S+ZNUuL NpJrCuU1rEUn/djbL8/oWCE+xPb5ABVP84K2hqlBaVfmS6+YwU4bwOOG1dEWLSMywuTZ 4PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=vr2N/UyDfjn1vkfKVrt0A15uL2/h0V+3o4AVFdb4j2w=; b=6mbZyKAoaULf53hTjIk8dzFqG2Q89iplzEHOCG/SZ4PumrsT0RltQv5Y3a+jgZBSst 9ProqI6MmUvGk/h4oi65z1VQ60yHx3EkFoZ4yhw4y9c/7CTP1S2/JfUCLDItSSaeXuP8 0Bk7ei3kTDl8LP6nU3GLLOZF2+QzvJCAaDVjilSvaJf9hvqCDYvL8sEx8Ap6X9dGw22P d6pmonQY2i2dXShWAs38l6AHCGsAc0zBWGEZcuNNiFMuN/hg/MzSAmAetRPR1ThuMRrk V42dy6JUZ6FEjQ2W17IFanqdScLPbrPIb+LDa64UzYgxjbt+wmBQVo30bRHFIa9zTLdp B4lw== X-Gm-Message-State: AOAM532nC77/irbXINXI07h29qQM+PnRR4Xg7q/BEoi50J7MYWTjvQTC ii1JaA61vIVfYbrSGVNPFNea63aeUWqLMw== X-Google-Smtp-Source: ABdhPJxaS6zfD4+vrxhoz5F7ZChkm4RR4lqfcdxA4lJepfv4Yp93JAWH5+wDiEObUbvZee7lcVISLA== X-Received: by 2002:a05:6870:d207:b0:de:1872:fe43 with SMTP id g7-20020a056870d20700b000de1872fe43mr418665oac.242.1647896594993; Mon, 21 Mar 2022 14:03:14 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id c17-20020a056830001100b005b236450790sm7811172otp.77.2022.03.21.14.03.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 14:03:14 -0700 (PDT) Message-ID: <232d5031-97f1-243a-92e4-879ccad9477e@gmail.com> Date: Mon, 21 Mar 2022 18:03:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220201185239.13450-1-michael@niedermayer.cc> <20220201185239.13450-2-michael@niedermayer.cc> From: James Almer In-Reply-To: <20220201185239.13450-2-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: Check tile_cols X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/1/2022 3:52 PM, Michael Niedermayer wrote: > Fixes: division by zero > Fixes: 43769/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5392562205097984 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/av1dec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index 62d459cded..581f22a849 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c > @@ -394,6 +394,9 @@ static int get_tiles_info(AVCodecContext *avctx, const AV1RawTileGroup *tile_gro > s->tg_start = tile_group->tg_start; > s->tg_end = tile_group->tg_end; > > + if (s->raw_frame_header->tile_cols == 0) This should not happen. CBS should have returned an error instead or setting tile_cols to 0. The bug should probably be fixed there. > + return AVERROR_INVALIDDATA; > + > for (tile_num = tile_group->tg_start; tile_num <= tile_group->tg_end; tile_num++) { > tile_row = tile_num / s->raw_frame_header->tile_cols; > tile_col = tile_num % s->raw_frame_header->tile_cols; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".