From: Alessandro Di Nepi <alessandro.dinepi@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback
Date: Sun, 11 Dec 2022 11:57:20 +0200
Message-ID: <22b7ed62-c6ac-45fe-b58b-666f7eae9e97@Spark> (raw)
In-Reply-To: <tencent_A52AA693035C458B92E60750B066C267D106@qq.com>
On 9 Dec 2022, 6:45 +0200, FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>, wrote:
> Did you call av_videotoolbox_default_init() or av_videotoolbox_default_init2()?
Actually yes, I call `av_videotoolbox_default_init(context);`
> I think that’s why avctx->internal->hwaccel_priv_data is NULL. That code path is broken.
> Does remove the call of av_videotoolbox_default_init()/av_videotoolbox_default_init2() works for you?
Definitively yes, if I remove the call to `av_videotoolbox_default_init` the context is fine.
Thanks for sorting this out. I'd like to contribute and have this fixed or documented for other people.
What should be the desired behavior? Calling `av_videotoolbox_default_init` and having the context not NULL?
Or shall we remove the init at all?
Best Regards
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-11 9:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 17:33 Alessandro Di Nepi
2022-11-29 16:46 ` Alessandro Di Nepi
2022-12-04 14:02 ` Alessandro Di Nepi
2022-12-04 15:00 ` Rick Kern
2022-12-04 17:51 ` Alessandro Di Nepi
2022-12-05 13:36 ` Rick Kern
2022-12-06 5:19 ` "zhilizhao(赵志立)"
2022-12-06 16:30 ` Alessandro Di Nepi
2022-12-09 4:44 ` "zhilizhao(赵志立)"
2022-12-11 9:57 ` Alessandro Di Nepi [this message]
2022-12-15 14:16 ` Alessandro Di Nepi
2022-12-15 14:45 ` Zhao Zhili
2023-01-09 14:48 ` Zhao Zhili
[not found] <53dafc80-d9f6-4b5b-a7a5-781bbb045493@Spark>
2022-11-27 16:21 ` Alessandro Di Nepi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b7ed62-c6ac-45fe-b58b-666f7eae9e97@Spark \
--to=alessandro.dinepi@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git