From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 50DAE44D6D for ; Fri, 23 Dec 2022 11:47:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C8D5668B9FF; Fri, 23 Dec 2022 13:47:09 +0200 (EET) Received: from mail.frobbit.se (mail.frobbit.se [85.30.129.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8854C68092B for ; Fri, 23 Dec 2022 13:47:03 +0200 (EET) Received: from [192.168.1.75] (217-208-223-222-no2430.tbcn.telia.com [217.208.223.222]) by mail.frobbit.se (Postfix) with ESMTPSA id C6B1D1FEA9 for ; Fri, 23 Dec 2022 12:47:02 +0100 (CET) Message-ID: <22aa81a6cbb26b250dec7a5d44dc275c6e95f801.camel@haerdin.se> From: Tomas =?ISO-8859-1?Q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Fri, 23 Dec 2022 12:47:02 +0100 In-Reply-To: <20221222232559.GE3806951@pb2> References: <20221112234401.24158-1-michael@niedermayer.cc> <20221112234401.24158-3-michael@niedermayer.cc> <41b2da576f810e3a0ef9439b2b496c98d583d887.camel@haerdin.se> <20221222232559.GE3806951@pb2> User-Agent: Evolution 3.38.3-1+deb11u1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: Reduce overflows in essence_length computation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: ZnJlIDIwMjItMTItMjMga2xvY2thbiAwMDoyNSArMDEwMCBza3JldiBNaWNoYWVsIE5pZWRlcm1h eWVyOgo+IE9uIFdlZCwgTm92IDE2LCAyMDIyIGF0IDEyOjQ5OjEwUE0gKzAxMDAsIFRvbWFzIEjD pHJkaW4gd3JvdGU6Cj4gPiBzw7ZuIDIwMjItMTEtMTMga2xvY2thbiAwMDo0NCArMDEwMCBza3Jl diBNaWNoYWVsIE5pZWRlcm1heWVyOgo+ID4gPiBGaXhlczogc2lnbmVkIGludGVnZXIgb3ZlcmZs b3c6IC0zNzQxMzE5MTY5IC0gOTIyMzM3MjAzNjgyMzQ0OTM3MAo+ID4gPiBjYW5ub3QgYmUgcmVw cmVzZW50ZWQgaW4gdHlwZSAnbG9uZycKPiA+ID4gRml4ZXM6IDUxODk2L2NsdXN0ZXJmdXp6LXRl c3RjYXNlLW1pbmltaXplZC0KPiA+ID4gZmZtcGVnX2RlbV9NWEZfZnV6emVyLQo+ID4gPiA1MTMw Mzk0Mjg2ODE3MjgKPiA+ID4gCj4gPiA+IEZvdW5kLWJ5OiBjb250aW51b3VzIGZ1enppbmcgcHJv Y2VzcyAKPiA+ID4gaHR0cHM6Ly9naXRodWIuY29tL2dvb2dsZS9vc3MtZnV6ei90cmVlL21hc3Rl ci9wcm9qZWN0cy9mZm1wZWcKPiA+ID4gU2lnbmVkLW9mZi1ieTogTWljaGFlbCBOaWVkZXJtYXll ciA8bWljaGFlbEBuaWVkZXJtYXllci5jYz4KPiA+ID4gLS0tCj4gPiA+IMKgbGliYXZmb3JtYXQv bXhmZGVjLmMgfCAxMCArKysrKysrLS0tCj4gPiA+IMKgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9saWJhdmZv cm1hdC9teGZkZWMuYyBiL2xpYmF2Zm9ybWF0L214ZmRlYy5jCj4gPiA+IGluZGV4IGU2MTE4ZTE0 MWQuLjQyMTA5Y2I0M2EgMTAwNjQ0Cj4gPiA+IC0tLSBhL2xpYmF2Zm9ybWF0L214ZmRlYy5jCj4g PiA+ICsrKyBiL2xpYmF2Zm9ybWF0L214ZmRlYy5jCj4gPiA+IEBAIC0xMDAsNyArMTAwLDcgQEAg dHlwZWRlZiBzdHJ1Y3QgTVhGUGFydGl0aW9uIHsKPiA+ID4gwqDCoMKgwqAgdWludDY0X3QgcHJl dmlvdXNfcGFydGl0aW9uOwo+ID4gPiDCoMKgwqDCoCBpbnQgaW5kZXhfc2lkOwo+ID4gPiDCoMKg wqDCoCBpbnQgYm9keV9zaWQ7Cj4gPiA+IC3CoMKgwqAgaW50NjRfdCB0aGlzX3BhcnRpdGlvbjsK PiA+ID4gK8KgwqDCoCB1aW50NjRfdCB0aGlzX3BhcnRpdGlvbjsKPiA+ID4gwqDCoMKgwqAgaW50 NjRfdCBlc3NlbmNlX29mZnNldDvCoMKgwqDCoMKgwqDCoMKgIC8vLzwgYWJzb2x1dGUgb2Zmc2V0 IG9mCj4gPiA+IGVzc2VuY2UKPiA+ID4gwqDCoMKgwqAgaW50NjRfdCBlc3NlbmNlX2xlbmd0aDsK PiA+ID4gwqDCoMKgwqAgaW50MzJfdCBrYWdfc2l6ZTsKPiA+ID4gQEAgLTM1MTksOCArMzUxOSwx MiBAQCBzdGF0aWMgdm9pZAo+ID4gPiBteGZfY29tcHV0ZV9lc3NlbmNlX2NvbnRhaW5lcnMoQVZG b3JtYXRDb250ZXh0ICpzKQo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcC0+ZXNzZW5j ZV9vZmZzZXQgPSBwLT5maXJzdF9lc3NlbmNlX2tsdi5vZmZzZXQ7Cj4gPiA+IMKgCj4gPiA+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAvKiBlc3NlbmNlIGNvbnRhaW5lciBzcGFucyB0byB0aGUg bmV4dCBwYXJ0aXRpb24gKi8KPiA+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHggPCBt eGYtPnBhcnRpdGlvbnNfY291bnQgLSAxKQo+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHAtPmVzc2VuY2VfbGVuZ3RoID0gbXhmLQo+ID4gPiA+IHBhcnRpdGlvbnNbeCsxXS50 aGlzX3BhcnRpdGlvbiAtIHAtPmVzc2VuY2Vfb2Zmc2V0Owo+ID4gPiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBpZiAoeCA8IG14Zi0+cGFydGl0aW9uc19jb3VudCAtIDEpIHsKPiA+ID4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAobXhmLT5wYXJ0aXRpb25zW3grMV0udGhpc19w YXJ0aXRpb24gPCBwLQo+ID4gPiA+IGVzc2VuY2Vfb2Zmc2V0KSB7Cj4gPiA+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwLT5lc3NlbmNlX2xlbmd0aCA9IC0xOwo+ID4g PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0gZWxzZQo+ID4gPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcC0+ZXNzZW5jZV9sZW5ndGggPSBteGYtCj4g PiA+ID4gcGFydGl0aW9uc1t4KzFdLnRoaXNfcGFydGl0aW9uIC0gcC0+ZXNzZW5jZV9vZmZzZXQ7 Cj4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiA+IAo+ID4gQSBiZXR0ZXIgc29sdXRp b24gbWlnaHQgYmUgdG8gcmVjb3JkIHRoZSBhY3R1YWwgb2Zmc2V0IG9mIHRoZQo+ID4gcGFydGl0 aW9ucyByYXRoZXIgdGhhbiByZWx5aW5nIG9uIFRoaXNQYXJ0aXRpb24uIFRoZW4gd2UgY2FuCj4g PiBndWFyYW50ZWUKPiA+IHRoYXQgdGhleSBhcmUgc3RyaWN0bHkgaW5jcmVhc2luZy4KPiAKPiBk byB5b3UgbWVhbiB0aGF0IHBhY2tfb2ZzIGNvdWxkIGJlIHVzZWQgaGVyZSA/Cgp0aGlzX3BhcnRp dGlvbiBzaG91bGQgYmUgPT0gcGFja19vZnMgLSBydW5faW4uIEkgdGhpbmsgd2UgY2FuIGp1c3Qg bnVrZQp0aGlzX3BhcnRpdGlvbiBpbiB0aGUgc3RydWN0IGFuZCB1c2UgcGFja19vZnMgLSBydW5f aW4gZXZlcnl3aGVyZS4gRW1pdAphIHdhcm5pbmcgb3IgYmFpbCBvdXQgaWYgYW55IHBhcnRpdGlv biBkb2VzIG5vdCBvYmV5IHRoaXMgY29udHJhaW50LApzaW5jZSBzdWNoIGZpbGVzIGhhdmUgbGlr ZWx5IGJlZW4gd3JpdHRlbiBieSBiYWQgbXV4ZXJzLgoKCj4gYnV0IGFzIHBhY2tfb2ZzIGlzIHNp Z25lZCB0aGF0IGVpdGhlciBtZWFucyBkZWFsaW5nIHdpdGggcG90ZW50aWFsbHkKPiBuZWdhdGl2 ZQo+IG9yIGNoYW5naW5nIGl0IHRvIHVpbnQ2NF90IG9yIGFkZGluZyBhIG5ldyBmaWVsZCBhbmQg YXZpb190ZWxsKCkKPiBzb21ld2hlcmU/CgpwYWNrX29mcyBjYW4gb25seSBiZSBuZWdhdGl2ZSBp biBjYXNlIG9mIGVycm9yLCBpbiB3aGljaCBjYXNlIHdlIHNob3VsZApiYWlsIG91dCBhbnl3YXku IFNvbWV0aGluZyBtdXN0IGJlIHZlcnkgd3JvbmcgaWYgbGF2ZiBjYW4ndCBhdmlvX3RlbGwoKQoK Rm9yIGV2ZXJ5IHBhcnRpdGlvbiwgcGFja19vZnMgPj0gcnVuX2luLiB0aGlzX3BhcnRpdGlvbiA+ PSAwLCBhbmQgaW4KcGFydGljdWxhciB0aGlzX3BhcnRpdGlvbiA9PSAwIGZvciB0aGUgdmVyeSBm aXJzdCBwYXJ0aXRpb24uCgpUaGlzIGlzIHJlbWluZGluZyBtZSB0aGF0IEkgaGFkIHNvbWUgZmlu ZXIgcG9pbnRzIHRvIGZpeCByZWxhdGVkIHRvCnJ1bl9pbiBhbmQgZGVsZXRpbmcgdGhlIHN1cGVy Zmx1b3VzIHN5bmMgc3R1ZmYgdGhhdCdzIGN1cnJlbnRseSBpbiB0aGUKY29kZS4gQmFwdGlzdGUg aXMgZmluZSB3aXRoIHRoYXQsIGFzIGl0J3MgYSByZWxpYyBmcm9tIHdoZW4gbXhmZGVjCmRpZG4n dCBoYXZlIHByb3BlciBzZWVrIHN1cHBvcnQuCgovVG9tYXMKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmZmbXBlZy1kZXZlbCBtYWlsaW5nIGxpc3QKZmZt cGVnLWRldmVsQGZmbXBlZy5vcmcKaHR0cHM6Ly9mZm1wZWcub3JnL21haWxtYW4vbGlzdGluZm8v ZmZtcGVnLWRldmVsCgpUbyB1bnN1YnNjcmliZSwgdmlzaXQgbGluayBhYm92ZSwgb3IgZW1haWwK ZmZtcGVnLWRldmVsLXJlcXVlc3RAZmZtcGVnLm9yZyB3aXRoIHN1YmplY3QgInVuc3Vic2NyaWJl Ii4K