From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 99A574C163 for ; Wed, 5 Feb 2025 21:24:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4585868B906; Wed, 5 Feb 2025 23:24:13 +0200 (EET) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 75AE068B3AF for ; Wed, 5 Feb 2025 23:24:07 +0200 (EET) Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5439a6179a7so217725e87.1 for ; Wed, 05 Feb 2025 13:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1738790646; x=1739395446; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=fI84/t9iE/Wg8E3H0G2fGL0W+XwleCpUnmfhL/iyl9g=; b=SKTWCalE32bLN4Lx+mzRXUB7/FyP2SG93/mDgTxpDXwQxE4Qd4WvDc3JhXDo7QvvmM UGNPX9nTPMuVbLlMlCllPU/D+OY58ISLV2k8+53JQUWFg4Eoo4aPL61tDiASVFMJ/Hft 7D7VteH9DDtuwiFdZrLeOAs94SAhs3t6Fr9rJHKBj/yWZiKE9+G5oB9zoUUJYI8Q10k0 BXhGgRBbvbfm20touBfXV+aMjWHFXY+jYdT1xgIwigDf3EpTuyZHOqTbFVrAY5MOO+O3 l9HvnSQnAOEx9DIqSec+XwtWU7DgkI+ZRY33LDDrj0i7gaUDTUNzHdAiPDsc1dokz212 fZCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738790646; x=1739395446; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fI84/t9iE/Wg8E3H0G2fGL0W+XwleCpUnmfhL/iyl9g=; b=CvZXzS1y7g0gT8iwat4NxyiTSoXCuVTkgWjeAhEe+mHfKXGylJWFPtqq5L9mSPUaVG 5H18jogY4j4iCnsGjhi1wj7nLmTXuG3Hp06w/rTH2afz1ooxRaKoyCTZWFuNuuCBeXf4 XOYAQuHUoFnwbHpidVAfLERuPCqIZtHrxiqKiNJ5KsahTL7ltFKnhgOegyDZeZg+/e6C bQ0X7IPjlR1f1A6jhvnVewTFy2i23lx7Bv1g3m18GO6tUdoBl86wGS7w0I87YKLpG1Fl +x/estD9qggi3Y9mOCrWQwEQTLRtKXz2NoEclfaOWfvDrDDFmga4rpolNsM6ISx2mjnv DrSg== X-Gm-Message-State: AOJu0YwOIvAW1vvWapyiTNGWH+zOR3IZqBxwy2rhSmlbjypTABgwvaUe +wtYid9w82ly5ESoVfQ/40A3ChHu4HPeVkYHesf/AmqVUlo/Qwn0b99cFkmrdEGUVuNE8UU3ejG 4uQ== X-Gm-Gg: ASbGncvC+65EdjvSK59l5UztvyAJRiukWZNVB7fTfNJpMOpyN0nEmR9P44K20KnARdF LpaUZPqb64W6H2uPoAyFREjadKLIxZW7cDoAoF2FJukPIteKEvRiyal1Un+LD0ZWbNMCYPImR90 1KQrKbxUgcwEvoeJ/U2oXfbIKv5u/i3D7BbhKgvI9Ea6Wo/DyqvxTCuPts938W/U1x90GjJoK4l iSFu1WgSNvOlUTZQSL7cuCYfmqp0c3ZqE5CJ8BbnVAZ/poGnvtjAY5GeSSFeZA0fGHRI23pNkrt 5+UwR4gUGeQp+cth3l2LKZRFshCVcdLaHoibFaqU4jmzZZvdHA8A9GH/5MTCwsSQY8hEEDJsWdG yyLvikQN4oAw= X-Google-Smtp-Source: AGHT+IFSVWErXU9+7iRVN3CcCnuoDchSHVOxl3j2x3rl+18OGXNw5ED4Y+XSUBCz6ZsuoT2qljuF0w== X-Received: by 2002:a05:6512:2002:b0:542:8e2c:b279 with SMTP id 2adb3069b0e04-5440e62e061mr245860e87.2.1738790646427; Wed, 05 Feb 2025 13:24:06 -0800 (PST) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-543ebe0fbfcsm2022210e87.70.2025.02.05.13.24.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 13:24:05 -0800 (PST) Date: Wed, 5 Feb 2025 23:24:03 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20250201232529.GV4991@pb2> Message-ID: <21cc437-ce40-f750-ab4-92419f93559d@martin.st> References: <20250129095854.44025-1-martin@martin.st> <20250201232529.GV4991@pb2> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] checkasm: aacencdsp: Actually initialize ff_aac_pow34sf_tab X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 2 Feb 2025, Michael Niedermayer wrote: > On Wed, Jan 29, 2025 at 11:58:54AM +0200, Martin Storsj=F6 wrote: >> This table is zero initialized by default, and has to be >> explicitly initialized. >> >> Coincidentally, this fixes linking checkasm with Apple's older >> linker. (In Xcode 15, Apple switched to a new linker. The one in >> older toolchains seems to have a bug where it won't figure out to >> load object files from a static library, if the only symbol >> referenced in the object file is a "common" symbol, i.e. one for >> a zero-initialized variable. This issue can also be reproduced with >> newer Apple toolchains by passing -Wl,-ld_classic to the linker.) >> --- >> tests/checkasm/aacencdsp.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > this sometimes fails > > make -j32 fate-checkasm-aacencdsp > > TEST checkasm-aacencdsp > make -j32 fate-checkasm-aacencdsp > > TEST checkasm-aacencdsp > Test checkasm-aacencdsp failed. Look at tests/data/fate/checkasm-aacencds= p.err for details. > make: *** [tests/Makefile:311: fate-checkasm-aacencdsp] Error 1 > > checkasm: using random seed 3314560428 > SSE: > - aacencdsp.abs_pow34 [OK] > SSE2: > quant_bands_signed_sse2 (aacencdsp.c:94) > - aacencdsp.quant_bands [FAILED] > AVX: > - aacencdsp.quant_bands [OK] > checkasm: 1 of 5 tests have failed > threads=3D1 > make: *** [tests/Makefile:311: fate-checkasm-aacencdsp] Error 1 Indeed, it turns out that the existing x86 assembly is kinda buggy; I sent = a new patchset now, which runs correctly in checkasm with at least a = couple thousand different seeds, tested on x86, aarch64 and riscv (with = qemu). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".