Re: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure - Rémi Denis-Courmont

From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure
Date: Sat, 25 May 2024 15:36:07 +0300
Message-ID: <2193692.Icojqenx9y@basile.remlab.net> (raw)
In-Reply-To: <20240525121951.GE2821752@pb2>

Le lauantaina 25. toukokuuta 2024, 15.19.51 EEST Michael Niedermayer a écrit :
> On Sat, May 25, 2024 at 02:38:07PM +0300, Rémi Denis-Courmont wrote:
> > Le lauantaina 25. toukokuuta 2024, 14.18.12 EEST Michael Niedermayer a 
écrit :
> > > Fixes: CID1559855 Unchecked return value from library
> > 
> > This is again very misleading. Logging an error (that most people won't
> > even see) is not fixing a bug. Either this is not a bug, and this patch
> > can't be fixing a non-bug, or this is a bug, and this patch is hiding it
> > behind a fake fix.
> 
> As written in the commit message, the patch would fix CID1559855.
> It doesnt claim anything else

That does not match my understanding of the verb "to fix". And this is not just 
a rant about semantics. People may well be mislead and assume that any commit 
that "fixes" something fixes an FFmpeg bug.

> > So IMO, 5c3d2177e7be7dde69a83b1b394f57976c164c84 should be reverted
> > instead.
> if thats preferred, i have nothing against doing that instead
> 
> thx
> 
> [...]

-- 
レミ・デニ-クールモン
http://www.remlab.net/

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".