* [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr
@ 2023-12-11 20:41 Rémi Denis-Courmont
2023-12-11 20:49 ` Rémi Denis-Courmont
0 siblings, 1 reply; 5+ messages in thread
From: Rémi Denis-Courmont @ 2023-12-11 20:41 UTC (permalink / raw)
To: ffmpeg-devel
---
tests/checkasm/lpc.c | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
index 592e34c03d..8e92a9e1b4 100644
--- a/tests/checkasm/lpc.c
+++ b/tests/checkasm/lpc.c
@@ -57,10 +57,40 @@ static void test_window(int len)
bench_new(src, len, dst1);
}
+static void test_compute_autocorr(int lag)
+{
+ LOCAL_ALIGNED(16, double, src, [5000]);
+ LOCAL_ALIGNED(16, double, dst0, [32]);
+ LOCAL_ALIGNED(16, double, dst1, [32]);
+ const size_t len = 5000;
+
+ declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
+
+ for (size_t i = 0; i < len; i++) {
+ src[i] = (double)rnd() / (double)UINT_MAX;
+ }
+
+ call_ref(src, len, lag, dst0);
+ call_new(src, len, lag, dst1);
+
+ for (size_t i = 0; i < lag; i++) {
+ if (!double_near_abs_eps(dst0[i], dst1[i], EPS)) {
+ fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
+ i, dst0[i], dst1[i], dst0[i] - dst1[i]);
+ fail();
+ break;
+ }
+ }
+
+ bench_new(src, len, lag, dst1);
+}
+
void checkasm_check_lpc(void)
{
LPCContext ctx;
int len = rnd() % 5000;
+ static const int lags[] = { 10, 30, 32 };
+
ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
@@ -73,5 +103,11 @@ void checkasm_check_lpc(void)
}
report("apply_welch_window_odd");
+ for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
+ if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i]))
+ test_compute_autocorr(lags[i]);
+ report("compute_autocorr_%d", lags[i]);
+ }
+
ff_lpc_end(&ctx);
}
--
2.43.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr
2023-12-11 20:41 [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr Rémi Denis-Courmont
@ 2023-12-11 20:49 ` Rémi Denis-Courmont
0 siblings, 0 replies; 5+ messages in thread
From: Rémi Denis-Courmont @ 2023-12-11 20:49 UTC (permalink / raw)
To: ffmpeg-devel
Le maanantaina 11. joulukuuta 2023, 22.41.03 EET Rémi Denis-Courmont a écrit :
> ---
> tests/checkasm/lpc.c | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
> index 592e34c03d..8e92a9e1b4 100644
> --- a/tests/checkasm/lpc.c
> +++ b/tests/checkasm/lpc.c
> @@ -57,10 +57,40 @@ static void test_window(int len)
> bench_new(src, len, dst1);
> }
>
> +static void test_compute_autocorr(int lag)
> +{
> + LOCAL_ALIGNED(16, double, src, [5000]);
> + LOCAL_ALIGNED(16, double, dst0, [32]);
> + LOCAL_ALIGNED(16, double, dst1, [32]);
> + const size_t len = 5000;
> +
> + declare_func(void, const double *in, ptrdiff_t len, int lag, double
> *out); +
> + for (size_t i = 0; i < len; i++) {
> + src[i] = (double)rnd() / (double)UINT_MAX;
Not sure if we should test negative numbers here.
> + }
> +
> + call_ref(src, len, lag, dst0);
> + call_new(src, len, lag, dst1);
Presumably src needs to be offset by one element, as the first iteration of the
loop reads at offset minus one (in C code: sum1 += ...).
> +
> + for (size_t i = 0; i < lag; i++) {
> + if (!double_near_abs_eps(dst0[i], dst1[i], EPS)) {
> + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
> + i, dst0[i], dst1[i], dst0[i] - dst1[i]);
> + fail();
> + break;
> + }
> + }
> +
> + bench_new(src, len, lag, dst1);
> +}
> +
> void checkasm_check_lpc(void)
> {
> LPCContext ctx;
> int len = rnd() % 5000;
> + static const int lags[] = { 10, 30, 32 };
> +
> ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
>
> if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even"))
> { @@ -73,5 +103,11 @@ void checkasm_check_lpc(void)
> }
> report("apply_welch_window_odd");
>
> + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
> + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i]))
> + test_compute_autocorr(lags[i]);
> + report("compute_autocorr_%d", lags[i]);
> + }
> +
> ff_lpc_end(&ctx);
> }
--
雷米‧德尼-库尔蒙
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr
2024-05-25 11:58 Rémi Denis-Courmont
2024-05-25 13:33 ` James Almer
@ 2024-05-26 20:09 ` Rémi Denis-Courmont
1 sibling, 0 replies; 5+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-26 20:09 UTC (permalink / raw)
To: ffmpeg-devel
Le lauantaina 25. toukokuuta 2024, 14.58.53 EEST Rémi Denis-Courmont a écrit :
> --
> Change since previous version:
> - Disable test on x86, since the x86 optimisation fails
> with a suspiciously large and regular error with 10-20% probability.
> ---
> tests/checkasm/lpc.c | 54 ++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 52 insertions(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
> index 592e34c03d..38810325ac 100644
> --- a/tests/checkasm/lpc.c
> +++ b/tests/checkasm/lpc.c
> @@ -16,6 +16,7 @@
> * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> */
>
> +#include "libavutil/avassert.h"
> #include "libavutil/mem_internal.h"
>
> #include "libavcodec/lpc.h"
> @@ -57,10 +58,50 @@ static void test_window(int len)
> bench_new(src, len, dst1);
> }
>
> +#if !ARCH_X86
> +static void test_compute_autocorr(ptrdiff_t len, int lag)
> +{
> + LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
> + LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
> + LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
> +
> + declare_func(void, const double *in, ptrdiff_t len, int lag, double
> *out); +
> + av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
> +
> + for (int i = 0; i < MAX_LPC_ORDER; i++)
> + src[i] = 0.;
> +
> + src += MAX_LPC_ORDER;
> +
> + for (ptrdiff_t i = 0; i < len; i++) {
> + src[i] = (double)rnd() / (double)UINT_MAX;
> + }
> +
> + call_ref(src, len, lag, dst0);
> + call_new(src, len, lag, dst1);
> +
> + for (size_t i = 0; i < lag; i++) {
Should also check dst[lag] AFAIU.
> + if (!double_near_abs_eps(dst0[i], dst1[i], EPS)) {
> + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
> + i, dst0[i], dst1[i], dst0[i] - dst1[i]);
> + fail();
> + break;
> + }
> + }
> +
> + bench_new(src, len, lag, dst1);
> +}
> +#endif
> +
> void checkasm_check_lpc(void)
> {
> LPCContext ctx;
> - int len = rnd() % 5000;
> + int len = 2000 + (rnd() % 3000);
> +#if !ARCH_X86
> + static const int lags[] = { 10, 30, 32 };
> +#endif
> +
> ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
>
> if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even"))
> { @@ -72,6 +113,15 @@ void checkasm_check_lpc(void)
> test_window(len | 1);
> }
> report("apply_welch_window_odd");
> -
> ff_lpc_end(&ctx);
> +
> +#if !ARCH_X86
> + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
> + ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
> + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i]))
> + test_compute_autocorr(len, lags[i]);
> + report("compute_autocorr_%d", lags[i]);
> + ff_lpc_end(&ctx);
> + }
> +#endif
> }
--
レミ・デニ-クールモン
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr
2024-05-25 11:58 Rémi Denis-Courmont
@ 2024-05-25 13:33 ` James Almer
2024-05-26 20:09 ` Rémi Denis-Courmont
1 sibling, 0 replies; 5+ messages in thread
From: James Almer @ 2024-05-25 13:33 UTC (permalink / raw)
To: ffmpeg-devel
On 5/25/2024 8:58 AM, Rémi Denis-Courmont wrote:
> --
> Change since previous version:
> - Disable test on x86, since the x86 optimisation fails
> with a suspiciously large and regular error with 10-20% probability.
Weird. The sse2 function is written using inline gcc, so it's pretty
old. And it seems to do adds and muls using the exact same instructions
compiler generated output would use on x86_64.
> ---
> tests/checkasm/lpc.c | 54 ++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 52 insertions(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
> index 592e34c03d..38810325ac 100644
> --- a/tests/checkasm/lpc.c
> +++ b/tests/checkasm/lpc.c
> @@ -16,6 +16,7 @@
> * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> */
>
> +#include "libavutil/avassert.h"
> #include "libavutil/mem_internal.h"
>
> #include "libavcodec/lpc.h"
> @@ -57,10 +58,50 @@ static void test_window(int len)
> bench_new(src, len, dst1);
> }
>
> +#if !ARCH_X86
> +static void test_compute_autocorr(ptrdiff_t len, int lag)
> +{
> + LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
> + LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
> + LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
> +
> + declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
> +
> + av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
> +
> + for (int i = 0; i < MAX_LPC_ORDER; i++)
> + src[i] = 0.;
> +
> + src += MAX_LPC_ORDER;
> +
> + for (ptrdiff_t i = 0; i < len; i++) {
> + src[i] = (double)rnd() / (double)UINT_MAX;
> + }
> +
> + call_ref(src, len, lag, dst0);
> + call_new(src, len, lag, dst1);
> +
> + for (size_t i = 0; i < lag; i++) {
> + if (!double_near_abs_eps(dst0[i], dst1[i], EPS)) {
> + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
> + i, dst0[i], dst1[i], dst0[i] - dst1[i]);
> + fail();
> + break;
> + }
> + }
> +
> + bench_new(src, len, lag, dst1);
> +}
> +#endif
> +
> void checkasm_check_lpc(void)
> {
> LPCContext ctx;
> - int len = rnd() % 5000;
> + int len = 2000 + (rnd() % 3000);
> +#if !ARCH_X86
> + static const int lags[] = { 10, 30, 32 };
> +#endif
> +
> ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
>
> if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
> @@ -72,6 +113,15 @@ void checkasm_check_lpc(void)
> test_window(len | 1);
> }
> report("apply_welch_window_odd");
> -
> ff_lpc_end(&ctx);
> +
> +#if !ARCH_X86
> + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
> + ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
> + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i]))
> + test_compute_autocorr(len, lags[i]);
> + report("compute_autocorr_%d", lags[i]);
report("compute_autocorr");
And outside the loop. check_func() will print each specific run lags
value when you requests benching.
> + ff_lpc_end(&ctx);
> + }
> +#endif
> }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr
@ 2024-05-25 11:58 Rémi Denis-Courmont
2024-05-25 13:33 ` James Almer
2024-05-26 20:09 ` Rémi Denis-Courmont
0 siblings, 2 replies; 5+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-25 11:58 UTC (permalink / raw)
To: ffmpeg-devel
--
Change since previous version:
- Disable test on x86, since the x86 optimisation fails
with a suspiciously large and regular error with 10-20% probability.
---
tests/checkasm/lpc.c | 54 ++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
index 592e34c03d..38810325ac 100644
--- a/tests/checkasm/lpc.c
+++ b/tests/checkasm/lpc.c
@@ -16,6 +16,7 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
+#include "libavutil/avassert.h"
#include "libavutil/mem_internal.h"
#include "libavcodec/lpc.h"
@@ -57,10 +58,50 @@ static void test_window(int len)
bench_new(src, len, dst1);
}
+#if !ARCH_X86
+static void test_compute_autocorr(ptrdiff_t len, int lag)
+{
+ LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
+ LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
+ LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
+
+ declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
+
+ av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
+
+ for (int i = 0; i < MAX_LPC_ORDER; i++)
+ src[i] = 0.;
+
+ src += MAX_LPC_ORDER;
+
+ for (ptrdiff_t i = 0; i < len; i++) {
+ src[i] = (double)rnd() / (double)UINT_MAX;
+ }
+
+ call_ref(src, len, lag, dst0);
+ call_new(src, len, lag, dst1);
+
+ for (size_t i = 0; i < lag; i++) {
+ if (!double_near_abs_eps(dst0[i], dst1[i], EPS)) {
+ fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
+ i, dst0[i], dst1[i], dst0[i] - dst1[i]);
+ fail();
+ break;
+ }
+ }
+
+ bench_new(src, len, lag, dst1);
+}
+#endif
+
void checkasm_check_lpc(void)
{
LPCContext ctx;
- int len = rnd() % 5000;
+ int len = 2000 + (rnd() % 3000);
+#if !ARCH_X86
+ static const int lags[] = { 10, 30, 32 };
+#endif
+
ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
@@ -72,6 +113,15 @@ void checkasm_check_lpc(void)
test_window(len | 1);
}
report("apply_welch_window_odd");
-
ff_lpc_end(&ctx);
+
+#if !ARCH_X86
+ for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
+ ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
+ if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i]))
+ test_compute_autocorr(len, lags[i]);
+ report("compute_autocorr_%d", lags[i]);
+ ff_lpc_end(&ctx);
+ }
+#endif
}
--
2.45.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-26 20:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 20:41 [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr Rémi Denis-Courmont
2023-12-11 20:49 ` Rémi Denis-Courmont
2024-05-25 11:58 Rémi Denis-Courmont
2024-05-25 13:33 ` James Almer
2024-05-26 20:09 ` Rémi Denis-Courmont
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git