Re: [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr

["Rémi Denis-Courmont" <remi@remlab.net>]

Le maanantaina 11. joulukuuta 2023, 22.41.03 EET Rémi Denis-Courmont a écrit :
> ---
>  tests/checkasm/lpc.c | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
> index 592e34c03d..8e92a9e1b4 100644
> --- a/tests/checkasm/lpc.c
> +++ b/tests/checkasm/lpc.c
> @@ -57,10 +57,40 @@ static void test_window(int len)
>      bench_new(src, len, dst1);
>  }
> 
> +static void test_compute_autocorr(int lag)
> +{
> +    LOCAL_ALIGNED(16, double, src, [5000]);
> +    LOCAL_ALIGNED(16, double, dst0, [32]);
> +    LOCAL_ALIGNED(16, double, dst1, [32]);
> +    const size_t len = 5000;
> +
> +    declare_func(void, const double *in, ptrdiff_t len, int lag, double
> *out); +
> +    for (size_t i = 0; i < len; i++) {
> +        src[i] = (double)rnd() / (double)UINT_MAX;

Not sure if we should test negative numbers here.

> +    }
> +
> +    call_ref(src, len, lag, dst0);
> +    call_new(src, len, lag, dst1);

Presumably src needs to be offset by one element, as the first iteration of the 
loop reads at offset minus one (in C code: sum1 += ...).

> +
> +    for (size_t i = 0; i < lag; i++) {
> +        if (!double_near_abs_eps(dst0[i], dst1[i], EPS)) {
> +            fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
> +                    i, dst0[i], dst1[i], dst0[i] - dst1[i]);
> +            fail();
> +            break;
> +        }
> +    }
> +
> +    bench_new(src, len, lag, dst1);
> +}
> +
>  void checkasm_check_lpc(void)
>  {
>      LPCContext ctx;
>      int len = rnd() % 5000;
> +    static const int lags[] = { 10, 30, 32 };
> +
>      ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
> 
>      if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even"))
> { @@ -73,5 +103,11 @@ void checkasm_check_lpc(void)
>      }
>      report("apply_welch_window_odd");
> 
> +    for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
> +        if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i]))
> +            test_compute_autocorr(lags[i]);
> +        report("compute_autocorr_%d", lags[i]);
> +    }
> +
>      ff_lpc_end(&ctx);
>  }


-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".