From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3BE2A433B6 for ; Thu, 9 Jun 2022 19:09:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5157968B791; Thu, 9 Jun 2022 22:09:11 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4051368B1A5 for ; Thu, 9 Jun 2022 22:09:05 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 5F824E7379 for ; Thu, 9 Jun 2022 21:09:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tBpnkNW0QpV9 for ; Thu, 9 Jun 2022 21:09:02 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 1E402E736D for ; Thu, 9 Jun 2022 21:09:02 +0200 (CEST) Date: Thu, 9 Jun 2022 21:09:02 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20220403140643.GB264464@mariano> Message-ID: <2166a0-e72d-71e5-8265-fa3cadbadc42@passwd.hu> References: <20210418213058.24475-1-stefasab@gmail.com> <20210418213058.24475-2-stefasab@gmail.com> <20210419092649.GJ4777@pb2> <20210421215704.GD12140@mariano> <20220403140643.GB264464@mariano> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] ffprobe: add -o option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 3 Apr 2022, Stefano Sabatini wrote: > On date Wednesday 2021-04-21 23:57:04 +0200, Stefano Sabatini wrote: >> On date Monday 2021-04-19 11:26:49 +0200, Michael Niedermayer wrote: >>> On Sun, Apr 18, 2021 at 11:30:58PM +0200, Stefano Sabatini wrote: >>>> This enables printing to a resource specified with -o OUTPUT. >>>> >>>> Address issue: http://trac.ffmpeg.org/ticket/8024 >>>> --- >>>> doc/ffprobe.texi | 7 ++ >>>> fftools/ffprobe.c | 174 ++++++++++++++++++++++++++++++---------------- >>>> 2 files changed, 120 insertions(+), 61 deletions(-) >>> >>> This seems breaking some fate tests like fate-gaplessenc-itunes-to-ipod-aac >>> >>> I see 0 bytes in the output: >>> 73 3D 4B 44 00 73 69 64 65 5F 64 61 74 61 7C 0A 0A >>> >>> thx >> >> That's right, I'm still forgetting to run make fate :-) >> (avio_put_str() was adding the 0), should be fixed now. >> >> Thanks. > > Updated again, now it's locally passing fate with FATE samples (don't > remember if other issues were spotted the past time). This looks good to me in general, so I intend to apply. One thing that we might do is to keep writing to the standard output if no output file is specified instead of using the special "pipe:" URL. This way ffprobe keeps working even if the pipe protocol is not compiled into ffmpeg/libavformat. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".