From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E676246E29 for ; Sat, 15 Jul 2023 01:34:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8A20468C5BE; Sat, 15 Jul 2023 04:34:17 +0300 (EEST) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D920368C51E for ; Sat, 15 Jul 2023 04:34:10 +0300 (EEST) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1b449890ef5so2084523fac.1 for ; Fri, 14 Jul 2023 18:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689384849; x=1691976849; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1QNUJ+UZz2JqYDkNJtPlZ7BDOkhItDkG8K/YSlrMj1U=; b=bHLI+XmmjdEf5SMiRqPuKClPvAQ2GM9i1cOJJzgq6jKqA/lyKXBm++46w6Z25crAw0 9IPshVKdBBYaPBHh0bXUnRSVFaaA3eAW2h31OC7pur2oaZVDQbE1dyai4anSAU+Pllfz ed5BUdgnlfg0VgN/mgxenRs6KB+tBZynthXFA6pCzJXer1MHu5K1Flq5deTdmXBOr8se 1POpTvKFH0LT9XZhVJyS5EPsH/U9EU4TmXZhXGCMrYyXpxTDkDEOVKh2SfID54oyPqSy iwYWC901OBXgAcWgD7J2VpeM5ydJvFoavJdOmvMPeq1ek6zvEKTor/+8J4HyPmKZJXpE y4Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689384849; x=1691976849; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1QNUJ+UZz2JqYDkNJtPlZ7BDOkhItDkG8K/YSlrMj1U=; b=jbB2qynlzJOFbFpq59ZhXR4eE8HLunK45pqQHyNu408MILSOs3nfzcwBzspQLJwyUg vR+WpZnSB9vGXsf2DBgESftdRSDI5W92kAP2btTEv6ziSBNBkW1aVEBctl3eKjGM2pnw avMC+m5QfvGEbujBoxDLQPA8AnoZQZPuZBAy2u885RfRnex9pkPC+a+/g7CYqbj6JfqV yqVFOiS+VD+FOEdXXSMyesqrrbhk5FqPID/4KkuzlyAR2W7Mtxwr088zOg59dDeYcKiN I15vTYEpWQCGfikyVEklrb0VWDbVNTaSD7IBela9QVcPz4lCTMP7XSxY1CPAi8OAH/Nq TRRg== X-Gm-Message-State: ABy/qLbFbjkm7prK0g7k4mGX8hL8Y5wlyf6kYkMVParPpUu/miuGoyJf reb4ES6RGovoyyHaJ7eTwHf450NsE2I= X-Google-Smtp-Source: APBJJlGsXpCsYiiLGbe23bVgzoQSQ01V+uUgoEvjni7ujm8u3znarQSoD0SrJWHe7UOH8xwA0muNog== X-Received: by 2002:a05:6871:8a6:b0:1a5:4e57:e5d1 with SMTP id r38-20020a05687108a600b001a54e57e5d1mr8568826oaq.49.1689384848631; Fri, 14 Jul 2023 18:34:08 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id m15-20020a9d6acf000000b006b8b55297b5sm4492742otq.42.2023.07.14.18.34.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jul 2023 18:34:08 -0700 (PDT) Message-ID: <2165371b-e9f5-0f7a-b06d-bd2fdfdbe5ac@gmail.com> Date: Fri, 14 Jul 2023 22:34:11 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230711141039.20303-1-pkoshevoy@gmail.com> From: James Almer In-Reply-To: <20230711141039.20303-1-pkoshevoy@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] lavc/audiotoolbox: fix build failure on osx 10.5 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/11/2023 11:10 AM, Pavel Koshevoy wrote: > --- > libavcodec/audiotoolboxdec.c | 2 ++ > libavcodec/audiotoolboxenc.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c > index 82babe3d31..7b33cdf87d 100644 > --- a/libavcodec/audiotoolboxdec.c > +++ b/libavcodec/audiotoolboxdec.c > @@ -71,10 +71,12 @@ static UInt32 ffat_get_format_id(enum AVCodecID codec, int profile) > return kAudioFormatAMR; > case AV_CODEC_ID_EAC3: > return kAudioFormatEnhancedAC3; > +#if __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ > 1058 Wouldn't it be better to do >= with the actual version where all this is first available? > case AV_CODEC_ID_GSM_MS: > return kAudioFormatMicrosoftGSM; > case AV_CODEC_ID_ILBC: > return kAudioFormatiLBC; > +#endif > case AV_CODEC_ID_MP1: > return kAudioFormatMPEGLayer1; > case AV_CODEC_ID_MP2: > diff --git a/libavcodec/audiotoolboxenc.c b/libavcodec/audiotoolboxenc.c > index 1ccfda4d20..f652836018 100644 > --- a/libavcodec/audiotoolboxenc.c > +++ b/libavcodec/audiotoolboxenc.c > @@ -69,15 +69,19 @@ static UInt32 ffat_get_format_id(enum AVCodecID codec, int profile) > return kAudioFormatMPEG4AAC_HE_V2; > case FF_PROFILE_AAC_LD: > return kAudioFormatMPEG4AAC_LD; > +#if __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ > 1058 > case FF_PROFILE_AAC_ELD: > return kAudioFormatMPEG4AAC_ELD; > +#endif > } > case AV_CODEC_ID_ADPCM_IMA_QT: > return kAudioFormatAppleIMA4; > case AV_CODEC_ID_ALAC: > return kAudioFormatAppleLossless; > +#if __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ > 1058 > case AV_CODEC_ID_ILBC: > return kAudioFormatiLBC; > +#endif > case AV_CODEC_ID_PCM_ALAW: > return kAudioFormatALaw; > case AV_CODEC_ID_PCM_MULAW: _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".