From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A8C1842B6B for ; Wed, 12 Jan 2022 03:08:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D197168A744; Wed, 12 Jan 2022 05:08:54 +0200 (EET) Received: from m1396.mail.163.com (m1396.mail.163.com [220.181.13.96]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D51F36881C8 for ; Wed, 12 Jan 2022 05:08:47 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=sxUei jiV5H5xVkbuNyHE/5bStjMpGMjjJzTboGZgLNM=; b=hTU3cYuoEyeHLmeZr2FLH bevZ4qgbWPvUHwGy4JsxpXjkZqEnrQS4A0p49SrpzuONYaX2LebnZtRGeajRNTug oG+QvTSZxYK9C6X1mVuqtOZZ3LrzSBBdvnGYn/N7TH9G7yoGE60wRCPzBDYsYSHj r9icKKFJewuDt1FsQhW1Lc= Received: from yshaw1999$163.com ( [103.107.216.227] ) by ajax-webmail-wmsvr96 (Coremail) ; Wed, 12 Jan 2022 11:08:45 +0800 (CST) X-Originating-IP: [103.107.216.227] Date: Wed, 12 Jan 2022 11:08:45 +0800 (CST) From: XiaoYang To: "FFmpeg development discussions and patches" X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20210622(1d4788a8) Copyright (c) 2002-2022 www.mailtech.cn 163com In-Reply-To: References: <20220111063856.15699-1-yshaw1999@163.com> MIME-Version: 1.0 Message-ID: <2161acd8.23b1.17e4c425f9d.Coremail.yshaw1999@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: YMGowAD3ZlI9Rt5hd3wVAA--.10192W X-CM-SenderInfo: 51vkt4irzzmqqrwthudrp/xtbBlwSG7FSImAvYhgACsq X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avformat/asfdec: fix crash caused by free wlid pointers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: At 2022-01-11 17:29:35, "Andreas Rheinhardt" wrote: >Yang Xiao: >> From: Yang Xiao >> >> This commit fixed a crash when seeking wma frames, asf decoder will try to demux in function asf_read_pts(). >> Pointer member side_data of AVPacket that allocated by stack may be wild pointer. >> Prevent releasing wild pointers in AVPacket when some functions try to call av_packet_unref, example av_read_frame(). >> --- >> libavformat/asfdec_f.c | 2 +- >> libavformat/mpc.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c >> index a8f36ed286..bae0ecfc7c 100644 >> --- a/libavformat/asfdec_f.c >> +++ b/libavformat/asfdec_f.c >> @@ -1433,7 +1433,7 @@ static int64_t asf_read_pts(AVFormatContext *s, int stream_index, >> { >> FFFormatContext *const si = ffformatcontext(s); >> ASFContext *asf = s->priv_data; >> - AVPacket pkt1, *pkt = &pkt1; >> + AVPacket pkt1 = {0}, *pkt = &pkt1; >> ASFStream *asf_st; >> int64_t pts; >> int64_t pos = *ppos; >> diff --git a/libavformat/mpc.c b/libavformat/mpc.c >> index b5b2bab33c..ad0d693152 100644 >> --- a/libavformat/mpc.c >> +++ b/libavformat/mpc.c >> @@ -189,7 +189,7 @@ static int mpc_read_seek(AVFormatContext *s, int stream_index, int64_t timestamp >> AVStream *st = s->streams[stream_index]; >> FFStream *const sti = ffstream(st); >> MPCContext *c = s->priv_data; >> - AVPacket pkt1, *pkt = &pkt1; >> + AVPacket pkt1 = {0}, *pkt = &pkt1; >> int ret; >> int index = av_index_search_timestamp(st, FFMAX(timestamp - DELAY_FRAMES, 0), flags); >> uint32_t lastframe; >> > >Do you have FF_API_INIT_PACKET set to 0 (it should still be set to 1)? >Because av_read_frame() is supposed to (and documented to) treat the >packet it is given as uninitialized. > >- Andreas Thanks for your comment! But I have a question, av_init_packet() has been markedattribute_deprecated, If av_init_packet() is deprecated completely in the future, how to ensure ff_read_packet() safely (support to input a uninitialized packet) ? AVPacket->side_data will not be safely initialized with only av_packet_unref(). And as a user of the FFmpeg API, I want to disable some of the functions marked attribute_deprecated early, because upgrading FFmpeg has a large impact. Do I have other ways to achieve this goal? >_______________________________________________ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".