From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number to int64_t
Date: Sat, 28 Jan 2023 19:14:27 +0100 (CET)
Message-ID: <20d9c635-2a4c-636a-f47c-c36f12482f93@passwd.hu> (raw)
In-Reply-To: <bbafa554-495-2462-77f8-d9b45cf35b8a@passwd.hu>
On Fri, 27 Jan 2023, Marton Balint wrote:
>
>
> On Fri, 27 Jan 2023, James Almer wrote:
>
>> On 1/27/2023 3:04 PM, Anton Khirnov wrote:
>>> Quoting Marton Balint (2023-01-27 18:59:39)
>>>>
>>>>
>>>> On Fri, 27 Jan 2023, Anton Khirnov wrote:
>>>>
>>>>> I still think we should do a deprecation+replacement like we do for
>>>>> everything else.
>>>>
>>>> You mean you want to introduce a new 64 bit member and deprecate the
>>>> old
>>>> 32 bit field?
>>>>
>>>> E.g.
>>>>
>>>> int64_t frame_num;
>>>>
>>>> attribute_deprcated
>>>> int frame_number
>>>>
>>>> And during the transition you want to sync the value between the 64bit
>>>> and
>>>> the 32bit ?
>>>
>>> yes
>>
>> We did make changes like int -> size_t without adding new fields in places
>> like AVBufferRef. See 14040a1d91.
>
> Or AVFormatContext bit_rate sometime before.
>
>> It does however probably need an FF_API_ dance, much like in that example.
>
> If no new field is added, and no old field is deprecated, then if the type
> change is done directly before the bump, then the dance is not needed,
> beacuse you'd just remove the dance at the bump.
Anyhow, I will send and alternate patch series which is introducing a new
field for the 64-bit variant. That series is not dependant of the API
bump, can be applied before or after.
If people prefer that, fine with me.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-01-28 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 22:46 Marton Balint
2023-01-26 22:46 ` [FFmpeg-devel] [BUMP PATCH 2/2] avutil/frame: change AVFrame.*_picture_number " Marton Balint
2023-01-27 10:07 ` [FFmpeg-devel] [BUMP PATCH 1/2] avcodec: change AVCodecContext.frame_number " Anton Khirnov
2023-01-27 17:59 ` Marton Balint
2023-01-27 18:04 ` Anton Khirnov
2023-01-27 18:16 ` James Almer
2023-01-27 18:41 ` Marton Balint
2023-01-28 18:14 ` Marton Balint [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20d9c635-2a4c-636a-f47c-c36f12482f93@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git