From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0C6B0483CD for ; Mon, 1 Jan 2024 17:26:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ADAF468CF61; Mon, 1 Jan 2024 19:26:23 +0200 (EET) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 16F1A68CDF6 for ; Mon, 1 Jan 2024 19:26:18 +0200 (EET) Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ccae380df2so71698971fa.1 for ; Mon, 01 Jan 2024 09:26:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704129977; x=1704734777; darn=ffmpeg.org; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=73ytzu5phPON8FWSQ0sWKTjjdipDf4SMY4cXETxbxOs=; b=LYOcOT5QcXVnYkbs9I5TUoDdIdUbae9IRo63x3Uid+iO5+gw/NFrdvUsQ06aXH76qW GzPtZjHAvs0VIMiSSbtWYqWc5RTxjm3pnDj2fAzxF41AQCuep53dvgqQZ3FIAzBFj2Be anvGlMIzBp6Y5AKugVd0yeZgX5Ic5+r2+OarHJWigrYo6GEmatKGq00CB19D1mvhKPvL 4NtvhnW5aY7gTv99TaXHmRIjMo8ELgFU7PhwgcnDC/h+MV42UgTdHRFmE9sgedpOcuaD XDB9HbyEHE71cT2DRZBX43luFfhbiPQYzSRZnITeRTEkoT2Mkc9aZxOK4Y1CTAOUykbN r1UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704129977; x=1704734777; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=73ytzu5phPON8FWSQ0sWKTjjdipDf4SMY4cXETxbxOs=; b=cXuQVXvx8j9P3QC3P3rsnFWiPVaZ1VrrxkHLqEoT1COchXsupg+3pUUHtwNp3+P9e4 ldfPd60Hpm54dZfMtC78f7gRPy7tklGOqIYEoTxU9NgebKLbcZ7+TR5i4J8GiaZ0m+nl qYCLmRb539y5o2ZHGv8Zf7NhGxfYJVaALaJgsfYALhxkIUyU6oijLTsWYcQec0pKk10Y EQnYsprZTTVo8tUOeEfX1Anf/6YIkfo3RehCV+105sCZNqAXPkP44BjgSM4mmm7+GZ1m jjRJYEHLU8hPvp41BJnCzJGEVw+CS4Igwh5cWbGgWwFdIEYnrR6eEjhmTZ5r9YDgHJfr oONA== X-Gm-Message-State: AOJu0YzlCkWxBdokCCtjbhqDn/Ht9H5LNdCC4uPQbcmiWggAWeSMg8La t6EYQTdOZbP0LSyz8Ux/H10MDscZLDlFng== X-Google-Smtp-Source: AGHT+IH8Fs0+CeYtRbLky1Rty4p7hCB319XM6HA8811qSbXtXukeOP3cnfF2GlQwt69Eaz9mIEzFxA== X-Received: by 2002:a05:6512:32b7:b0:50e:39ab:4347 with SMTP id q23-20020a05651232b700b0050e39ab4347mr6081170lfe.132.1704129977029; Mon, 01 Jan 2024 09:26:17 -0800 (PST) Received: from [192.168.1.104] (84-112-104-25.cable.dynamic.surfer.at. [84.112.104.25]) by smtp.gmail.com with ESMTPSA id h12-20020a0564020e0c00b005561a8c2badsm2741253edh.83.2024.01.01.09.26.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jan 2024 09:26:16 -0800 (PST) From: epirat07@gmail.com To: FFmpeg development discussions and patches Date: Mon, 01 Jan 2024 18:26:14 +0100 X-Mailer: MailMate (1.14r5937) Message-ID: <20E628E1-84B6-4EC4-B3D1-B46D29AC34F8@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m Add missing type AVMediaType for macOS < 10.13. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1 Jan 2024, at 15:38, David Bohman wrote: > This is a build failure in the master branch as a result of commit > e37b15e26fbc7bc31a86a4a2c7c798e20d4f4c2c: > > There is no type AVMediaType prior to macOS 10.13. > --- > libavdevice/avfoundation.m | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m > index 6a57163eb7..5fc5cb61c5 100644 > --- a/libavdevice/avfoundation.m > +++ b/libavdevice/avfoundation.m > @@ -761,6 +761,10 @@ static int get_audio_config(AVFormatContext *s) > return 0; > } > > +#if TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED < 101300 > +typedef NSString *AVMediaType; > +#endif AFAICT this is lacking the similar check for iOS > + > static NSArray* getDevicesWithMediaType(AVMediaType mediaType) { > #if ((TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000) > || (TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500)) > NSMutableArray *deviceTypes = nil; > -- > 2.43.0 > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".