From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2EF1E46AD5 for ; Sun, 2 Jul 2023 21:10:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D53B68C4BE; Mon, 3 Jul 2023 00:09:59 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 788E568BEC6 for ; Mon, 3 Jul 2023 00:09:53 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 362L9q3s014473-362L9q3t014473; Mon, 3 Jul 2023 00:09:52 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id D0F99A146B; Mon, 3 Jul 2023 00:09:52 +0300 (EEST) Date: Mon, 3 Jul 2023 00:09:52 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: John Cox In-Reply-To: <20230702123242.232484-1-jc@kynesim.co.uk> Message-ID: <2098e326-8016-ccc-ee90-364c6a5af182@martin.st> References: <20230702123242.232484-1-jc@kynesim.co.uk> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2 00/15] avfilter/vf_bwdif: Add aarch64 neon functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: thomas.mundt@hr.de, ffmpeg-devel@ffmpeg.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 2 Jul 2023, John Cox wrote: > Also adds a filter_line3 method which on aarch64 neon yields approx 30% > speedup over 2xfilter_line and a memcpy > > Differences from v1: > .align 16 corrected to .balign 16 > SXTW tolower > Mac ABI (hopefully) fixed > V register pop/push macroed & prettified > > John Cox (15): > avfilter/vf_bwdif: Add outline for aarch neon functions > avfilter/vf_bwdif: Add common macros and consts for aarch64 neon > avfilter/vf_bwdif: Export C filter_intra > avfilter/vf_bwdif: Add neon for filter_intra > tests/checkasm: Add test for vf_bwdif filter_intra > avfilter/vf_bwdif: Add clip and spatial macros for aarch64 neon > avfilter/vf_bwdif: Export C filter_edge > avfilter/vf_bwdif: Add neon for filter_edge > tests/checkasm: Add test for vf_bwdif filter_edge > avfilter/vf_bwdif: Export C filter_line > avfilter/vf_bwdif: Add neon for filter_line > avfilter/vf_bwdif: Add a filter_line3 method for optimisation > avfilter/vf_bwdif: Add neon for filter_line3 > tests/checkasm: Add test for vf_bwdif filter_line3 > avfilter/vf_bwdif: Block filter slices into a multiple of 4 lines Overall, I'd suggest squashing/reordering the patches like this: - tests/checkasm: Add test for vf_bwdif filter_intra - avfilter/vf_bwdif: Add neon for filter_intra (With the preceding patches squashed. For extra common macros, only add the ones you use in this patch here.) - tests/checkasm: Add test for vf_bwdif filter_edge - avfilter/vf_bwdif: Add neon for filter_edge (with other dependencies squashed) - avfilter/vf_bwdif: Add neon for filter_line - avfilter/vf_bwdif: Add a filter_line3 method for optimisation + checkasm test squashed - avfilter/vf_bwdif: Add neon for filter_line3 // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".