From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id B754D4E109
	for <ffmpegdev@gitmailbox.com>; Fri,  6 Jun 2025 19:44:09 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D68E768C4F0;
	Fri,  6 Jun 2025 22:44:05 +0300 (EEST)
Received: from glom.nmugroup.com (glom.nmugroup.com [193.183.80.6])
 by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9C0D468C4F0
 for <ffmpeg-devel@ffmpeg.org>; Fri,  6 Jun 2025 22:43:59 +0300 (EEST)
Received: from localhost (localhost [127.0.0.1])
 by glom.nmugroup.com (Postfix) with ESMTP id 234D35420B05
 for <ffmpeg-devel@ffmpeg.org>; Fri,  6 Jun 2025 21:43:59 +0200 (CEST)
Received: from [192.168.1.110] (90-228-234-219-no2430.tbcn.telia.com
 [90.228.234.219]) (Authenticated sender: git01)
 by glom.nmugroup.com (Postfix) with ESMTPSA id EA013542AF19
 for <ffmpeg-devel@ffmpeg.org>; Fri,  6 Jun 2025 21:43:58 +0200 (CEST)
Message-ID: <204e8be99e97c2a9d56c5fbd0f51c4540452a436.camel@haerdin.se>
From: Tomas =?ISO-8859-1?Q?H=E4rdin?= <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Date: Fri, 06 Jun 2025 21:43:58 +0200
In-Reply-To: <1210481741.184664378.1748342436436.JavaMail.zimbra@orca.pet>
References: <20250527102811.369474-1-marcos@orca.pet>
 <1210481741.184664378.1748342436436.JavaMail.zimbra@orca.pet>
User-Agent: Evolution 3.56.1-1 
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT
 parsing
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/204e8be99e97c2a9d56c5fbd0f51c4540452a436.camel@haerdin.se/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

tis 2025-05-27 klockan 10:40 +0000 skrev Marcos Del Sol via ffmpeg-
devel:
> A note on this change: I found some .vtt files while using yt-dlp
> that follow
> a draft version of the WebVTT standard (probably
> https://www.w3.org/2013/07/webvtt.html) that use "Region:" for
> regions instead
> of "REGION", and that was causing the conversion to .srt to fail
> completely.

Sounds like the demuxer correctly rejected some broken files

> +        res = webvtt_parse_cue(webvtt, &cue, pos);
> +        if (res < 0) {
> +            if (res != AVERROR_INVALIDDATA)
> +                goto end;
> +            av_log(s, AV_LOG_DEBUG, "Ignoring non-cue block at
> 0x%"PRIx64"\n", pos);
>          }

This kind of change will cause broken files to proliferate, which is
bad for the WebVTT ecosystem, bringing it closer to the mess that is
the SubRip ecosystem

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".