Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing
Date: Fri, 06 Jun 2025 21:43:58 +0200
Message-ID: <204e8be99e97c2a9d56c5fbd0f51c4540452a436.camel@haerdin.se> (raw)
In-Reply-To: <1210481741.184664378.1748342436436.JavaMail.zimbra@orca.pet>

tis 2025-05-27 klockan 10:40 +0000 skrev Marcos Del Sol via ffmpeg-
devel:
> A note on this change: I found some .vtt files while using yt-dlp
> that follow
> a draft version of the WebVTT standard (probably
> https://www.w3.org/2013/07/webvtt.html) that use "Region:" for
> regions instead
> of "REGION", and that was causing the conversion to .srt to fail
> completely.

Sounds like the demuxer correctly rejected some broken files

> +        res = webvtt_parse_cue(webvtt, &cue, pos);
> +        if (res < 0) {
> +            if (res != AVERROR_INVALIDDATA)
> +                goto end;
> +            av_log(s, AV_LOG_DEBUG, "Ignoring non-cue block at
> 0x%"PRIx64"\n", pos);
>          }

This kind of change will cause broken files to proliferate, which is
bad for the WebVTT ecosystem, bringing it closer to the mess that is
the SubRip ecosystem

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".