From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 547AF4F0DF for ; Sun, 15 Jun 2025 16:57:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0717B68C9A2; Sun, 15 Jun 2025 19:56:03 +0300 (EEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 971BE68D57A for ; Sun, 15 Jun 2025 19:56:01 +0300 (EEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-235d6de331fso44321095ad.3 for ; Sun, 15 Jun 2025 09:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750006560; x=1750611360; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=4Wa2S2f09XuxAoFUYJ/3sNOPQ3HWPtz3JADuWQUifJs=; b=dA2AyfvL6oDAewwnR2rw6wtlTbyiC/JKkpFZAGL+HkvAkzZkZtpnQL1/E4c84GfdGy aJQntXT9n0PNjOpqV8Zpj2sNjomYC9xYLHBVE/1Je9L4hvUrSf+19/VJaqFjdSxbSIzt O68wSexpqyqO082O4XfYzLlw3WEEgJ3BXJLKpz6EtGUpq4x/3gHPlWXaG+o7Se/KL4kC y7tpa4RIMamzcRwtJnrSfZazS5HIXp1XAFI5ElbZ3PkTZItA81zeUp0h1u+eWE8El879 8LDQh8iBajTxYE871NA/j1wjwVTRt6MdmlMfyBWPkjO1RCVt5WAnaJ1unz0QXo+vNG8h LCiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750006560; x=1750611360; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4Wa2S2f09XuxAoFUYJ/3sNOPQ3HWPtz3JADuWQUifJs=; b=rvmvxP3mzY3M7vuUjDGSBUqggFpFW5ReHVT4NgzBwDDmcRdoVERpA7k7u4c8aKyi4T PgE3iPLl5TxbNoLr+NTR1yu5ZHW17Z7Kl6XHUBERL/7ufrGIyCdcow3D9nAd2GVcysFv ZjpK15bqT45wnJg7NeZrFNE88DyQIYqWmjGhADQpWDgwt+co50nW5a6fXuOV8UFAooap Z41aQ/1mbeX8t5NehDCgkAVqNXh513tZYs/wLLpqbnZqowRrRMb70bPx79d7oNRtM28P fteoeHd90gz0ZZbB0lilthnKrZu8/ys7NYOdGljhLVvdnVLguj7wM2tppnsTefetHxjV IGlw== X-Gm-Message-State: AOJu0YyWfBTu8UK9tX3xJfTxAGG3W1Rz1d9/GKIBaUpzNcuIEh3sCXKG UWVy3ZK6o+6sCPScs3qhaNSOyXaxK7fPirqL9CIBIyM3cZNOAS3MOR6BdzdUhg== X-Gm-Gg: ASbGncunyVw/tm1EjtCE6mO8/FnWsrcN/Ms1vkeBnl4pD9sKe/jlkYOJ5PDHnQSYxp9 qZUgPTj/TcT97DIbg0q3RloiWX7rbcQJg1NAxnziNJFB0xJeGNhihzBBUuTrL1fRtY/qIIN1QcW XRtIHPkmzWOOli3UPq9tZTKg7T/ZZPZ6aEFp/4OLTj6cRqWJLac5QVa949Qk1vj+2odrPH3rKer 0gwq7utRAv+tIQAKtXxkBjdWtsuNQhdRObEGy/zEyS+SPCn3cVKt8uh2tFxhGao28PbhPICiCct zZwmyrZHXD9I2NWqHlTasfAz22u5m6slxYte3Zl3ofmdzhH4qWjerdr3QWwV3pbCnoVERckax0m 0kqtzLrg+NHyZUO7R X-Google-Smtp-Source: AGHT+IHAo6iHrWm4zDbhlM84RCvDsuiMLDFLMJo9Us6aCo8tUbzZgyY1CjLyG/mdzmqWuDZkJ+BVcw== X-Received: by 2002:a17:903:1cf:b0:234:f4da:7eef with SMTP id d9443c01a7336-2366b1773c0mr102404895ad.52.1750006559782; Sun, 15 Jun 2025 09:55:59 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deb0fb6sm45683525ad.141.2025.06.15.09.55.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Jun 2025 09:55:59 -0700 (PDT) From: Andreas Rheinhardt X-Google-Original-From: Andreas Rheinhardt Message-Id: <203666b3c99306647e003511fca6736d528cd02e.1750006479.git.ffmpegagent@gmail.com> In-Reply-To: References: Date: Sun, 15 Jun 2025 16:54:04 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 13/47] avcodec/svq1enc: Don't free scratchbuf upon error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Andreas Rheinhardt Forgotten in 65015003f5c4b83a8202abfa7420ccf37cde6ce3; after said commit, freeing scratchbuf on error in svq1_encode_frame() could lead to segfaults lateron, because the buffer will not be allocated again. Signed-off-by: Andreas Rheinhardt --- libavcodec/svq1enc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index 3b8738c14f..dae931fb10 100644 --- a/libavcodec/svq1enc.c +++ b/libavcodec/svq1enc.c @@ -681,7 +681,6 @@ static int svq1_encode_frame(AVCodecContext *avctx, AVPacket *pkt, av_freep(&s->motion_val8[j]); av_freep(&s->motion_val16[j]); } - av_freep(&s->scratchbuf); return -1; } } -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".