From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 9489E4DBE8
for <ffmpegdev@gitmailbox.com>; Wed, 23 Apr 2025 21:08:14 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4090668A51F;
Thu, 24 Apr 2025 00:08:09 +0300 (EEST)
Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com
[209.85.221.41])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ECACE687CE1
for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Apr 2025 00:08:02 +0300 (EEST)
Received: by mail-wr1-f41.google.com with SMTP id
ffacd0b85a97d-3912d2c89ecso254227f8f.2
for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 14:08:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1745442482; x=1746047282;
darn=ffmpeg.org;
h=content-transfer-encoding:in-reply-to:from:references:to
:content-language:subject:user-agent:mime-version:date:message-id
:from:to:cc:subject:date:message-id:reply-to;
bh=1rIZvdTdeF6iiAOm9GT8aMNSPWeZasevZfc6i/fWo24=;
b=aAswGeLD1/ikplLAJQxBlQcpYgaoVSiOFejF+diPTDr1Sn2VMq2uzcDs51nOPQuTO8
nl/NzAd0Vc4FrreGRbJk/1a0yuASxfBDuLtlCDTlrN0uaupwxqg8fa6SIKrKQdZw92Ez
FCKkjGZRzaMCTtQmc3p14b7D6XDYP5xW9qa4ii5YvXtZzcQVxUCIljvRbdVBJlNhtq0+
OgNT3fUyQ/iX9dZ/BoJRa0Df8PfDGUk2y+OtY7tKQuGfq2rm7FkvW79Rr/nxCXcCOkrh
o1CqWGCAs00qD9rx6Vvo2aJuvl4o8dxqO7MwX5voWXE3toqYnvDfOIDUKitGO4r+tUFc
Gaxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745442482; x=1746047282;
h=content-transfer-encoding:in-reply-to:from:references:to
:content-language:subject:user-agent:mime-version:date:message-id
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=1rIZvdTdeF6iiAOm9GT8aMNSPWeZasevZfc6i/fWo24=;
b=VmiMMFUm7cadK6lXLgLkSJpnc4akwImDARnd8PqfswOyB9J/7GeVSh/qTbJEmhd/xt
mF8zvES/OrUGw8e6a8Jj1xIJcetae9PTugY+cswvXvKACuai06ygEhVcMXdeDlq4eSO4
bvyym97cQJMOA3VxQ66LmLq5V487T5B/J0BWlrtpLJ1e2ITFLy/JeoBwf2mwh3oIkCXV
Ewz1IcLm9Y62U7FLLW7Ew0rk6xNa8y9efcc5v33iYjk1FNb3QG0zwT2Iq6DDOg1+MrGT
6ts/E6lCeVwWnWEb0uA+7DhETcDzjxoOS+mdrbH1ohoatGaz+iSiUaDluGGHl6AnWSsY
vJQA==
X-Gm-Message-State: AOJu0Yx6mT4i5v7T7HkCHnngNVgMBxdbGuEaYGowk6yZ7ES5Fdq7EQsa
lt+e99R2lDcXmEWLw/rmB74HOewd1VSadLkjshtVi8XkGlZiCAuJPBRU5aUifwBsJ6pBmd0YbjW
c
X-Gm-Gg: ASbGncsXzm/tfIPanijhvhZKQ9Li5RUmPfkJ4uM/ZYZDNuEmn3KSj38AmToIsV7+/fn
ccyr6FY+kIJyV0gG107Rwe66EoqXIBUFQBg+SF1THAZoXQ49+9uNwszsQBz3E9evzLu+RJUO5O4
YM6KrQvuRwWCy9s0em47arVINelZvBUOl61jG/KCTsNR3TxP7QPIlg9DnRiYwHtFvULg8ofVfNx
ycFJgg1U7XIUafeOJcfclikMtglMu39qNHbrDUQHRNj7UPYM8xSet5NcaXRGHIHJC34NHnOBlGD
LdnVD4+lXFvkTJCdz33B1v1HPicuhSzm3zxA1YwkaYYWxhYhMvWrye8HCUqfqUk9yQpxaD1Atjo
QhJQpnw+oTZ2y9Q==
X-Google-Smtp-Source: AGHT+IGtkUsHdpmrSiGADxRcOFak2nVgzehOFzJPdneuoRk7JyeJqsrARrcIgRardJW/2kzyRe6bhA==
X-Received: by 2002:a05:6000:430c:b0:39c:1257:cd3e with SMTP id
ffacd0b85a97d-39efbb0f568mr16144930f8f.56.1745442482156;
Wed, 23 Apr 2025 14:08:02 -0700 (PDT)
Received: from [192.168.0.15]
(cpc92320-cmbg19-2-0-cust719.5-4.cable.virginm.net. [82.13.66.208])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-39efa4a4e9esm20395267f8f.96.2025.04.23.14.08.01
for <ffmpeg-devel@ffmpeg.org>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Wed, 23 Apr 2025 14:08:01 -0700 (PDT)
Message-ID: <2034e60d-6140-4d18-90b0-b2736c3f2f84@jkqxz.net>
Date: Wed, 23 Apr 2025 22:08:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <CGME20250423141306eucas1p229fa078339a2a993c609464e101c9c6d@eucas1p2.samsung.com>
<20250423141303.1858090-1-d.kozinski@samsung.com>
From: Mark Thompson <sw@jkqxz.net>
In-Reply-To: <20250423141303.1858090-1-d.kozinski@samsung.com>
Subject: Re: [FFmpeg-devel] [PATCH v1 5/8] avformat/mov_muxer: Extended MOV
muxer to handle APV video content
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/2034e60d-6140-4d18-90b0-b2736c3f2f84@jkqxz.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On 23/04/2025 15:13, Dawid Kozinski wrote:
> - Changes in mov_write_video_tag function to handle APV elementary stream
> - Provided structure APVDecoderConfigurationRecord that specifies the decoder configuration information for APV video content
>
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> ---
> libavformat/Makefile | 2 +-
> libavformat/apv.c | 827 ++++++++++++++++++++++++++++++++++++++++
> libavformat/apv.h | 94 +++++
> libavformat/isom_tags.c | 2 +
> libavformat/movenc.c | 47 +++
> 5 files changed, 971 insertions(+), 1 deletion(-)
Hi,
Two thoughts here:
First, your AVPackets contain a raw_bitstream_access_unit(). I don't think this is the right approach - the packets should contain the codec data only, not the additional encapsulation. (This is the method I followed.)
For this patch in particular, I think it results in writing the files incorrectly: the specification says "each sample shall contain one and only one access unit of APV coded data", which I interpret to mean one access_unit() syntax structure.
This also results in the size effectively appearing multiple times in the file for no good reason:
00000020 66 72 65 65 00 01 15 db 6d 64 61 74 00 01 15 cf |free....mdat....|
^ mdat size ^ au_size
00000030 61 50 76 31 00 01 15 c7 01 00 01 00 21 21 40 00 |aPv1........!!@.|
^ signature ^ pbu_size ^ pbu_type followed by header
The separate pbu_size makes sense if there is also metadata, but having the mdat box with a size immediately followed by the same size (well, minus twelve for mdat size + mdat + au size) again inside the box does not seem helpful.
Second, I think we need a consistent decision on what the extradata should be doing. The APVDecoderConfigurationRecord makes sense as a thing for it to contain, but it's not clear to me that it needs to exist at all as it has no effect on anything inside ffmpeg (a decoder will always ignore it).
You currently make extradata from one of your demuxers but not other one or the encoder, and nothing requires it when consuming. Why is it useful to have ever?
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".