From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2B8A44F4BE for ; Thu, 26 Feb 2026 13:56:35 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'Rx9n3gAWkIh3iDnVi9tauDl0VqqAVvk1d6ef+4FQkiE=', expected b'nWV5Lv5cj76ru8PT3COqm26979JRKqbvgkUHVXT6CKg=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772114189; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=Jbeqx1365TJU9Ttw9QluU+CNMTud/LqRc/Gktbs9Xdg=; b=FZLZE3NP3rZLq3q5o0x+arYe1ujaJzYlKvMfNLCiN5vMHWjZHIXBAmucczP2OMXewE3+i X3K8xK/PPcGb4F+gqzvTxH48fQPAZ1v58EeRgCx7NI7XYgf8V7Jywm89HjkMad6JQEliEzZ PFD73OvUSAlcalk/Zm3HlwMRJ9Jgr283V5fGWhdRzayBgifI0dP3Ih1Lbxax9hqJruFhiMM 4hGn6wlImF8QO/4zYn3/JdtivO6Qp3vy7lN37VFW6INQhDMr1DkmYGlDs+/sE8wB4di+ztq KYwP80k32UKufnOnh7yiliFwCRf1HvKz83Yz5jMgse8TZAAUfXtvPnA5HAbA== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 59F4C6912FA; Thu, 26 Feb 2026 15:56:29 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1772114178; b=iZFVhVvuNKOUaBnFRHflR5A8f5YqvgxqIr+nHM+mrTA5efrgbWN7C99IHwGhTw8FXBRSG /z31O9JWfKCd/O6SueAFfIIJl+BbEZ4hUMVRTyvnroHXwvzq3VI7fKg4q05S0gtOB+7LdqC Od9CRlDz9ils+xKeehXQiYB2+7bJUtypY41ZIQZQ0HD+yLJTRJ7I+9IpsCbONndBDBqwBfu Ul8/+PQ4leBDRB+XyG3u2g0QDWat6LUy7gz4zcKPUIQrU5JNqmqM3nUJuEtX63E1Epk1/tN 6TYyBGknSSSXxx6+uUmnMzW97EjcSZzlKYd7QCqGzo5ceNIUkha37ROebHNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1772114178; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=Rx9n3gAWkIh3iDnVi9tauDl0VqqAVvk1d6ef+4FQkiE=; b=rJfKKgG3Rf0mtkYNzhUsKxanHkAFjdSUyY62sahreEqSJK9x23i8eX5VDhhKKtPuzRJoG D+9aFMiU9oYcNXqn+B758sFqjG6SswjR5/i1vL+4kmS3LjmMyD8uK5viBWAGEm825Em7cEJ VOHn35lXsr8LLBVWGuVjXvtZul9/Var6z6RCXHxvo+To8UT4wDJVvcwvxUyQWl/k5ZC+nMH nrCd4169DpstBjn88qkAXBlZrvDL5v7GdeV9vSVXMr5Wcs2dHhzyDZdf4s+XeePyXRUpcnt KGtINhGR417Z6xFqPWjRbS3x/qDo8t40JviR+XCPTCQdgbXQNlOqbhYCQdyg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 819E6691221 for ; Thu, 26 Feb 2026 15:56:03 +0200 (EET) Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-389f9895c81so6633751fa.2 for ; Thu, 26 Feb 2026 05:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772114162; x=1772718962; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nWV5Lv5cj76ru8PT3COqm26979JRKqbvgkUHVXT6CKg=; b=dKH/t233QLhDJ1td3lDl3DqZRPr5Ld7cKPXgm/B1hxkcH+ZvUOwdZE753A7Lih44Bw cciVPW7JD/dEIQ1mCp2O+rh4UDYjGIrLluzGVMj/1jKx3C5d173bwapizzq+2RyyvB9M 9dF7rxFZADu/1LNcwWRUa61c2WSSYE6Z4EN4v2//CvSJGXL9HJygPzbNbP83AbNFrD/C ApmgM5vK/3cNSGmuUBsLzdWb4Lu+twyJAYFMk22pH6czr3IUKG4d/hSS1XFZBYBSxJaM 9Xx+m4Ts04QSHVZGcxcdQ3uNydAmeE2xMyEqXhlKvi/t4t1yLay+nfcyzOr4Sb3MIG+M 2PeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772114162; x=1772718962; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nWV5Lv5cj76ru8PT3COqm26979JRKqbvgkUHVXT6CKg=; b=XNPSKCx5xGgAX42j0hIPWNNfL79vemHptvWDVWUM98a6hiVo4UjV/ASN4IkR3xvfkN 7s7iBEYOoxKUsIxEYgZ2Jy41TdAC1b3rCYMIGogQbbo0uKyp4gWKnqpMuoYXJrv8SVmP YqvC2h8AcL6MuV3RWjTJ9OwwTLG8T8uC2L2b/YevMvubs48lJRK2inXgarO6IwSWuj+c n5kyMlsEhwloHP2ETugyYCOWKUDJaJEbxfr4utUmhbpIIlaSnAEXaVwJF9pxhkdhKIyw CxHvrZRSFcNdKWqxvHydQUBJPrVAb45duJfs2X4i1xvrmCYZ3g6jKruM6IbX0ynolSs9 2PXQ== X-Gm-Message-State: AOJu0YwlnA7Pj6MVLUpLUhRTz7Q8B/puXZ83+PBU4OvQ0T1PrC8wGKm8 VHVZBSmSc2jtf68C/AlwWOyZG/1ba4yGigRg8EYQVEzhImPQVcG/9r8Plv5p4gQX X-Gm-Gg: ATEYQzwFjKQHmUjb7VafoMQU6FgCzRzovQybuCWKNtx9b5LoqvMT1entxAgvR16TILt OV60/EYQmQozreruSFGbTabuYW5YFAwOgUenFLkjlwmtHjVn95me+IcivmdITvPxJMzE8MovEfn 4LSBqIyZ5Jw48AJRaiiJ7WWExHXaoa/WsKxx/T9Ub73r+xRUgYLX0SDjX8NfJR+2BPKz++qnDbJ esBgs71Czsrye7+yhC35UcoLY2W4qsMdXK6xM4I7odNfXMQuRNx61+j1nylRxM1HoOX+7G9R/vb 8Vg+sRWOMKosGSv567h9RXPjOrtgWTuJ5Q75W1mUu+XhQMGwy1pdIN0b44+C6UGuQygV6VnBOkk +U/K7Iqc1XyFN4rrnZn3vYOq/5mytDstELBbl/rclIVHhr72XW9QGhid2R0zquabDpTewyRHOBC tn8/A2iB5c6HgHpOx8N9Bxo+7jj5r0sySrOKlfmeE= X-Received: by 2002:a2e:a548:0:b0:382:f6d3:e0fd with SMTP id 38308e7fff4ca-389f2f44b5dmr7856521fa.4.1772114162100; Thu, 26 Feb 2026 05:56:02 -0800 (PST) Received: from DESKTOP-UN6N7AQ ([2a05:f6c5:273e:0:b9d0:5154:fb30:9c7f]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-389f3016bf6sm6464631fa.32.2026.02.26.05.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 05:56:01 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Thu, 26 Feb 2026 14:55:58 +0100 Message-ID: <20260226135558.195974-1-karlmogensen0@gmail.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Message-ID-Hash: MBZXZH32UYMVYKNYZ73M3SCO2VJZUGWY X-Message-ID-Hash: MBZXZH32UYMVYKNYZ73M3SCO2VJZUGWY X-MailFrom: SRS0=mpey=A6=gmail.com=karlmogensen0@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avfilter/af_lv2: call lilv_instance_activate before lilv_instance_run List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Karl Mogensen via ffmpeg-devel Cc: Karl Mogensen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: Why: the change is done to comply with lilv expectations of hosts. Added call lilv_instance_activate in the config_output function to abide by lilv documentation that states it must be called before lilv_instance_run: "This MUST be called before calling lilv_instance_run()" - documentation source (https://github.com/lv2/lilv/blob/main/include/lilv/lilv.h) Added call lilv_instance_deactivate in the uninit function to abide by lv2 documentation: "If a host calls activate(), it MUST call deactivate() at some point in the future" - documentation source (https://gitlab.com/lv2/lv2/-/blob/main/include/lv2/core/lv2.h) Added instance_activated integer to LV2Context struct to track if instance was activated and only do lilv_instance_deactivate if was activated to abide by lv2 documentation: "Hosts MUST NOT call deactivate() unless activate() was previously called." - documentation source (https://gitlab.com/lv2/lv2/-/blob/main/include/lv2/core/lv2.h) Regarding the patcheck warning (possibly constant :instance_activated): This is a false positive since the struct member is zero-initialized. Fixes: trac issue #11661 (https://trac.ffmpeg.org/ticket/11661) Reported-by: Dave Flater Signed-off-by: Karl Mogensen --- libavfilter/af_lv2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/af_lv2.c b/libavfilter/af_lv2.c index e7f3f9c588..df935601d4 100644 --- a/libavfilter/af_lv2.c +++ b/libavfilter/af_lv2.c @@ -74,6 +74,7 @@ typedef struct LV2Context { float *controls; LilvInstance *instance; + int instance_activated; LilvNode *atom_AtomPort; LilvNode *atom_Sequence; @@ -387,6 +388,9 @@ static int config_output(AVFilterLink *outlink) inlink->min_samples = inlink->max_samples = 4096; } + lilv_instance_activate(s->instance); + s->instance_activated = 1; + return 0; } @@ -574,6 +578,8 @@ static av_cold void uninit(AVFilterContext *ctx) lilv_node_free(s->lv2_OutputPort); lilv_node_free(s->lv2_InputPort); uri_table_destroy(&s->uri_table); + if (s->instance_activated) + lilv_instance_deactivate(s->instance); lilv_instance_free(s->instance); lilv_world_free(s->world); av_freep(&s->mins); -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org