From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3F02D4F3CF for ; Tue, 24 Feb 2026 22:03:01 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'tTQpUn2lo8cPDTEZnLbSjyaEvVgWy4p5xQxvV3zFPh4=', expected b'4hW0U2ddu2/5Eu2WH5gQA6Fg6zEQjFnmM/9Vy5gnosI=')) header.d=proton.me header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1771953401; h=date : to : message-id : in-reply-to : references : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=xrj2ROSJHs/m7sceLmMaetcFpHgfM23DVKPOaymrPTA=; b=O/8GcQ88AdcCHlYn24RCMrBfbI0voHSvEqLfEEdJhvH/n0AmWLc326zH+PQgPUP6Qnmis l01zGQpiCPWLDF0PxX6I34Y8ihaRzXjAMvy11Y1yX70ncbPUBlTkLLuQo5B1EZipRTotRJn 0My/3rsCmOXTytjEd5SsVkR7nfbUUjsoMWYK4hS/McvyPXkIVDvjNTZMZ4FAyWbfTvLP2+p WKwAseeecPBq1k4Pptbi3ft/2cjFMhjAVcn1G5/RZ9ii7+oUNhRmQM9IzJFElhdlQMF1BoY lNHT3PUWfzMaRqO7rbL7NGprVzXNRJrZ0hZEGPuWBseoghAlOaw1GSANoYzg== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 31FED69173D; Tue, 24 Feb 2026 19:16:41 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1771953385; b=MI8wxyWeP79d+kiVS5JKa/JDR4uDmj6ACCfkt7jIgfQ5tH4SJons9sg8EX6saIpfDEbO8 6VgobjBXChsLDYnvnovdPkvv2fh9BCN2DdCJOBMbdmLQk5mieq1faznYD5dt79N7ZvGbVat NNoxtYX2CrchZUXlPSPShNnnae4eRbmVDDd6ffvamuduIFhu5IGdAA9I7YadzeWfNEemkop f0+A+3d2ZpIKqhO7g6NvvSVxdCOHepdR3Pn5vs0XkA/qWXy6Q5M9vTEv/rPDEKZBytu2grp 0n5/aCvWXycg2P+5/jlq+y+O+WYOZKM2dZVtxhk9gruevIv9ndYhT3nCLp5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1771953385; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=tTQpUn2lo8cPDTEZnLbSjyaEvVgWy4p5xQxvV3zFPh4=; b=ndTWRTiXkLYsaxoF4nJ73uKZGCuioUOwmpQdaNBpabQuiZC840u3UF1crfPagxfdarYFN /V1tSFX1MRMnFVWV88cO62Q0EMcYGtARKFy/y+SVknl0iVk79wbgmEpenD8JoZ5CjiGtnVi T+9jejwX3ZMn5/lAesnMXtiS/KjmwO/CCLKJPkzTkd1Vins6A9thL/ZSnIoDjXQ7LOXIzwS 3Hcn0ozIRAne2/riSEYdUUtC26zpVoxZsEzMnKpeYB3BMSmmI6vVnGbJPxRrrWRO6bAH9XE 9pjZ9ZqI84ombg4664nk9vLFBcWc71FT2gQd0rh5ECcz6E3ShcJTzn3HxxpA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=proton.me; arc=none; dmarc=pass header.from=proton.me policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=proton.me; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=proton.me policy.dmarc=quarantine Received: from mail-4325.protonmail.ch (mail-4325.protonmail.ch [185.70.43.25]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1354F6910A8 for ; Sun, 22 Feb 2026 05:21:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1771730483; x=1771989683; bh=4hW0U2ddu2/5Eu2WH5gQA6Fg6zEQjFnmM/9Vy5gnosI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ejS616GP9MgKE5ENbN5Cw7+19Y80eezQ7BC8XNCkYrMC7BRgbbqk00mnXg09WD4mZ YbGH/G9SlHXhZGkrCNf1CuPowNbbzSIb+VciHA3ctAT3dJOf6E9+qhZYlsN33/ON1n byN8AqFSQ98T9tGb6hq/nC9lRhHO219Ao4sgve/qwE0UCNHK06DlBDEJhhaa34Prux 93yVQwOa/ZDqwtTmvvg+WVTjdLLOoxccMY/fLN68GKGjel97rhWuRxfyEagf/eSWVU axRbo/g0UOSvk+BNYDFOV55iKA7rvZijnPdr7/QuuzfA+wlKIx/a4Rf4ZLN27warUn oUCnr1PIDAV4g== Date: Sun, 22 Feb 2026 03:21:19 +0000 To: ffmpeg-devel@ffmpeg.org Message-ID: <20260222031845.94293-4-jfiusdq@proton.me> In-Reply-To: <20260222031845.94293-2-jfiusdq@proton.me> References: <20260222031845.94293-2-jfiusdq@proton.me> Feedback-ID: 167378330:user:proton X-Pm-Message-ID: 0607fe36d7ca98c229d18a648bbb0d146af3bd19 MIME-Version: 1.0 X-MailFrom: SRS0=j8RT=A2=proton.me=jfiusdq@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation Message-ID-Hash: YBM46YQSFC54VIHMJ6ELHXE5KX7W6PRY X-Message-ID-Hash: YBM46YQSFC54VIHMJ6ELHXE5KX7W6PRY X-Mailman-Approved-At: Tue, 24 Feb 2026 17:15:54 +0000 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH 2/6] ppc/swscale: fix signed accum in vsx yuv2planeX List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: jfiusdq via ffmpeg-devel Cc: jfiusdq Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: The VSX yuv2planeX_nbps path accumulates signed products into unsigned vectors, so negative terms wrap and the final pack produces wrong results (seen in swscale floatimg comparisons on ppc64le). Use signed accumulators and vec_packs() for the final 16-bit pack so the arithmetic matches the C reference. Signed-off-by: jfiusdq --- libswscale/ppc/swscale_vsx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libswscale/ppc/swscale_vsx.c b/libswscale/ppc/swscale_vsx.c index c6948546d5..727a273958 100644 --- a/libswscale/ppc/swscale_vsx.c +++ b/libswscale/ppc/swscale_vsx.c @@ -212,7 +212,7 @@ static void yuv2planeX_nbps_vsx(const int16_t *filter, int filterSize, const int add = (1 << (shift - 1)); const int clip = (1 << output_bits) - 1; const uint16_t swap = big_endian ? 8 : 0; - const vec_u32 vadd = (vec_u32) {add, add, add, add}; + const vec_s32 vadd = (vec_s32) {add, add, add, add}; const vec_u32 vshift = (vec_u32) {shift, shift, shift, shift}; const vec_u16 vswap = (vec_u16) {swap, swap, swap, swap, swap, swap, swap, swap}; const vec_u16 vlargest = (vec_u16) {clip, clip, clip, clip, clip, clip, clip, clip}; @@ -220,7 +220,7 @@ static void yuv2planeX_nbps_vsx(const int16_t *filter, int filterSize, const vec_u8 vperm = (vec_u8) {0, 1, 8, 9, 2, 3, 10, 11, 4, 5, 12, 13, 6, 7, 14, 15}; vec_s16 vfilter[MAX_FILTER_SIZE], vin; vec_u16 v; - vec_u32 vleft, vright, vtmp; + vec_s32 vleft, vright, vtmp; int i, j; for (i = 0; i < filterSize; i++) { @@ -235,15 +235,15 @@ static void yuv2planeX_nbps_vsx(const int16_t *filter, int filterSize, for (j = 0; j < filterSize; j++) { vin = vec_vsx_ld(0, &src[j][i]); - vtmp = (vec_u32) vec_mule(vin, vfilter[j]); + vtmp = vec_mule(vin, vfilter[j]); vleft = vec_add(vleft, vtmp); - vtmp = (vec_u32) vec_mulo(vin, vfilter[j]); + vtmp = vec_mulo(vin, vfilter[j]); vright = vec_add(vright, vtmp); } vleft = vec_sra(vleft, vshift); vright = vec_sra(vright, vshift); - v = vec_packsu(vleft, vright); + v = (vec_u16) vec_packs(vleft, vright); v = (vec_u16) vec_max((vec_s16) v, vzero); v = vec_min(v, vlargest); v = vec_rl(v, vswap); -- 2.47.3 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org