From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5D38949359 for ; Thu, 22 Jan 2026 08:51:07 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'rEH7hJV7JEjVROel37bdAwFdkeqm6XrQXcmotOyZ2kA=', expected b'BsX7NR0+D4DZk73VHU44L4LdXiQNhJs4q/nA0jZeTp0=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1769071855; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=izYs+oSxJEYYr+v54fIwXvsElRpSstH/cXh/rJ/OJME=; b=PNKFC1hRjkN9FDSYSoEc+plQTASeaa7EqqsCT0zZRlbkuGhXj9PZK6e13N4veljUflbaW SngK25i/p+Joe1u9WnXaHNBYZZcpvUs8jWZRdozklJtp2QvjeiY84Cbyf9qGl9iuOdTRd8G DsyN3yQyIzw095fKgMVGMHV7zzohpxEW7fHd6x2IDfr81BXWq2saVhWcjLKfG2yWW8ZYD1N P/keCb/6vYZWHjdvMKy3QjW4sGe9FK6KOfuLiecZAG4CM3SFUoxk35PrO2Q+yJytHSFP90I WzWkEoxciKdFQTdc+JhV+3C184QULFLYQ+PPml3j2diGQ3pTYvD4fu4m+KEA== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BBD54690F34; Thu, 22 Jan 2026 10:50:55 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1769071841; b=aabQntsoX7OaWm62rXIvDu2Ojr6vDVIH5xfZ6fNnAhLpWHwr7cauG8GV1KOliWEMTI/Hq SIwDx4wRnMEYQ7KI0CQZHNvjB7yPBR7pipi6qqavKw3kMF4a6qBez+0Vhj/Kyfha+foxOcE fPjWl7hJJncswZQw8Tp9CwOflLqUw1c5/hDqHgh2UGJM/aMy6XgYj0tqreyRuYviIrzdQcz 31p4U0zqKlm+q3b+5/7RS3ERFv7BXRaGfdHevPK3jcadgD0nGwtj8CImSlg2uSUsQTMVxB8 J7cQe8wN+a7NVMt8h6JRwNGQ0ZV//zaTyOTLXRINi4grDf+OGZUn+P7K1mfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1769071841; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=rEH7hJV7JEjVROel37bdAwFdkeqm6XrQXcmotOyZ2kA=; b=iVF79TzI61Q1wPGxRZ3JYggCuP1uheQMWC4LhzXSuGNwpYfF1aQpvTTU2EUDCIzQPTlI+ S1J9wI/6dHavbLNWrjh9ib54w3Iu0cUETpO3dPCFXIuZMIGp7kUr0cSfXEJt6uJcAxBQ57q PXwD+LvdyqCZAt904fGaB8Hu1f+UpoRrjXbpuTo2JMzOkjv+05j9wFSMNeHKpq4KsCwPusB jcO9Ng6LCPJBsqd3B0rSmvyH26R3tDRzXiwsTDFlSMOy2pHiWG28Tg36tTOyqTDn1/vrLOt KKRAo7370kXtbkDaPkwlYgSzOQAChxI0ATQOLMavN4QpAHHEbZMTMypsJLHw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A1A1D690EC3 for ; Thu, 22 Jan 2026 10:50:26 +0200 (EET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a09757004cso6661275ad.3 for ; Thu, 22 Jan 2026 00:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769071824; x=1769676624; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BsX7NR0+D4DZk73VHU44L4LdXiQNhJs4q/nA0jZeTp0=; b=bhnG/J+TyQ7ZnMUk30QjTZUORFSZm+IOdoqC1fZv67Wz9hMuW2p2H+afyla7GfIeNS RMrPxmo5TusvjNI0kaDWtALJEmzKDt8wy5NauGHpHt26jgVYll3cy52Sy4oNW0BLkrSY JLcR9gy3j2F2/WfrFq93oEK2VwyGVG+LXktGgwadqK2u7MVhnw0qHTuhyiW94UpYmGr3 /6cw0R3sFnJPYjN1ewsrkUpW8Gd29LlVyefGehQbqvnQP4NL75iM6IIpJ6xYKqDGxYgV 6jT8KghMsMuJPSi/EXWl3TvSNQ0oP+f2KulyENdByA2eMgtlT2AR33rUE59cpQmuJrFN gm5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769071824; x=1769676624; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BsX7NR0+D4DZk73VHU44L4LdXiQNhJs4q/nA0jZeTp0=; b=LyrvVFEm/CG1RXXgt5KrkV+t46EDWp+8N4zO0vORTQr+5rGrFZKHLuqtqb8cY0FaLg 7da8RLBZ4vEND7xPnV42B01G97ywHG8jYKzOaQgHWdTRdrAKLFJhC82LMbVvBuPSWw13 nbvLhmQ3FNfC5bMCo40BVTe/GLFGqt90+dCr9p2Z8+fCmuQ34tdd6ZSsjhljAKAghF3d JCUAww009bN8xmQcvACwL1v1tZ5lHt9TX32mBOqbYm/huxufcVkM2Taebwmzu7ra0/7q GGQLcabkBCaIsz8PUhBtmCVVp/ZHa0AxDaclIL7Au4kIgKmOkE8NtWPHiwXDafhEqfSi TxMQ== X-Gm-Message-State: AOJu0YxmDsukGFksFmpd7Gm1YbVrhsJeNd8QNBplrUKLFYMN6M90rRnT adeUVOPod3X13zgGHfRqMixLvytBse+XAJzDkpWBrJCimYqJyFDWAOyYMNJifA== X-Gm-Gg: AZuq6aLY+uB3xUsyhgX4ZHviGl62467l4pj9/MKrKri2h5iEY2HbwzTN2n1r8rtNJdp SfosQry5vFdchWjb5wmrVhOe9lV7/y6ufrIHFumwDBRTep268aR4MMyvFXQvL6iHhXD7LgteSzC ZBk3Hx3gGi7FcBf1YJwTblYKFYhW9axBkYkpjOpZgHqEa0PE55sFWmbAx+CZnMjr2KKMirTqiYV QMX4t49prkYVWlmZGO2py2RQiNJp94tMWzh1L4s2Iv0JdZsipa9izuzVBQMYKyTYB7RJMww4LEF QiKn3QrqMSEhI148gn+7Xh+/BGP/GtNFqRM9D2fIgTk+GNXqlpf3FPesAVjQbkqha4KoUKlIK+Y hJhmNWXjEQA5A2oQpf4WXyOtS0sMdT1cEcYapYh/VNykj5ewzYBJH+3o/H2DSSw3cokGtGcppPA t7VilBm24AtRc7pYg+Alm07pWIlS7kdM0ifTeRJw== X-Received: by 2002:a17:903:120c:b0:2a0:b44e:9ab6 with SMTP id d9443c01a7336-2a7174f0bacmr209146865ad.7.1769071823961; Thu, 22 Jan 2026 00:50:23 -0800 (PST) Received: from F56L47RP7T.bytedance.net ([203.208.189.12]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7193fbf8fsm176149495ad.78.2026.01.22.00.50.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 00:50:23 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Thu, 22 Jan 2026 16:50:13 +0800 Message-ID: <20260122085013.36976-1-mbillchan@gmail.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Message-ID-Hash: JBOVIFW6JCNAWK4ZT6N6JYDYMHWJLSDD X-Message-ID-Hash: JBOVIFW6JCNAWK4ZT6N6JYDYMHWJLSDD X-MailFrom: SRS0=C5UJ=73=gmail.com=mbillchan@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/aarch64: add NEON optimization for draw_edges List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: chenmingbiao via ffmpeg-devel Cc: chenmingbiao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: From: mbillchan Performance improvement for draw_edges function using NEON instructions. Optimized for edge widths 4, 8, and 16. Benchmark results (AArch64): draw_edges_8_1724_4_c: 851.4 draw_edges_8_1724_4_neon: 824.7 (1.03x) draw_edges_8_1724_16_c: 1620.9 draw_edges_8_1724_16_neon: 1049.9 (1.54x) draw_edges_1920_4_16_c: 849.0 draw_edges_1920_4_16_neon: 571.1 (1.49x) --- libavcodec/aarch64/mpegvideoencdsp_init.c | 3 + libavcodec/aarch64/mpegvideoencdsp_neon.S | 157 ++++++++++++++++++++++ tests/checkasm/mpegvideoencdsp.c | 5 + 3 files changed, 165 insertions(+) diff --git a/libavcodec/aarch64/mpegvideoencdsp_init.c b/libavcodec/aarch64/mpegvideoencdsp_init.c index 0402ac9e82..8363b18f48 100644 --- a/libavcodec/aarch64/mpegvideoencdsp_init.c +++ b/libavcodec/aarch64/mpegvideoencdsp_init.c @@ -26,6 +26,8 @@ int ff_pix_sum16_neon(const uint8_t *pix, ptrdiff_t line_size); int ff_pix_norm1_neon(const uint8_t *pix, ptrdiff_t line_size); +void ff_draw_edges_neon(uint8_t *buf, ptrdiff_t wrap, int width, int height, + int w, int h, int sides); #if HAVE_DOTPROD int ff_pix_norm1_neon_dotprod(const uint8_t *pix, ptrdiff_t line_size); @@ -39,6 +41,7 @@ av_cold void ff_mpegvideoencdsp_init_aarch64(MpegvideoEncDSPContext *c, if (have_neon(cpu_flags)) { c->pix_sum = ff_pix_sum16_neon; c->pix_norm1 = ff_pix_norm1_neon; + c->draw_edges = ff_draw_edges_neon; } #if HAVE_DOTPROD diff --git a/libavcodec/aarch64/mpegvideoencdsp_neon.S b/libavcodec/aarch64/mpegvideoencdsp_neon.S index 8175d8975e..6b9cfc62ea 100644 --- a/libavcodec/aarch64/mpegvideoencdsp_neon.S +++ b/libavcodec/aarch64/mpegvideoencdsp_neon.S @@ -91,3 +91,160 @@ endfunc DISABLE_DOTPROD #endif + +function ff_draw_edges_neon, export=1 + mov x9, x0 + mov x10, x1 + uxtw x11, w2 + uxtw x12, w3 + uxtw x13, w4 + uxtw x14, w5 + uxtw x15, w6 + mov x0, x9 + mov x1, x12 + + cmp w13, #16 + b.eq 1f + cmp w13, #8 + b.eq 2f + b 3f + +1: + ldrb w2, [x0] + dup v0.16b, w2 + sub x3, x0, #16 + st1 {v0.16b}, [x3] + + add x3, x0, x11 + sub x4, x3, #1 + ldrb w2, [x4] + dup v1.16b, w2 + st1 {v1.16b}, [x3] + + add x0, x0, x10 + subs x1, x1, #1 + b.ne 1b + b 4f + +2: + ldrb w2, [x0] + dup v0.8b, w2 + sub x3, x0, #8 + st1 {v0.8b}, [x3] + + add x3, x0, x11 + sub x4, x3, #1 + ldrb w2, [x4] + dup v1.8b, w2 + st1 {v1.8b}, [x3] + + add x0, x0, x10 + subs x1, x1, #1 + b.ne 2b + b 4f + +3: + ldrb w2, [x0] + dup v0.8b, w2 + sub x3, x0, #4 + st1 {v0.s}[0], [x3] + + add x3, x0, x11 + sub x4, x3, #1 + ldrb w2, [x4] + dup v1.8b, w2 + st1 {v1.s}[0], [x3] + + add x0, x0, x10 + subs x1, x1, #1 + b.ne 3b + +4: + sub x9, x9, x13 + tbnz w15, #0, 5f + b 6f + +5: + add x2, x11, x13, lsl #1 + mov x3, x14 + mov x4, x9 + sub x5, x9, x10 + +7: + mov x6, x5 + mov x7, x4 + mov x8, x2 + +8: + cmp x8, #64 + b.lt 17f + ld1 {v0.16b, v1.16b, v2.16b, v3.16b}, [x7], #64 + st1 {v0.16b, v1.16b, v2.16b, v3.16b}, [x6], #64 + sub x8, x8, #64 + b 8b + +17: + cmp x8, #16 + b.lt 9f + ld1 {v0.16b}, [x7], #16 + st1 {v0.16b}, [x6], #16 + sub x8, x8, #16 + b 17b +9: + cbz x8, 10f + ldrb w16, [x7], #1 + strb w16, [x6], #1 + sub x8, x8, #1 + b 9b +10: + sub x5, x5, x10 + subs x3, x3, #1 + b.ne 7b + +6: + tbnz w15, #1, 11f + b 12f + +11: + sub x3, x12, #1 + mul x3, x3, x10 + add x4, x9, x3 + add x5, x4, x10 + + add x2, x11, x13, lsl #1 + mov x3, x14 + +13: + mov x6, x5 + mov x7, x4 + mov x8, x2 + +14: + cmp x8, #64 + b.lt 18f + ld1 {v0.16b, v1.16b, v2.16b, v3.16b}, [x7], #64 + st1 {v0.16b, v1.16b, v2.16b, v3.16b}, [x6], #64 + sub x8, x8, #64 + b 14b + +18: + cmp x8, #16 + b.lt 15f + ld1 {v0.16b}, [x7], #16 + st1 {v0.16b}, [x6], #16 + sub x8, x8, #16 + b 18b +15: + cbz x8, 16f + ldrb w16, [x7], #1 + strb w16, [x6], #1 + sub x8, x8, #1 + b 15b +16: + add x5, x5, x10 + subs x3, x3, #1 + b.ne 13b + +12: + ret +endfunc diff --git a/tests/checkasm/mpegvideoencdsp.c b/tests/checkasm/mpegvideoencdsp.c index 955cd9f5b7..fdaed08e86 100644 --- a/tests/checkasm/mpegvideoencdsp.c +++ b/tests/checkasm/mpegvideoencdsp.c @@ -147,8 +147,13 @@ static void check_draw_edges(MpegvideoEncDSPContext *c) LOCAL_ALIGNED_16(uint8_t, buf0, [BUFSIZE]); LOCAL_ALIGNED_16(uint8_t, buf1, [BUFSIZE]); +#if ARCH_X86 declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *buf, ptrdiff_t wrap, int width, int height, int w, int h, int sides); +#else + declare_func(void, uint8_t *buf, ptrdiff_t wrap, int width, int height, + int w, int h, int sides); +#endif for (int isi = 0; isi < FF_ARRAY_ELEMS(input_sizes); isi++) { int input_size = input_sizes[isi]; -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org