From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2381B4E3A4 for ; Tue, 20 Jan 2026 14:11:52 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'TG5gkLhA9J9q5gPbjUMsQd/umqC+7+iccl6znWjp7OE=', expected b'/y6LQzwKuEuRo6PCmoTj0ROLNfOBY0MSI4JzLNQ5kZk=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1768918274; h=to : date : message-id : in-reply-to : references : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=IPnGtBLgHHGlg1qdwza8Kwb3pXvJ2K5+jx0aof5rkmY=; b=UTDMZWJd3wBAzoq63uSXPz0fm5Sgsj06xlNJZbSBeh/PVE53lTcx4ODabowt5KRqJwesa R5wsqwRnB/SKMFS1JHIndD1PMtidNvzFsXv+yOyUOL22vNiIbLENPDpUNbdJyKNqLuS1VUp inqYkWdt8Zv6Y0+xCxBD33TbtlEsEnbNw0zhiOLCjigdMhSD0u3fwT/8Wk9TKwz4gemIAo+ nner0Xb1oybqoWJj8OzRIbsBPOaLnlW4HYVgKxgNPOLrEwqnAjcXkkF6r9x0lZMKImj5lS8 /dfObzPOzQS0jwB/X/aDIheNRs6EQs5tHerM7AMs6FcAK5eU8MwiLpnB/Bvg== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 669AB690E6C; Tue, 20 Jan 2026 16:11:14 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1768918267; b=iQQGW2/ZfwYXgWGj89ElF6t9JS4UFS2wAsV1jsKbAv9a5mhTPrqL2l8XUuq49QmN8gzKR EIqsj2xV06YDD/uSqk5DdMsbovjAiR4F6wXbvS+1Lxu6LuiEivltSYLvqt7sTLJDPBg10gV 3etP69ZMTx5KnP4RT50gbSSDSjuDUe3hXFyumCByeyyad06vtz3qFiE4XV7bg8zRG20MWyg k7VJT7PrsH19ttRY7gcoLl1CeAJjGtvycqyYxeNpPT9tHllA1LKZvwb4ShCQxb/FZpqik1T iLAJMt5HO27jTm0KZyRz94Q78hXedLM+x+Yii6IsL7nMB9ix6ApJh0KGWfvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1768918267; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=TG5gkLhA9J9q5gPbjUMsQd/umqC+7+iccl6znWjp7OE=; b=iUsmbrvoXVDze38FC57cFsLujDqQk5Up5SBkphlYPib5N8hZLCa22cm0eTqXOe6FFF2fv 5wOLlLOM/EClrm3DdYK+QqDtj4UwOoUUEvTO+Q3QD3a1j96eLUiF2ebsbtJmNEUAPTbWWLC lEFaNlB1pZS1kMLpFmwFLippe5XAobttVW/7XVhPSDi1aBZ1VtHhWtt8oK/qwz2C16ck7+a Pr+WAlkw+wqe+u70VIY1l9+ljmydhVMWt2n0u97kQqmaXxJGr3ot6lwI99uddcvSAjJUwNt OeWFnOhSPVVWy7SJIG4GHe8n3C2qxbUGqHE2xhiWmRhBUiOKf/VuqC5IXU0g== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id BA3CE690E71 for ; Tue, 20 Jan 2026 16:10:29 +0200 (EET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2a3e76d0f64so32553675ad.1 for ; Tue, 20 Jan 2026 06:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768918217; x=1769523017; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/y6LQzwKuEuRo6PCmoTj0ROLNfOBY0MSI4JzLNQ5kZk=; b=hNmRp5feA55hmH52TuXEJtFfNW5A4VfB3qimY/I0irbOMaM0+aGqrszf2KNaconeBM plWB8o+LSQi1FxVqhxGoxNLnho2TfAf5fTqhh79AIifK+FvA2EYkz9+0wurRYe404zcd dmejRpYIOdiM+IoAiosxgXiZSV+whTZ7Cb4TklCxAExrT7YIdGe7Sv2GcNOxoK0E7eGS 5XG75eSF7BLW2mEfWP4FYQN4OQG7EeJc+PtVXFm5OO/YOcwSel9ihXsx43A64rCDUc0m aPNaXb0IuKZGHWZz/vuPKE952LJUxPjIolu0mHTj+6eIucV+AQXQYHmLXBQu0Va4/bfl YXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768918217; x=1769523017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/y6LQzwKuEuRo6PCmoTj0ROLNfOBY0MSI4JzLNQ5kZk=; b=iPQmo03JU4akV4zYDl+wDQQcZc8Ar1870N+0DLoeA1MOF8BUNj2518artVesuaQh3m O8zfmjHkqLCjDOuMLxTcQjkcBRMBD0y5VHMZybmd/fKcIfw3/Vh6HY0jq4RCoDgzjeli sM/MVUmuMvVvC1ADtJxjzBSkKLVanFXoud9Vd+8+/zMNaUqp3UPVW9fOjOymCVYG7w/k mW+X+PSXxeGgm32kOnd+9PAYOEztVxfaVZiRwG+QHcCmrg0f5wQRuKBmJeNxj1IXgsLu hdgSkXXi3teviSU5mTwP/FcdlG7ZtiGN5+hZM/GyZMzMG6M01ii2GDVAVEePP0/XXYqY MHhA== X-Gm-Message-State: AOJu0YwLj1/FU0JipK1sfLf4R/k9fbTtEXVepQJmOui7shs/G+8+aMT6 MKjY1FSiF0SWGOfFIxGJoF9VRkGhEgnWx4PHheTmdRG1AWhgEIj3QrcKg27UlA== X-Gm-Gg: AZuq6aK+EeOCGiMuidnEU5EfXCIjbcHVdCpC4wEknzkD74LB6ehUKVm7n+57CrInF5q tIlyRJ461BnSwJ8nzHNNX3s71xtYGN5SAkvbZA4aPmWHI0GxSL6BfhciV02CAIgeEXO7h6Lv+tZ C5gm8OmYujDRohCNN1NtQvYAig3mRfBdPOMil6fSd/BJdH89MWIg2GEBS9fdOCAdLRqvPeVAdMS wshrOESCYrTrGxBFPpOr8qNjipDe/NpXt9ZQ8n49pvki1A9koQNYwaVu3XdgLnrWFOT3kPOXsRf mfqKYl3Jq1PhPO1i5BzS6zJr6NARnCn6Qsbbrk7pVoiWZ20Pj/y9pmAkeFpJHYp1pZ/FmuXznyW m5E4mhcOUYtgBR+q3mW2Hr290x/uBqXEhTqs+CbRXysc/GCubis2lGp5vcfWundworOOihYgzIp actqp3xeSSqsyEwoa8gRDWfPE1hKHZzcJbKmCcG6FejA== X-Received: by 2002:a17:902:ef0a:b0:298:639b:a64f with SMTP id d9443c01a7336-2a71754671fmr147976295ad.6.1768918217174; Tue, 20 Jan 2026 06:10:17 -0800 (PST) Received: from raja-rathour-ASUS-TUF-Gaming-A15 ([2409:40d0:12d0:e74c:a65c:c0fc:8cd6:691d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7190ca058sm122729115ad.33.2026.01.20.06.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 06:10:16 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Tue, 20 Jan 2026 19:39:39 +0530 Message-ID: <20260120140939.32403-4-imraja729@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260120140939.32403-1-imraja729@gmail.com> References: <20260120140939.32403-1-imraja729@gmail.com> MIME-Version: 1.0 Message-ID-Hash: DKTK2MAWTRRUJRCRINFSFVAERKZ3NMGG X-Message-ID-Hash: DKTK2MAWTRRUJRCRINFSFVAERKZ3NMGG X-MailFrom: SRS0=8m41=7Z=gmail.com=imraja729@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH 4/4] avfilter/dnn_backend_torch: improve device selection and error handling List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Raja Rathour via ffmpeg-devel Cc: Raja Rathour Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: --- libavfilter/dnn/dnn_backend_torch.cpp | 38 +++++++++++++++++++++------ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index 4f7ae17aab..73eadc6b7e 100644 --- a/libavfilter/dnn/dnn_backend_torch.cpp +++ b/libavfilter/dnn/dnn_backend_torch.cpp @@ -255,16 +255,30 @@ static int th_start_inference(void *args) LastLevelTaskItem *lltask = request->lltask; TaskItem *task = lltask->task; THModel *th_model = (THModel *)task->model; + DnnContext *ctx = th_model->ctx; std::vector inputs; - torch::jit::setGraphExecutorOptimize(!!th_model->ctx->torch_option.optimize); + torch::jit::setGraphExecutorOptimize(!!ctx->torch_option.optimize); + + if (!infer_request->input_tensor || !infer_request->output) { + av_log(ctx, AV_LOG_ERROR, "input or output tensor is NULL\n"); + return DNN_GENERIC_ERROR; + } + + const char *device_name = ctx->device ? ctx->device : "cpu"; + c10::Device device = c10::Device(device_name); - c10::Device device = (*th_model->jit_model->parameters().begin()).device(); if (infer_request->input_tensor->device() != device) *infer_request->input_tensor = infer_request->input_tensor->to(device); inputs.push_back(*infer_request->input_tensor); - *infer_request->output = th_model->jit_model->forward(inputs).toTensor(); + + try { + *infer_request->output = th_model->jit_model->forward(inputs).toTensor(); + } catch (const c10::Error& e) { + av_log(ctx, AV_LOG_ERROR, "Torch forward pass failed: %s\n", e.what()); + return DNN_GENERIC_ERROR; + } return 0; } @@ -415,14 +429,23 @@ static DNNModel *dnn_load_model_th(DnnContext *ctx, DNNFunctionType func_type, A { THModel *th_model = av_mallocz(sizeof(THModel)); THRequestItem *item = NULL; + const char *device_name = ctx->device ? ctx->device : "cpu"; if (!th_model) return NULL; th_model->ctx = ctx; - th_model->jit_model = new torch::jit::Module; - // Commit 1 uses the simplest loading logic - *th_model->jit_model = torch::jit::load(ctx->model_filename); + + // Robustness: Wrap model loading and device movement in try-catch + try { + c10::Device device = c10::Device(device_name); + th_model->jit_model = new torch::jit::Module; + (*th_model->jit_model) = torch::jit::load(ctx->model_filename); + th_model->jit_model->to(device); + } catch (const c10::Error& e) { + av_log(ctx, AV_LOG_ERROR, "Failed to load torch model: %s\n", e.what()); + goto fail; + } th_model->request_queue = ff_safe_queue_create(); if (!th_model->request_queue) @@ -436,7 +459,6 @@ static DNNModel *dnn_load_model_th(DnnContext *ctx, DNNFunctionType func_type, A if (!item->infer_request) goto fail; - // Infrastructure setup for Async Module item->exec_module.start_inference = &th_start_inference; item->exec_module.callback = &infer_completion_callback; item->exec_module.args = item; @@ -463,7 +485,7 @@ static DNNModel *dnn_load_model_th(DnnContext *ctx, DNNFunctionType func_type, A fail: if (item) destroy_request_item(&item); - // Passing the address of the model pointer + DNNModel *temp_model = &th_model->model; dnn_free_model_th(&temp_model); return NULL; -- 2.51.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org