From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4B0614E35B for ; Tue, 20 Jan 2026 10:25:01 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'euHVI1mJ+CT7P1CnfSfaQjr+cdjWQ/3A+XLBdG2+zN4=', expected b'mhMY7nxQkUWjePf7qJTl1D1OrRisyEaztG+c+BpILsg=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1768904689; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=SGiYwHqYrOgpbMgL9FB7ksY2rz+e8H/HsHYMAuMNkvQ=; b=F0e+964kFtYrgym8IU2ciTbKwYwZyngOblY5FzsU3gm0XWNK0M99ytgIEAd4cMTH/bMAB c1C3kPlajniKu25lnblnp7EJMo4wdNAp+/LZ2LvfnUoNVYPaRMfCI5SNcnKk5D+zHWy+BEW yrbLao5Zu4WL4QDnDmCeSXigp+sYD3hNaEThmwQs/tXmk8ofNvMM//manw449bo9O1sottN A2bR1yHDTkQgtBmLqZ9ekfGbpTHLOMPjEgiGUgp1LhBnWcC7FTaQeowgK+brI4BHWaFegiU UQH7gDpOZ54CLlxa6HQDtRT7i9X0TSX6mIiNeM9GNTbDS9sQqRgyGMeW1LkQ== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8A647690E95; Tue, 20 Jan 2026 12:24:49 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1768904672; b=HytED9N19AAoj5nz+YC6jWl9tUVJCRO7Mon2YOGxWQBXL2cN6V9EhD4z7ZbG7SxYCdmWO mv+Dz2Y8G8kVLUr2/KyuHmtt5G5dB/6HkGSFPSW9mL6ykEPmtyCl0IdQS1sbkoWWlqiMjsk QxZo6GY3lCgdnGBl5DmiNpj8/Vw1rpdXDCmL5z0zX2u61JcXdYd1c1rP1rE+CSbw1fKZPP2 v/el2kWeUmrfe74yV9WFuBLzhIhP0XZQ2sFlBgG0vWwg/IT8GKsTegDMq0PDhN5YHWbiDAP G5DlUsjmmyQ4rXW6ThAX78LEZ0hA7p9kJpbgUguCzJ6Wfw815i4KNZvYUI3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1768904672; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=euHVI1mJ+CT7P1CnfSfaQjr+cdjWQ/3A+XLBdG2+zN4=; b=iLqR7NibKZaEbmJpBoDJqxF+yZ2JdfTfsXE17bWh8eTquwdGHQnNDA97+q8670s9wvQ9s nMvyb/Fl3o2R+Wm5kJIbWwts84hsALpmpqTnPkjqsIZ7clBJLYcFI7EZXt5VvvLO6cRROVE 74ncj+Xc2P7K0NG/EsL8fKRKlZEbw9i7Xss6hAf7Bib7uOGP6BrPSH8rl62fOwj/X41xFiJ S6aZ8xxBFSUUgu6S9IeB1zKjbbym6FgGX6NlzQ1tYsjvRqRAgmGixil1MtXRK1rZzfNfDVo uXSRLmi0RDtxMYAlC1knnFXmmmpQk1Zw+QEx5rwjseSMdwrwRq0nRV+96z7Q== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4B0EB690DC2 for ; Tue, 20 Jan 2026 12:24:18 +0200 (EET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-81e7477828bso2845041b3a.0 for ; Tue, 20 Jan 2026 02:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768904655; x=1769509455; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mhMY7nxQkUWjePf7qJTl1D1OrRisyEaztG+c+BpILsg=; b=BVc6zU42lwMSB2ufB2qJURpR9Gj7+8yj1YXXUEckHnhtXM3pt3KjoA/z/MxU7ORi9r 0vJXEaOJMddRse8nkkepxqeB+cVYDw1y1EhEL0gzwPZrsKqLkcAYZSrUDE2Xx9+OBrSg HZCnlx3dPDu2HcW1Kg1V/bEEK+WfzeqkcoZttMSrAUjFOI6S7pbIhYvXpr+FyEt4ULNb UBdgzpvKzYj/nRPqTZxaRJWuDdNfnJgAucevuH+aePt/JM34lY2dUEzyuiVzEeOiJmvv I+wghDLKqXVhAY12M840+GILz46IwGZE9eCKtafsAdyZfarTonNJcCIWlnr/l/f043tZ jy5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768904655; x=1769509455; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mhMY7nxQkUWjePf7qJTl1D1OrRisyEaztG+c+BpILsg=; b=bpiFg3hx6h+A7lHGJj3T6SEW20Y9enUJ/RMgO98tjYe9nU6CMLRt8Hr84lb4aBWNeF W8VvUfY8VDPYN+sU0TLRZ7FZwzDwKihcIsM7kicd9fvH3FHNNKVwxuu8elltIDfnnNbl A8YGGDY71TnPZ/VeNHQWw2auYojHNDwM5/BQGmYqdWsdcdRn3YnHLP9950gV3ZHh7tML TsxO4KClOIOc6nSyZZW9RxQZNxCUyPcQGe814MswlD1LS1rqIQxn9U8Qd0eJGymHJsQ8 n/1RrlPDYW+Q2vOlO3Q5mpdpK0yfvgKqXU9dFQJqSC0FdViEzDOkgUQUbvUjhP1VtBzB H1xg== X-Gm-Message-State: AOJu0Yx7X3uqy85jkhaS4DOQ6S7sy2J/NA5/YiDTn4RZaFu2iahbRr4x a1E/gBr02ybENhfA4TeVs3YW9gkbXmbGkw0e5DJLOWetjxDcXuMH74O3DIdTSA== X-Gm-Gg: AZuq6aLN0a9j1tTfbKCdLoAIyo//8/+Zkylz04rJd36b4hCLbkWLpIECpIbvDPzkgbF n9knRQ1ejKYrdJoR4OqDlg1Zmydrdjs5M2/kofniHkjxRfGPEJMUKkiWcZKWqRnh0hcAwzZmVdj tXDk6eQB6BB8EFuJmYqkoZR+6f/dHBOoxlzd3UOnXuVGGSaNo/JvqSRmJKIRKJ0teM6PKYlitut Y1aMQdrNiN+a1JY9najy1QjQkhsJVmtWi4Gb+gMrngaEioj42YM4HEVQsNo3aSN99AarhXECyFV W/TQp9AvVu4jDLMxjmAJLwdJhXhmiOSr+KJOFOF6mILmJ2qsww0hPv+BMW08cSPNlojfAaQdLhy 5A98vCSos52jXu9JJCCSxH4nF1xiV5UkH9A9svjzCuYtl53lsWZmOaSyEgkNic1J0AaCc0EbzpE nnjULeVfCwpjZ+KUEYsNqwNM5yQ8SR7bhCP3NOyiOYl9G2CV7AlHIj3laQDA== X-Received: by 2002:a05:6a00:3d4b:b0:81f:535f:b48a with SMTP id d2e1a72fcca58-81f8efbc17amr14096216b3a.7.1768904654935; Tue, 20 Jan 2026 02:24:14 -0800 (PST) Received: from Zanes-PC ([2404:4408:6c00:1e:64f7:f116:2d23:31b4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa10a03ffsm11741587b3a.6.2026.01.20.02.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 02:24:14 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Tue, 20 Jan 2026 23:24:08 +1300 Message-ID: <20260120102408.493804-1-zanehambly@gmail.com> X-Mailer: git-send-email 2.51.0.windows.2 MIME-Version: 1.0 Message-ID-Hash: S67M7UEL53E44IVV4EAPAN6PUK4KLJ3Z X-Message-ID-Hash: S67M7UEL53E44IVV4EAPAN6PUK4KLJ3Z X-MailFrom: SRS0=BX1q=7Z=gmail.com=zanehambly@ffmpeg.org X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/x86/h264_intrapred: add AVX2 for 10-bit pred16x16 functions List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: ZaneHam via ffmpeg-devel Cc: ZaneHam Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: Add AVX2 implementations for 10-bit H.264 16x16 intra prediction: - pred16x16_vertical_10 - pred16x16_horizontal_10 - pred16x16_dc_10 - pred16x16_top_dc_10 - pred16x16_left_dc_10 - pred16x16_128_dc_10 10-bit 16x16 blocks are 32 bytes per row, perfectly matching AVX2's 256-bit YMM registers, allowing single-instruction row operations versus two XMM operations with SSE2. checkasm benchmarks on Zen3 (cycles, lower is better): C SSE2 AVX2 pred16x16_dc_10 65.7 40.3 27.3 (1.48x vs SSE2) pred16x16_128_dc_10 31.1 28.1 21.4 (1.31x vs SSE2) pred16x16_horizontal 67.8 28.1 21.6 (1.30x vs SSE2) pred16x16_left_dc_10 55.6 35.0 22.9 (1.53x vs SSE2) pred16x16_top_dc_10 49.5 32.3 21.8 (1.48x vs SSE2) pred16x16_vertical_10 32.3 28.3 24.1 (1.17x vs SSE2) --- libavcodec/x86/h264_intrapred_10bit.asm | 186 ++++++++++++++++++++++++ libavcodec/x86/h264_intrapred_init.c | 14 ++ 2 files changed, 200 insertions(+) diff --git a/libavcodec/x86/h264_intrapred_10bit.asm b/libavcodec/x86/h264_intrapred_10bit.asm index 2f30807332..78e2f263bc 100644 --- a/libavcodec/x86/h264_intrapred_10bit.asm +++ b/libavcodec/x86/h264_intrapred_10bit.asm @@ -1117,3 +1117,189 @@ cglobal pred16x16_128_dc_10, 2,3 dec r2d jg .loop RET + +;----------------------------------------------------------------------------- +; AVX2 versions of pred16x16 10-bit functions +; For 10-bit: 16 pixels * 2 bytes = 32 bytes = 1 YMM register (perfect match\!) +;----------------------------------------------------------------------------- + +%if HAVE_AVX2_EXTERNAL + +;----------------------------------------------------------------------------- +; void ff_pred16x16_vertical_10_avx2(pixel *src, ptrdiff_t stride) +;----------------------------------------------------------------------------- +INIT_YMM avx2 +cglobal pred16x16_vertical_10, 2, 4 + sub r0, r1 + movu m0, [r0] ; Load all 16 pixels (32 bytes) from top row + mov r2d, 4 + lea r3, [r1*3] +.loop: + movu [r0+r1*1], m0 + movu [r0+r1*2], m0 + movu [r0+r3 ], m0 + lea r0, [r0+r1*2] + movu [r0+r1*2], m0 + lea r0, [r0+r1*2] + dec r2d + jg .loop + RET + +;----------------------------------------------------------------------------- +; void ff_pred16x16_horizontal_10_avx2(pixel *src, ptrdiff_t stride) +;----------------------------------------------------------------------------- +INIT_YMM avx2 +cglobal pred16x16_horizontal_10, 2, 4 + lea r2, [r1*3] + mov r3d, 4 +.loop: + vpbroadcastw m0, [r0-2] + movu [r0], m0 + vpbroadcastw m0, [r0+r1-2] + movu [r0+r1], m0 + vpbroadcastw m0, [r0+r1*2-2] + movu [r0+r1*2], m0 + vpbroadcastw m0, [r0+r2-2] + movu [r0+r2], m0 + lea r0, [r0+r1*4] + dec r3d + jg .loop + RET + +;----------------------------------------------------------------------------- +; void ff_pred16x16_dc_10_avx2(pixel *src, ptrdiff_t stride) +; DC = (sum of 16 top pixels + sum of 16 left pixels + 16) >> 5 +;----------------------------------------------------------------------------- +INIT_YMM avx2 +cglobal pred16x16_dc_10, 2, 6 + mov r5, r0 ; Save dest pointer + sub r0, r1 + movu m0, [r0] ; Load top row (32 bytes) + vextracti128 xm1, m0, 1 ; Get high 128 bits + paddw xm0, xm1 ; Sum to 8 words + phaddw xm0, xm0 ; 4 words + phaddw xm0, xm0 ; 2 words + phaddw xm0, xm0 ; 1 word (top sum in low word) + movd r3d, xm0 + and r3d, 0xFFFF ; Keep only low 16 bits + + ; Sum left column using lea-based pointer advancement + lea r0, [r0+r1-2] ; Point to left pixel of row 0 + movzx r4d, word [r0] + add r3d, r4d + movzx r4d, word [r0+r1] + add r3d, r4d +%rep 7 + lea r0, [r0+r1*2] + movzx r4d, word [r0] + add r3d, r4d + movzx r4d, word [r0+r1] + add r3d, r4d +%endrep + add r3d, 16 ; Rounding + shr r3d, 5 ; Divide by 32 + + movd xm0, r3d + vpbroadcastw m0, xm0 ; Broadcast to all 16 words + + ; Fill all 16 rows + mov r3d, 4 + lea r4, [r1*3] +.loop: + movu [r5+r1*0], m0 + movu [r5+r1*1], m0 + movu [r5+r1*2], m0 + movu [r5+r4 ], m0 + lea r5, [r5+r1*4] + dec r3d + jg .loop + RET + +;----------------------------------------------------------------------------- +; void ff_pred16x16_top_dc_10_avx2(pixel *src, ptrdiff_t stride) +; DC = (sum of 16 top pixels + 8) >> 4 +;----------------------------------------------------------------------------- +INIT_YMM avx2 +cglobal pred16x16_top_dc_10, 2, 4 + sub r0, r1 + movu m0, [r0] ; Load top row + vextracti128 xm1, m0, 1 + paddw xm0, xm1 + phaddw xm0, xm0 + phaddw xm0, xm0 + phaddw xm0, xm0 + paddw xm0, [pw_8] ; Add 8 for rounding + psrlw xm0, 4 ; Divide by 16 + vpbroadcastw m0, xm0 + + mov r2d, 4 + lea r3, [r1*3] +.loop: + movu [r0+r1*1], m0 + movu [r0+r1*2], m0 + movu [r0+r3 ], m0 + lea r0, [r0+r1*2] + movu [r0+r1*2], m0 + lea r0, [r0+r1*2] + dec r2d + jg .loop + RET + +;----------------------------------------------------------------------------- +; void ff_pred16x16_left_dc_10_avx2(pixel *src, ptrdiff_t stride) +; DC = (sum of 16 left pixels + 8) >> 4 +;----------------------------------------------------------------------------- +INIT_YMM avx2 +cglobal pred16x16_left_dc_10, 2, 5 + mov r4, r0 ; Save dest pointer + + ; Sum left column using lea-based pointer advancement + sub r0, 2 ; Point to left pixel of row 0 + movzx r2d, word [r0] + movzx r3d, word [r0+r1] +%rep 7 + lea r0, [r0+r1*2] + movzx eax, word [r0] + add r2d, eax + movzx eax, word [r0+r1] + add r3d, eax +%endrep + lea r2d, [r2+r3+8] ; Sum with rounding + shr r2d, 4 ; Divide by 16 + + movd xm0, r2d + vpbroadcastw m0, xm0 + + ; Fill all 16 rows + mov r2d, 4 + lea r3, [r1*3] +.loop: + movu [r4+r1*0], m0 + movu [r4+r1*1], m0 + movu [r4+r1*2], m0 + movu [r4+r3 ], m0 + lea r4, [r4+r1*4] + dec r2d + jg .loop + RET + +;----------------------------------------------------------------------------- +; void ff_pred16x16_128_dc_10_avx2(pixel *src, ptrdiff_t stride) +; Fill with constant 512 (1 << 9 for 10-bit midpoint) +;----------------------------------------------------------------------------- +INIT_YMM avx2 +cglobal pred16x16_128_dc_10, 2, 4 + vpbroadcastw m0, [pw_512] + mov r2d, 4 + lea r3, [r1*3] +.loop: + movu [r0+r1*0], m0 + movu [r0+r1*1], m0 + movu [r0+r1*2], m0 + movu [r0+r3 ], m0 + lea r0, [r0+r1*4] + dec r2d + jg .loop + RET + +%endif ; HAVE_AVX2_EXTERNAL diff --git a/libavcodec/x86/h264_intrapred_init.c b/libavcodec/x86/h264_intrapred_init.c index aa9bc721f0..6918c7f985 100644 --- a/libavcodec/x86/h264_intrapred_init.c +++ b/libavcodec/x86/h264_intrapred_init.c @@ -97,6 +97,12 @@ PRED16x16(128_dc, 10, sse2) PRED16x16(left_dc, 10, sse2) PRED16x16(vertical, 10, sse2) PRED16x16(horizontal, 10, sse2) +PRED16x16(dc, 10, avx2) +PRED16x16(top_dc, 10, avx2) +PRED16x16(128_dc, 10, avx2) +PRED16x16(left_dc, 10, avx2) +PRED16x16(vertical, 10, avx2) +PRED16x16(horizontal, 10, avx2) /* 8-bit versions */ PRED16x16(vertical, 8, sse) @@ -328,5 +334,13 @@ av_cold void ff_h264_pred_init_x86(H264PredContext *h, int codec_id, h->pred8x8l[VERT_RIGHT_PRED ] = ff_pred8x8l_vertical_right_10_avx; h->pred8x8l[HOR_UP_PRED ] = ff_pred8x8l_horizontal_up_10_avx; } + if (EXTERNAL_AVX2(cpu_flags)) { + h->pred16x16[DC_PRED8x8 ] = ff_pred16x16_dc_10_avx2; + h->pred16x16[TOP_DC_PRED8x8 ] = ff_pred16x16_top_dc_10_avx2; + h->pred16x16[DC_128_PRED8x8 ] = ff_pred16x16_128_dc_10_avx2; + h->pred16x16[LEFT_DC_PRED8x8 ] = ff_pred16x16_left_dc_10_avx2; + h->pred16x16[VERT_PRED8x8 ] = ff_pred16x16_vertical_10_avx2; + h->pred16x16[HOR_PRED8x8 ] = ff_pred16x16_horizontal_10_avx2; + } } } -- 2.51.0.windows.2 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org