From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D5E844DF6A for ; Thu, 8 Jan 2026 19:29:23 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'oxwymwDZOrPwqe/m4r1hlCldZ/xdol0i3SSYh3y9zeA=', expected b'Wbm31A/ARTBDamhkzCjWOrgm1G33NmZL6s6+aDrczyo=')) header.d=somaiya.edu header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767900554; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=NF6E67/wUvoaZKvnJkCJTeoYm+PiyDaOaPOm5h7pYeg=; b=huFcufhLtA7Xx/ZKuVKUdgD3QQ+wz0k+is0HJotiOSenG1wncYqo6OFwaiaCvUrww2Na1 EhKtV7c9++txbnu//6SJG9TAVollFJH7ApFiHrLDoQywunNl2pobuDYm7EktnHf63bURkZT RH99ZeU+oj+xCakSbknbr3jvw26zn7s/ghaO7U178mUx+mC0vDn7heFSDAxIo2QCEq3EFs4 4GTjvAtrERIIBTaUvLDA3gz7Vm6WItLvllJzVXg+RoWnKhjkIT2po9L4GwnhCNg55XyOckH bscFOPL+SIPNsgZLZus3lhTGJhMUmYp1gdSZ9ibBFsM/m++aTD4o+TRlfwbg== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5F3C9690DC9; Thu, 8 Jan 2026 21:29:14 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767900539; b=FvBbI32IhARaB/thDXLCUB1+RPUyw6w6Om4+zB4hxLGlXZTW8yyW8kSvDmmQiepHaoZXG a682rLI7vAgvjvnIlvC9X+0UkwVq10OJUZiC//lRRx0UGvoWk+PMS6sdcINqEDPB+JlRIfG wIIO421fOqZhKUX6W4r3kue+MRh+yiYVTwwP9uwAyEqcmu1aQu/11dlik/Jj7PoYlSdTfn3 DUpoebGqxnlnaaqQeXXAWgd86X0obRlZvKeH/zR2Fk2LkkNIIZwDh3AKXIAYTeZXoleAR+Y 8N3g+l6TXDIfhPtjQgBjeom43fbz2RqxoqWdOVS9e4S+p0Vr2Ee9WjEWsvtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767900539; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=oxwymwDZOrPwqe/m4r1hlCldZ/xdol0i3SSYh3y9zeA=; b=S7MJPz+eXjZLE/jcMgkTQMVtvi0G7mm8na9DN5I9Rw4e/zGGV+SLF+VGizMdSryEoSqNL 7tzXAo7viOlY0ELY4Fm7cBxGkLwnErxuizIt/cJh1Ps8mjtN/JlkW2EmX7rml3p9N+3zB2r QlqqZcpwsxCRbnuL+4XAnTs6o4ipbC4cHZvn6ggnUlAN4wAESddtic39MkNYeoZTq2cCSyw d3fTSrdEgP0L+l/BQ1N7ZLQDFD16ZKXKlGmkt8uTXtYdAzlvzt0ugGkKrNd0dqg23vmrWyq VyuiHIjZTlUY/e8D9rRvia2TEbnlIqJIcrd46xdxj1bqQguFotOZfiyk5fkA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=somaiya.edu; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=somaiya.edu; arc=none (Message is not ARC signed); dmarc=none Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B5046690BFE for ; Thu, 8 Jan 2026 21:28:46 +0200 (EET) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-34c71f462d2so3020687a91.0 for ; Thu, 08 Jan 2026 11:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=somaiya.edu; s=google; t=1767900524; x=1768505324; darn=ffmpeg.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Wbm31A/ARTBDamhkzCjWOrgm1G33NmZL6s6+aDrczyo=; b=SE3xoXdqSyKlJvkb+qM6/dwuxmd22Sx07+XCpgTB2wec5U2ptVAqej86pih7N9Ojbg OgkE9XU6RiY6FtmKWDhAiKMHQY+SGhtNsFG/WUGvlZY+OgbS9rZwr+wSPS7OouOP7VZq 8htWSLk4Ji7y4QYT/kqwW5YFM1DuSNigF4qD4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767900524; x=1768505324; h=mime-version:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wbm31A/ARTBDamhkzCjWOrgm1G33NmZL6s6+aDrczyo=; b=a5NcwcVi9J1dWfaXopzQvbNeRR5tTssniHcfGmDF1bNi8iaTZcpYxEM+AnwFXinxoI bq4SAyoQplX3Qb2lDjTpDYhEgdoWgBFeL2r/EtKGooO2m8fxO0GginyYUm+7fUx5g6o4 4O2EeMBSOZag/JkBZ/FrE7e6Dm7ba+FsF/vGFh155D2so+VTe1r4JvK2OiGBArDv3DEn rwHRXbKHfeyP4VGHSvJ+BMhr0YYjJeHERNleoKpwKz0gMu8OvAU8avatCaBGllEqWueB 6AFuRSSUKLnQ3ZhJrlpZQkeoft3W75657kQ0zXG7xcTe+LecCMGV/yCPPjsgqRzCN424 NXvg== X-Gm-Message-State: AOJu0YzfOHwez7/uqsdY5zGWRwasNrhzA5YcGWn4LdnPdo31XPGwqWLj jZ2b8jpnn4pOhw7dkXUcGbvqr43wereQE6Gk2cGL3Jc4yTDF+hCJhNcUhdNeP48JQdrOPEm2zlI 6p839kxveqdgnwP80I9nTqcdoym3ShsqewZw4T/uAh6QPtmxmAb748ynh0JkzoKep6yn3 X-Gm-Gg: AY/fxX4ZjE4T0nuP/1ajoLFYDw9E65EYQ81qF5d5Eqg4s03ebJ8RQ+G7vUfAQv9Uhef NqxA13wyL/+QgrC55Yql82Z6H4V80DBD7zyX8zzslZIX613zVAENXUvnxOOQaKFk5DHetEprbhI UOXCooSUHriV3VguHk/XI4Pxvrk7q5+TdC1JVesJqD7UJfXbRSB4I3DiKOPz+prt6lPhlf8VjP8 W3nH8IAj7xcXwz/jN7Tr5LXlgq+Z/lm0+KIZ8pnxLlhPKPrnlCLH2YWka6gs5f5rv0Jgt9QLf7a so49qJ0tfskNBbMdUP3jS4rcbcRHp4G45aTuTbyP6JnBy3pbEd5Mo2KGDivha9rMxXQBb8QFLt1 yNQX6BZCP/jbt2i0UJPt2VSVnhPLZbGHNjvrTZUGQuW6LeqxXpwDFv1ev5wQtFzMsRHxgae5jCl zY1TeByMffFK92pn3I0J8k8rBrh/orKb04P7FPEyI= X-Google-Smtp-Source: AGHT+IHk0Mwn3mOcSW7fYoh2kufOUHpRJR06jjw+kwBdgcxbyBu9TCzS/Wj2wb4dynehXG5baieMow== X-Received: by 2002:a17:90b:3c82:b0:33e:1acc:1799 with SMTP id 98e67ed59e1d1-34f68c92edamr6860198a91.14.1767900524383; Thu, 08 Jan 2026 11:28:44 -0800 (PST) Received: from localhost.localdomain ([103.69.113.195]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f6b92121fsm2075733a91.8.2026.01.08.11.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 11:28:43 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Fri, 9 Jan 2026 00:58:28 +0530 Message-ID: <20260108192828.1751-1-vivek.kj@somaiya.edu> X-Mailer: git-send-email 2.49.0.windows.1 MIME-Version: 1.0 Message-ID-Hash: CQGJTVUP3HKXZ6DHJSIKHI4QIT7YGMXI X-Message-ID-Hash: CQGJTVUP3HKXZ6DHJSIKHI4QIT7YGMXI X-MailFrom: SRS0=F4lZ=7N=somaiya.edu=vivek.kj@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx timestamp handling, use PTS instead of DTS List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Vivek Jain via ffmpeg-devel Cc: vivek.kj@somaiya.edu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: The 'sidx' earliest_presentation_time field is defined as PTS. Previously, it was incorrectly assigned to DTS, which could cause sync issues. This commit fixes the assignment to PTS as noted in the existing FIXME comment, which is now resolved and removed. --- libavformat/mov.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index f651d0387b..257ea74d5f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -5890,11 +5890,9 @@ static int mov_read_trun(MOVContext *c, AVIOContext *pb, MOVAtom atom) av_log(c->fc, AV_LOG_DEBUG, "found tfdt time %"PRId64 ", using it for dts\n", dts); } else if (has_sidx && !c->use_tfdt || fallback_sidx) { - // FIXME: sidx earliest_presentation_time is *PTS*, s.b. - // pts = frag_stream_info->sidx_pts; - pts = frag_stream_info->sidx_pts; // <--- FIXED + pts = frag_stream_info->sidx_pts; av_log(c->fc, AV_LOG_DEBUG, "found sidx time %"PRId64 - ", using it for pts\n", frag_stream_info->sidx_pts); // Update log message too if you like, but logically just changing to pts is the key. + ", using it for pts\n", frag_stream_info->sidx_pts); } else { dts = sc->track_end - sc->time_offset; av_log(c->fc, AV_LOG_DEBUG, "found track end time %"PRId64 -- 2.49.0.windows.1 -- Disclaimer This email is governed by the Disclaimer Terms of somaiya.edu which may be viewed at https://www.somaiya.edu/en/email-disclaimer Finally, please do not print this email unless it is necessary. Every unprinted email helps the environment. _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org