From: 0xBat via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: 0xBat <monsterbat02@gmail.com>
Subject: [FFmpeg-devel] [PATCH] avcodec/qdm2: check packet size before bitstream initialization
Date: Mon, 5 Jan 2026 01:35:02 +0100
Message-ID: <20260105003504.1895-3-monsterbat02@gmail.com> (raw)
In-Reply-To: <20260105003504.1895-1-monsterbat02@gmail.com>
Prevent integer overflow in init_get_bits by validating that packet size multiplied by 8 does not exceed INT_MAX.
Signed-off-by: 0xBat <monsterbat02@gmail.com>
---
libavcodec/qdm2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c
index b2136c6824..2eb1f3be99 100644
--- a/libavcodec/qdm2.c
+++ b/libavcodec/qdm2.c
@@ -978,6 +978,8 @@ static int process_subpacket_9(QDM2Context *q, QDM2SubPNode *node)
GetBitContext gb;
int i, j, k, n, ch, run, level, diff;
+ if (node->packet->size > INT_MAX / 8)
+ return AVERROR_INVALIDDATA;
init_get_bits(&gb, node->packet->data, node->packet->size * 8);
n = coeff_per_sb_for_avg[q->coeff_per_sb_select][QDM2_SB_USED(q->sub_sampling) - 1] + 1;
--
2.52.0.windows.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
next prev parent reply other threads:[~2026-01-06 2:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 0:35 [FFmpeg-devel] [PATCH] avcodec/dxv: fix index validation against texture size 0xBat via ffmpeg-devel
2026-01-05 0:35 ` [FFmpeg-devel] [PATCH] avcodec/eatqi: clamp quantizer value to prevent underflow 0xBat via ffmpeg-devel
2026-01-05 0:35 ` 0xBat via ffmpeg-devel [this message]
2026-01-09 2:11 ` [FFmpeg-devel] Re: [PATCH] avcodec/qdm2: check packet size before bitstream initialization Michael Niedermayer via ffmpeg-devel
2026-01-05 0:35 ` [FFmpeg-devel] [PATCH] compat/android: fix DLL hijacking by using absolute paths 0xBat via ffmpeg-devel
2026-01-08 3:20 ` [FFmpeg-devel] Re: [PATCH] avcodec/dxv: fix index validation against texture size Michael Niedermayer via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105003504.1895-3-monsterbat02@gmail.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=monsterbat02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git