From: 0xBat via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: 0xBat <monsterbat02@gmail.com>
Subject: [FFmpeg-devel] [PATCH] avcodec/dxv: fix index validation against texture size
Date: Mon, 5 Jan 2026 01:35:00 +0100
Message-ID: <20260105003504.1895-1-monsterbat02@gmail.com> (raw)
Validate the calculated index against both the current position and the total texture size to prevent out-of-bounds memory access.
Signed-off-by: 0xBat <monsterbat02@gmail.com>
---
libavcodec/dxv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c
index 07eee253e7..8d11dfe1a1 100644
--- a/libavcodec/dxv.c
+++ b/libavcodec/dxv.c
@@ -72,8 +72,8 @@ typedef struct DXVContext {
idx = x; \
break; \
case 2: \
- idx = (bytestream2_get_byte(gbc) + 2) * x; \
- if (idx > pos) { \
+ idx = (bytestream2_get_byte(gbc) + 2) * x;
+ if (idx > pos || idx > ctx->tex_size) { \
av_log(avctx, AV_LOG_ERROR, "idx %d > %d\n", idx, pos); \
return AVERROR_INVALIDDATA; \
} \
--
2.52.0.windows.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
next reply other threads:[~2026-01-06 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 0:35 0xBat via ffmpeg-devel [this message]
2026-01-05 0:35 ` [FFmpeg-devel] [PATCH] avcodec/eatqi: clamp quantizer value to prevent underflow 0xBat via ffmpeg-devel
2026-01-05 0:35 ` [FFmpeg-devel] [PATCH] avcodec/qdm2: check packet size before bitstream initialization 0xBat via ffmpeg-devel
2026-01-09 2:11 ` [FFmpeg-devel] " Michael Niedermayer via ffmpeg-devel
2026-01-05 0:35 ` [FFmpeg-devel] [PATCH] compat/android: fix DLL hijacking by using absolute paths 0xBat via ffmpeg-devel
2026-01-08 3:20 ` [FFmpeg-devel] Re: [PATCH] avcodec/dxv: fix index validation against texture size Michael Niedermayer via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105003504.1895-1-monsterbat02@gmail.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=monsterbat02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git