From: 0xBat via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: 0xBat <monsterbat02@gmail.com>
Subject: [FFmpeg-devel] [PATCH] avcodec/vvc: validate reference picture list indices
Date: Mon, 5 Jan 2026 01:16:30 +0100
Message-ID: <20260105001630.1738-3-monsterbat02@gmail.com> (raw)
In-Reply-To: <20260105001630.1738-1-monsterbat02@gmail.com>
The function derive_mmvd in libavcodec/vvc/ctu.c used reference indices without validating them against the RPL size. This patch adds checks to prevent out-of-bounds memory access.
Signed-off-by: 0xBat <monsterbat02@gmail.com>
---
libavcodec/vvc/ctu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c
index 18cbe0fe0f..8e4f003886 100644
--- a/libavcodec/vvc/ctu.c
+++ b/libavcodec/vvc/ctu.c
@@ -1287,6 +1287,8 @@ static void derive_mmvd(const VVCLocalContext *lc, MvField *mvf, const Mv *mmvd_
if (mvf->pred_flag == PF_BI) {
const RefPicList *rpl = sc->rpl;
const int poc = lc->fc->ps.ph.poc;
+ if (mvf->ref_idx[L0] >= rpl[L0].nb_refs || mvf->ref_idx[L1] >= rpl[L1].nb_refs)
+ return;
const int diff[] = {
poc - rpl[L0].refs[mvf->ref_idx[L0]].poc,
poc - rpl[L1].refs[mvf->ref_idx[L1]].poc
--
2.52.0.windows.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
next prev parent reply other threads:[~2026-01-06 2:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 0:16 [FFmpeg-devel] [PATCH] avcodec/vvc: add boundary checks for CTU table access 0xBat via ffmpeg-devel
2026-01-05 0:16 ` [FFmpeg-devel] [PATCH] avcodec/vvc: clamp palette predictor size 0xBat via ffmpeg-devel
2026-01-05 0:16 ` 0xBat via ffmpeg-devel [this message]
2026-01-06 7:58 ` [FFmpeg-devel] Re: [PATCH] avcodec/vvc: validate reference picture list indices Christophe Gisquet via ffmpeg-devel
2026-01-06 8:47 ` Frank Plowman via ffmpeg-devel
2026-01-06 8:01 ` [FFmpeg-devel] Re: [PATCH] avcodec/vvc: add boundary checks for CTU table access Christophe Gisquet via ffmpeg-devel
2026-01-06 19:35 ` Christophe Gisquet via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105001630.1738-3-monsterbat02@gmail.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=monsterbat02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git