From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B6ECF4BD2A for ; Thu, 1 Jan 2026 06:41:48 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'5PofJtdJXDLMaSMzzVebb0Myk8hCTzQj80kqUvx7RTM=', expected b'PRPuzUj6EIkSiknYcA2imRgpabALol2Ju+Kli/Lz/ks=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767249693; h=to : date : message-id : in-reply-to : references : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=PPvdxVCvjyMRIZnnOX8idE4LvlU4yY2gUrWRXLCJ4EM=; b=ZdOjw6pjUf50zE2OXtYpd/hePosJhzUbLHxgy/dl5WYAlnH7+QmnLWAdqd2rUjGczuU9j fkLdkjhaUAMmRefe1ikPJkMdoHzxqIMISxXPS0Aa1fzaewVJnr0NKZTQvQOkGcQMZCupK4/ rAcdCx5zXuwqqAF/soXuEHtLgJWC/tL9sKyie7KXL3JUHB7PGG8MVlDX7LWSSFW0Eo3bGXo WHYFA6MBVjxZQw9xhyFLwVAUnKDO0B2OdpsAcH5A9iA3Xp8Wy7FWdfjIpN1vIyUzQdOLEg8 WUU/f3/1IvvyopNN6FzPPRY2B+7hg+lAcgce9c3fl/6q4ohk2pwVYRdghTHw== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 17F58690D3F; Thu, 1 Jan 2026 08:41:33 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767249668; b=BRPjMT86l+TW2K7Xn35VvA5amsOnWpxWtaVnmrKpbByn6r/sfRINUQJNKD8VWmO/qAHLb arB+QXo98PP+/XUxStyfIOxVDlx7T8lietCbZKEdPIH1s/C8kv8TNZ9fr9R6SC8zKjNg48g snwOQH2CZ7ne4hpODTR/K521IGQ8Xw7IslF5K2ieIoS+Sp7hq/zmELjxZE/rfS8CuEiYvdU luet2uGE0UBUvUy0adf8VNCqNk1+5HQ1cIGV0H6Ez4baz1eUWnuBW11KA97IsSGpiT3Pcpv 2TPnk8BLL2LG3MLzwuAuFkejauOItcjagjfKhIpRSmNLxKSsIjT3PfU779hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767249668; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=5PofJtdJXDLMaSMzzVebb0Myk8hCTzQj80kqUvx7RTM=; b=FLT0HG2TRk0pTmj2fRYTTNWll7XTOeZ6qUQjVkJwyYgbipUj4b54QE4z+Ylx0SFcj6Am1 jDehQhDW6To2iIcIb6ba/lFtscNdbb+Jrcv6AkCAfOmRfcDYi27GcpDLqiaSuPENf7sdpcK BkbU3RdRSbTa4UNgMCuJh4xgnh8PLBVYC8l5VSjbx9eetA61EgeaKvRz8O0OLCCWeKc5Qqd WYNUa2RLQd4alv47sz5ihiTei/NTHkS4HlOT+LpHf9SaPfdbeirkYa8PIFSnY4tcUocBmaI kuERjkAQUuIAtAUxxfwdtA0rYyromF+flt4KPNC3cJxwt04+EBHVtWvYabkQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 92B0D690BFE for ; Thu, 1 Jan 2026 08:40:55 +0200 (EET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-34c84dc332cso10039353a91.0 for ; Wed, 31 Dec 2025 22:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767249653; x=1767854453; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PRPuzUj6EIkSiknYcA2imRgpabALol2Ju+Kli/Lz/ks=; b=RwRTh8cYzfo8wxR4o0usATP++Ur7k6iL8Ze6iXgJKzODEQgKawm3Xj3Av7BZnvc8mF kMxHInQQDcerT2FD+vVsrQye9Ng/G396mMHIPTdG1FVChTzM62tfWzjP+fLd615ks8w+ P6hg6Zn1fDfXasP3G6jgQzestsDDaSa84JHjvkRmh/Dl9/uhHXz+w1FHicABf7VbwTcf AO5C9AqhfmvQkRZtrkCGaDBOVOjPnAwzKyHIVYftnPwsNw0d2WJEVOXG69qZSbrsZv9m +ZJDBETBHYGDZZpI9ni0tKT6fJOojQNURjwb2LaHyLvH8/gM9ROAA/FJyCH2WDdBgNVG F0Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767249653; x=1767854453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PRPuzUj6EIkSiknYcA2imRgpabALol2Ju+Kli/Lz/ks=; b=e3bbke+R41d3KLMbPtdWnEqtP0M69hg7FgGVT3/XL7hBSoZ05j70EKP1nCHdeduGnc sFf5BDHVtCZCEX8hKcts+sWk70K68kJQERvnfHXGAskkIEJYm8/pf7pyk7jdGdGWxCsd bSbT2n4pYdxzCqZRtjYtAJLVlGxWCpIudhXTUOJXpWPLhrJicXxZjA1jWxsSm1gUMlPr Ni8BXnLGGKOXeVrLwcrxrl77nGcCwxxI0ogqtMQvvA/zvuzocMjg4r3CeQqbhY8TaKrQ oeJFxFKSKuQ7IoUFAA0Bjm/ahWcUx7yqBXCm2OVl0/x1tiEk7d9QVHQF5ockk85w/Pqx BRPw== X-Gm-Message-State: AOJu0YwCZmy3uMjz1HeQgJg19F1zqSIOg6gRVFrfJUi2c0hFnLmpN3g9 WbmP4oFmD1s5nWb2hVGvyMBkTGiG/Qmcq53ZB8O6S600hCcMwpBosdbCCmN2zA== X-Gm-Gg: AY/fxX7qIrtKfnWawKriQycKoh2fPhW7AYtCglN4UAua35Vfa4JNjnZPE6bTFy40zbx Og2a+CcMW2CgEZt/XtztbIEQ6Kex92o+NMZof6gHqGbgM8Y+vVqB2w+9QgB+HGl7Zb47Zz92kXO UJjoPRLWC0rAsas+WByIVcMuXgHRYuVbvwJYjljpVJ5cKXaexOcbYqQqK86M0dqFnAB4LpewBI7 iSe821UrOk1lR1mlE3a+Hvpt021rtn3DsYMZrzzZJxYFKmyp7pd1TErT6slTXbqSAWN220F6U0H g8tzEc8wHIpuvIixI0hHQ5qLNr8gmssU/N77GlDctVdEcf2GeRnRy1FTM12PE0cLfydhiRLxk1p ozoE8ixfygIHPo/N1W3pIWSDwv96Xlx4Vx9qWSalpyWaghLFSqi9f0N6t+KKgZ24YTWPxc+ZxiG sxwFQ89jX7kqTPyF0RzvWsfxnMCMZOuRHHyay4laIx X-Google-Smtp-Source: AGHT+IFFATOZKol4Dova9eAwYvcKgDup+yykqydp51LnDeiiviurd9+l21PP4/7IoYnn9nD00IvK1A== X-Received: by 2002:a17:90b:2d8c:b0:341:8b2b:43c with SMTP id 98e67ed59e1d1-34e921a450amr31054748a91.18.1767249652975; Wed, 31 Dec 2025 22:40:52 -0800 (PST) Received: from Raja-Rathour-ASUS-TUF-Gaming-A15.. ([103.227.71.253]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff77abe95dsm37054077b3a.0.2025.12.31.22.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 22:40:52 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Thu, 1 Jan 2026 12:09:19 +0530 Message-ID: <20260101064038.17335-1-imraja729@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Message-ID-Hash: TBANYZEGSFQRRKFGUAVN4E7OGJPGW64S X-Message-ID-Hash: TBANYZEGSFQRRKFGUAVN4E7OGJPGW64S X-MailFrom: SRS0=om1i=7G=gmail.com=imraja729@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH v8] avfilter/vf_blackframe: add slice threading List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Raja Rathour via ffmpeg-devel Cc: Raja Rathour Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: v8: Restored original struct comments (unrelated to threads) and updated height comment to Doxygen style (///<) as requested. Thank you for the detailed feedback on the patch structure and project style. Signed-off-by: Raja Rathour --- libavfilter/vf_blackframe.c | 69 ++++++++++++++++++++++++++++++++----- 1 file changed, 60 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_blackframe.c b/libavfilter/vf_blackframe.c index f0aa53e133..5b198e6594 100644 --- a/libavfilter/vf_blackframe.c +++ b/libavfilter/vf_blackframe.c @@ -32,6 +32,7 @@ #include "libavutil/internal.h" #include "libavutil/opt.h" +#include "libavutil/mem.h" #include "avfilter.h" #include "filters.h" #include "video.h" @@ -45,6 +46,15 @@ typedef struct BlackFrameContext { unsigned int last_keyframe; ///< frame number of the last received key-frame } BlackFrameContext; +typedef struct ThreadData { + const uint8_t *data; + int linesize; + int bthresh; + int width; + int height; ///< height for cleaner slice math + unsigned int *counts; +} ThreadData; + static const enum AVPixelFormat pix_fmts[] = { AV_PIX_FMT_YUV410P, AV_PIX_FMT_YUV420P, AV_PIX_FMT_GRAY8, AV_PIX_FMT_NV12, AV_PIX_FMT_NV21, AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV411P, @@ -55,22 +65,60 @@ static const enum AVPixelFormat pix_fmts[] = { snprintf(buf, sizeof(buf), format, value); \ av_dict_set(metadata, key, buf, 0) +static int blackframe_slice(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs) +{ + ThreadData *td = arg; + int slice_start = (td->height * jobnr) / nb_jobs; + int slice_end = (td->height * (jobnr+1)) / nb_jobs; + int x, y; + const uint8_t *p; + unsigned int black_pixels_count = 0; + + p = td->data + slice_start * td->linesize; + + for (y = slice_start; y < slice_end; y++) { + for (x = 0; x < td->width; x++) + black_pixels_count += p[x] < td->bthresh; + p += td->linesize; + } + + td->counts[jobnr] = black_pixels_count; + return 0; +} + static int filter_frame(AVFilterLink *inlink, AVFrame *frame) { AVFilterContext *ctx = inlink->dst; BlackFrameContext *s = ctx->priv; - int x, i; int pblack = 0; - uint8_t *p = frame->data[0]; AVDictionary **metadata; char buf[32]; + ThreadData td; + int nb_threads, nb_jobs, i; + unsigned int *nb_black_pixels_per_slice; + + nb_threads = ff_filter_get_nb_threads(ctx); + + nb_black_pixels_per_slice = av_calloc(nb_threads, sizeof(*nb_black_pixels_per_slice)); + if (!nb_black_pixels_per_slice) + return AVERROR(ENOMEM); + + td.data = frame->data[0]; + td.linesize = frame->linesize[0]; + td.width = inlink->w; + td.height = inlink->h; + td.bthresh = s->bthresh; + td.counts = nb_black_pixels_per_slice; + + nb_jobs = FFMIN(td.height, nb_threads); + + ff_filter_execute(ctx, blackframe_slice, &td, NULL, nb_jobs); - for (i = 0; i < frame->height; i++) { - for (x = 0; x < inlink->w; x++) - s->nblack += p[x] < s->bthresh; - p += frame->linesize[0]; + s->nblack = 0; + for (i = 0; i < nb_jobs; i++) { + s->nblack += nb_black_pixels_per_slice[i]; } - + if (frame->flags & AV_FRAME_FLAG_KEY) s->last_keyframe = s->frame; @@ -89,6 +137,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) s->frame++; s->nblack = 0; + + av_free(nb_black_pixels_per_slice); + return ff_filter_frame(inlink->dst->outputs[0], frame); } @@ -118,9 +169,9 @@ const FFFilter ff_vf_blackframe = { .p.name = "blackframe", .p.description = NULL_IF_CONFIG_SMALL("Detect frames that are (almost) black."), .p.priv_class = &blackframe_class, - .p.flags = AVFILTER_FLAG_METADATA_ONLY, + .p.flags = AVFILTER_FLAG_METADATA_ONLY | AVFILTER_FLAG_SLICE_THREADS, .priv_size = sizeof(BlackFrameContext), FILTER_INPUTS(avfilter_vf_blackframe_inputs), FILTER_OUTPUTS(ff_video_default_filterpad), FILTER_PIXFMTS_ARRAY(pix_fmts), -}; +}; \ No newline at end of file -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org