From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9AF5A4D7E7 for ; Tue, 30 Dec 2025 19:43:18 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'elT7Dlg72sz7eCU66kq8uSIo/fs/jqs4Hd8GFuP7K5w=', expected b'eQx3kGizxR9qaByApV0rQt6zKRETcuzM7AUL+VXff74=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767123789; h=to : date : message-id : in-reply-to : references : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=mSqJXYQf/E4KMvGRTixBWPj+8EpK0SN/JFobcuL18c0=; b=1lP1AsjmnoNu7eW6dnBLcE88+x6AsU2P1LPUB/KGtxwWu/sBAWKSPxGKpXr9rLr6nPyhP cEYwvvB9d+l01lwjLsXYYwJKT3UM83PoR2A5m0s167Y4weWNgGETsUDY+BMVJkvF4r+zYjS Y6aVP0TnsymUWSzsRi2Xefw/Lrip0Jtwwxee0BySsThRJrjcPNi0Q2LhgUj7wceosp7CHNy twO1PBYR2cmOxqKYceZjcUBeBLSVUUuFvWLauj1aynzZCBNOtJee9py2Q9cksiMVYVSEAR5 C3/gNs11zWqbuQsLQqShK7u40/fAJFi98Zu4JsWZ6/5u+NDp3nWR98FHnSNg== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 95B15690C72; Tue, 30 Dec 2025 21:43:09 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767123774; b=OPSCC1QuikPE2k2RnFqErVw/KLwj0xoNUiByei9iUFLtY1N6POZu81M0UzleHhjeg0eo9 EbsdRIzF93qOB9JtgfWuGSGxtAdov+wrcENmzBDGWI4tzTLgELhjgM2ySf0n+YijzWY85y5 ECtTdqsOFDEpA82Qa7D2cldgFhh/n3VDHlF983qEU9MGzv3mWthin2u/9P2OOYZwDWPRtvZ HPkNnzmkQEY5oy+FUf4XvWAFO4A9Tu+JRV19mLCGFlvAtmUTprQluc3kkcIWFUU3hyE2L8V k98Hsf8+XThhUWz7yHq2zCnICJWV9zruF70LXGW7fz4UX61JtxoY4ma3Oxeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767123774; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=elT7Dlg72sz7eCU66kq8uSIo/fs/jqs4Hd8GFuP7K5w=; b=AuSmLutsP/zJP/tVVVzzUZRToOO4ley1iDBUf4ttaUhhRkLHyvNP0xlJ3r+5V8cseLL30 vfjK3K2AtK3F0DzdyquXc7uDI14wPG6fm9sssNJ1nAGTYdNPJCWC8TAEdAUg2ZY8ndCcWDw gdBIrjnqXY2Fy4PgkKEQGGahD4bmYNSHbX1jFB30V2yS+becF5/A4qxIkFPOtQhDaVwJ07/ 25zBQNjHMtlnqv01IgW2wopj2DRY4EZSa9Vu/gBZmyHzEhwanfdjE66lARWfE4T5xDeW6Qc 264XajzKLDqzKdlB+Ul0OkKhddQNuSlxqyNMVKO8/OQDQRg1nT/ZsEoKN/5A== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id BC644690B58 for ; Tue, 30 Dec 2025 21:42:41 +0200 (EET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a110548cdeso141504765ad.0 for ; Tue, 30 Dec 2025 11:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767123759; x=1767728559; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eQx3kGizxR9qaByApV0rQt6zKRETcuzM7AUL+VXff74=; b=feTR9FpE0hzEsGnBnSOkGN4N/FlaeU1pff0EgN+sactjeHM1KeNmM1HB0xe6a6uRBo Suz0KSx4Oq+qlGqUDGbVTmR9BWel0PLE/qfPT7wyqApju95gb9TEyfk74mZ+6/5W0BAJ R0EdmMYpESZUvzvp4H2x4LQGTRAcNz2swNVuiXK/bnymP9rit3lCDnM8ei8izrhiKh0z VcS4aqibHxG+TqDMNuqC2oU0PJCI3ZzSj6NqPMRg8D3nnWMqUuWbcBScAxRUbk/ytytA wk7qad+HGYVZYYGiliPjch/+v+sslfjB700us6wC08cbpTGQAkN5kaMVeGu/JKbpWPQf xhHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767123759; x=1767728559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eQx3kGizxR9qaByApV0rQt6zKRETcuzM7AUL+VXff74=; b=kH+boCtYTPjxvDV09M950B2t+H1qkZsPG+r/5NpffKzG0q892qiInbCVdaThgWCUGK sWGR+7RWDQl2zXWebgLYsBi7fwvlCDmsWS6pUm8V39gtw5lVK8xsNMILs1E4BS2tWtxf 9SaI+sW+JCcLQpfHyal4cda9OvISUmKU3gplA/g648Ce6K1z4LZfypJU6aD9us/+Vr4X W/Ot42q0q4u/NTQTUG74bJ7q975cvFgWm+u2xEpYKeXeFAlevpGnbsrTR53o7b2wjGMD JaR814ytjp2NkMzCrZEt/13WN9kqr85VhdApn20FX17vb2NzUS4Sy335+Q2GuYqICMeD 9C8g== X-Gm-Message-State: AOJu0YxeJg9RQTYvfHZF7VGDm+ofsVwVpezjF2cALghLPk1pKzXAjFN+ TmWG4aE93vNBXhV8vlRvWIVV32xnAyIz2ZrxWL9AO4Bv2zCKeyQ53NFNofwqIw== X-Gm-Gg: AY/fxX432Ur30t3GepJxMylCCMFW9LHSuLtqzKJ91tSiJYAsKfK7wQo/N1mV8q1vMYR Sk+rnl63okwb838pB9qwzU4P5gr4H281V4ibfFp6MO7FfgTqlg6F5vTQ4JODnskP7RPHLecJlQj u14LCkgjkY9Lwy7RUFjiaVNOOOoRoVjwFsl9Adr80edcWPPtY7UWXvFnnGkLiOe99Y6X2K5NL28 ilJH8MagiowsiZL5alh1Tthu8LSgw4rZ1e+kSxYfa4XWJOCmIxEiPL9u9+gwf+Hm64Gqn86oUhq v077EdoCY/Leq9IDuObAfzQysqSKvWt1boDXxjO/DHlZi1nRtwUVIak4g8sD0uuQhhBWuKKp650 OMlQHp4xVqLZ1LPXZEQsvWAqkiLbOGXwl/BlNNa7g9pHLu7YQcw7rq1QELvOmV+Woz6mQOdiRZ5 Hs2kkjLAyIvS1vDAO641QI5yM6838Fd7YjZUbgS9CV X-Google-Smtp-Source: AGHT+IFqGIqDYomnMU38jHw4yYFBRpExqli83cYtTR8+onL6yWIErCBhvPBT8nU4RRowy2P6hXtKUw== X-Received: by 2002:a17:903:40cb:b0:29e:facd:7c02 with SMTP id d9443c01a7336-2a2f2830ff4mr315264575ad.28.1767123759429; Tue, 30 Dec 2025 11:42:39 -0800 (PST) Received: from Raja-Rathour-ASUS-TUF-Gaming-A15.. ([150.242.72.109]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c8a8e3sm302881195ad.41.2025.12.30.11.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 11:42:39 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Wed, 31 Dec 2025 01:10:18 +0530 Message-ID: <20251230194223.11867-1-imraja729@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Message-ID-Hash: XVA4T4MCZZMK5AFYFAZAC5PWDXS3NKYY X-Message-ID-Hash: XVA4T4MCZZMK5AFYFAZAC5PWDXS3NKYY X-MailFrom: SRS0=cf/C=7E=gmail.com=imraja729@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH v7] avfilter/vf_blackframe: add slice threading List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Raja Rathour via ffmpeg-devel Cc: Raja Rathour Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: v7: Squashed all changes into a single clean commit rebased on master. Thank you for the guidance on the patch structure and history. This version is a standalone replacement of the original filter logic and incorporates all requested technical improvements: - Renamed the results array to 'nb_black_pixels_per_slice' for clarity. - Removed redundant comments and safety checks. - Fixed the patchset structure to ensure it applies cleanly as a single unit. Thank you, Raja Rathour Signed-off-by: Raja Rathour --- libavfilter/vf_blackframe.c | 79 ++++++++++++++++++++++++++++++------- 1 file changed, 65 insertions(+), 14 deletions(-) diff --git a/libavfilter/vf_blackframe.c b/libavfilter/vf_blackframe.c index f0aa53e133..fb531b8a4c 100644 --- a/libavfilter/vf_blackframe.c +++ b/libavfilter/vf_blackframe.c @@ -32,19 +32,29 @@ #include "libavutil/internal.h" #include "libavutil/opt.h" +#include "libavutil/mem.h" #include "avfilter.h" #include "filters.h" #include "video.h" typedef struct BlackFrameContext { const AVClass *class; - int bamount; ///< black amount - int bthresh; ///< black threshold - unsigned int frame; ///< frame number - unsigned int nblack; ///< number of black pixels counted so far - unsigned int last_keyframe; ///< frame number of the last received key-frame + int bamount; + int bthresh; + unsigned int frame; + unsigned int nblack; + unsigned int last_keyframe; } BlackFrameContext; +typedef struct ThreadData { + const uint8_t *data; + int linesize; + int bthresh; + int width; + int height; // Added height for cleaner slice math + unsigned int *counts; +} ThreadData; + static const enum AVPixelFormat pix_fmts[] = { AV_PIX_FMT_YUV410P, AV_PIX_FMT_YUV420P, AV_PIX_FMT_GRAY8, AV_PIX_FMT_NV12, AV_PIX_FMT_NV21, AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV411P, @@ -55,22 +65,60 @@ static const enum AVPixelFormat pix_fmts[] = { snprintf(buf, sizeof(buf), format, value); \ av_dict_set(metadata, key, buf, 0) +static int blackframe_slice(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs) +{ + ThreadData *td = arg; + int slice_start = (td->height * jobnr) / nb_jobs; + int slice_end = (td->height * (jobnr+1)) / nb_jobs; + int x, y; + const uint8_t *p; + unsigned int black_pixels_count = 0; + + p = td->data + slice_start * td->linesize; + + for (y = slice_start; y < slice_end; y++) { + for (x = 0; x < td->width; x++) + black_pixels_count += p[x] < td->bthresh; + p += td->linesize; + } + + td->counts[jobnr] = black_pixels_count; + return 0; +} + static int filter_frame(AVFilterLink *inlink, AVFrame *frame) { AVFilterContext *ctx = inlink->dst; BlackFrameContext *s = ctx->priv; - int x, i; int pblack = 0; - uint8_t *p = frame->data[0]; AVDictionary **metadata; char buf[32]; + ThreadData td; + int nb_threads, nb_jobs, i; + unsigned int *nb_black_pixels_per_slice; + + nb_threads = ff_filter_get_nb_threads(ctx); + + nb_black_pixels_per_slice = av_calloc(nb_threads, sizeof(*nb_black_pixels_per_slice)); + if (!nb_black_pixels_per_slice) + return AVERROR(ENOMEM); + + td.data = frame->data[0]; + td.linesize = frame->linesize[0]; + td.width = inlink->w; + td.height = inlink->h; + td.bthresh = s->bthresh; + td.counts = nb_black_pixels_per_slice; + + nb_jobs = FFMIN(td.height, nb_threads); + + ff_filter_execute(ctx, blackframe_slice, &td, NULL, nb_jobs); - for (i = 0; i < frame->height; i++) { - for (x = 0; x < inlink->w; x++) - s->nblack += p[x] < s->bthresh; - p += frame->linesize[0]; + s->nblack = 0; + for (i = 0; i < nb_jobs; i++) { + s->nblack += nb_black_pixels_per_slice[i]; } - + if (frame->flags & AV_FRAME_FLAG_KEY) s->last_keyframe = s->frame; @@ -89,6 +137,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) s->frame++; s->nblack = 0; + + av_free(nb_black_pixels_per_slice); + return ff_filter_frame(inlink->dst->outputs[0], frame); } @@ -118,9 +169,9 @@ const FFFilter ff_vf_blackframe = { .p.name = "blackframe", .p.description = NULL_IF_CONFIG_SMALL("Detect frames that are (almost) black."), .p.priv_class = &blackframe_class, - .p.flags = AVFILTER_FLAG_METADATA_ONLY, + .p.flags = AVFILTER_FLAG_METADATA_ONLY | AVFILTER_FLAG_SLICE_THREADS, .priv_size = sizeof(BlackFrameContext), FILTER_INPUTS(avfilter_vf_blackframe_inputs), FILTER_OUTPUTS(ff_video_default_filterpad), FILTER_PIXFMTS_ARRAY(pix_fmts), -}; +}; \ No newline at end of file -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org