From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2AFEC4DACC for ; Tue, 23 Dec 2025 16:17:21 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'gXCo/yDyM1Hr4LyaJhiWIScTqsz0fpAzsxjqNPi5N0w=', expected b'wXFmr2/bOMyEKLenQGxhINVYevinTJXBYLDNqnnR6tI=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1766506636; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=YijuA24tbYPI7wRZs2hTSSJkaZw8+0GlNwV7bK+77o4=; b=v4AyxendBl6onCbNdhl3afyP9v0NsMra9ms45WwnVsSSDm+n8LV7lcIujl/eDyaGA4IsU Q2zlwjl8cGMRjARpVsK8jp6KaGD2RtvMH6z3Fy8q0/Sy6rPWMYTBT1BUnGqVa+ac6u9uRKb hevruy/RIDGai2gPjd+INP0Uxwh2L9lAOuAzyUnhFp1fut4W2YGSMOQ8ivMs3tNCM1YTv4X JNiQkpH8r+2cG2Xl/XKfI0iqclDZeu80vYMvzsGg1ubn1dFNstkLKlItwedx/KmnKc1Ndix Ogyir7Cub0jwmykMAtT32J+RPoU1VPXUjfTuLSFJkB0f99LCSZEy2HebqSAA== Received: from [172.20.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 88C3E690B1E; Tue, 23 Dec 2025 18:17:16 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1766506631; b=hVoksfhEkF3259+t1lhYLhFwQKXnwZuyFHw1076vNBb/Q7paS8jGjOjWfAM1JKs6om2Do wRIGmGX6fpf4hHh5xUKyXb1GuesRuCx/Qfu4jPgRbt5J6axwRW2fUHzAH5NM8kBUwkxQ9hy YwDF+uR02YHKRKbq0Du8nsXJSajCqSMn5UVQmmIrMbRz2MRhEluVWV1hb0uCzT9a6kvq3gA eKJk2u/X6JxMieyRd8zgWrDN2SJBQsRXggvupUAZzVKaOOXkNPLgT3J/HYV3D3DeY+lC7K4 dgwfXoGQJP96Ai5iwFatqh/9vCPUOeRp+XLfUg5nKEkXzVbRTlQ6ORZMMFtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1766506631; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=gXCo/yDyM1Hr4LyaJhiWIScTqsz0fpAzsxjqNPi5N0w=; b=ap4z+MYH96YU52OWs83na6PoY/uaCQ4S5prb7AlTefykDxojwH0fnjDtqf9GqG8KfbbrQ dup9J0vqfJR8mNaDxVYtSzUU8flMfAtLPmrRaHkRYtrz0trfLHGjFhCBxT/KvZXlc37TQfR JildAD8oVsqKdcwz+bB7HRYPpaprGsYA28WpDpNXdySs30q31ZoV3erFHIikFkGFtzhzng5 0HCKTmP/noMjHxoTh0IEtv66f5vPZsN4EUq4FsVq//n+UDn/Pbf8MlUJzD9wGiQhzG2n7ig 9p/rD5bWdvreha3c41BMyWHcRWbzU3FqX5RtdWf24vDblRxfbA43yJo/Ml8A== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D994A6909B1 for ; Tue, 23 Dec 2025 18:16:57 +0200 (EET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a0d6f647e2so82663515ad.1 for ; Tue, 23 Dec 2025 08:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766506616; x=1767111416; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wXFmr2/bOMyEKLenQGxhINVYevinTJXBYLDNqnnR6tI=; b=ki1SgAmuwBEv7vvGl1i5CyRJkG5vsOFLnVEvhzgE97iTwe6ulkvuWqWY6FpWUXCGOj JYJ1b3nlTvMRgVRJ3/vxdCMSkFVCLcaF6nsX2e23ts1b1ZcWjjgDSwQQEvNen0sHEpWY C5dKiS/a4lTUQXYOj9TPXh9W1ZQPBSH79xEj9nTfF8aRhJSE7gnvEegIo5LOFU0Cf9xe 5JGKDAaLWqlV8slDLSJ5MmC127wss+oeEZzHd669WjX2XOIFCjH6snXThlQyhMctTwFg GWVAKp0RfaK0xdaPPAmg2GefoHyXpbNHaXqPYvrNbX/bYwzNx+AGeSyoB2JcTpY9+yJO 2T2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766506616; x=1767111416; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wXFmr2/bOMyEKLenQGxhINVYevinTJXBYLDNqnnR6tI=; b=C200P6HD5KwG14AL0XnYKrxSHF+mPlFQISeYdZwWuHJojmUblCZngJdVZb0x9Ypclg dTcFwqJ/qyS1lfm02Pt4ey1VvmlqPj5QdBfKnhCF8H93dxlOOqAUDzlsi0vXQoqUxsj5 HrCXNOROox2Jj2/R/Chfx5reau63MhaZcn3dfKPYU+PkAWvS+EHzDQkixVWb7STEJXwy //1PxlCPO0DgZQZiVt+4K75t/5glFV0nti2uunhg+oyHr75bgtDydNuHhOTER8Y0H+id asmMPwShw8uf158xuzMcMMcyw9om/QF0QBRO9mFEn5PTeqR7Lzp797ghTawlLEBa+sO+ mNHw== X-Gm-Message-State: AOJu0YyCoymKQgqchyc+y+V/j5thgPwSaFHENz/Vc6TtK08+Q33zShrJ T/Eci31MnuXWUfMu6361KPJC4dOqU/EMGzbTGUHwvHXuJBh4u/rnbt+v0E9Pjw== X-Gm-Gg: AY/fxX7X5hrXxCTf/s4Ne/8NAbQUWSlB2FsaJbtwwDNwjlf3ZnmOAEFNB3IrqicK7qE TB3s/iNXFD0qHpLlOIErQonAmd+aNQXrmAT0uUGmOlsRU5IBwpfnbL3ng7ScJqNSMC+TdKLmga/ db7HXKlaubPtoH+Sd1YV1GcB0feUCfVEJBYVKNFXaP275l1X9OmQqz/aE+1O1yfOQ2FWDAyoMFF ovqoyCONtPeQuW3wzORuv0vsis2RxCj7Esnp0VdPbpdcqfo4Cg2iYA7ut2MVOEApYNvdXvc375q CZRbODsAU2y0WxTqx+BUcOrNXSefvq0rC045O5pZ/vq6VDt5BFPU0GYiMSAMf+8yeFxrZ5D09g3 3TNfuNADwmPb80HEamhlrBLXP9vHiG5uUR3DRbwiQh1633F8uUGoT+B4QR/GbWGb/Kb2DAvOKvL qewiaBogU3p740+N8KritpkGbINw2iAzMbuM80TFU= X-Google-Smtp-Source: AGHT+IFt4Hxf70nGM4Twg5z9S8WIZMtSc0MJzu9OTDOSEjrEBZ8lz1RnWJDwNptNRloaWD43a/vkuQ== X-Received: by 2002:a17:903:290:b0:2a1:e19:ff5 with SMTP id d9443c01a7336-2a2f273818fmr164252885ad.38.1766506615632; Tue, 23 Dec 2025 08:16:55 -0800 (PST) Received: from Raja-Rathour-ASUS-TUF-Gaming-A15.. ([150.242.65.63]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d4cb3csm133506865ad.58.2025.12.23.08.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 08:16:55 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 Dec 2025 21:46:43 +0530 Message-ID: <20251223161643.110588-1-imraja729@gmail.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Message-ID-Hash: OPLSGEXFUHREKJE6OJOCTCDNFAGAUGNY X-Message-ID-Hash: OPLSGEXFUHREKJE6OJOCTCDNFAGAUGNY X-MailFrom: SRS0=JFHy=65=gmail.com=imraja729@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH v3] avfilter/vf_blackframe: add slice threading List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Raja Rathour via ffmpeg-devel Cc: Raja Rathour Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: --- libavfilter/vf_blackframe.c | 80 ++++++++++++++++++++++++++++++++----- 1 file changed, 71 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_blackframe.c b/libavfilter/vf_blackframe.c index f0aa53e133..cb566d103d 100644 --- a/libavfilter/vf_blackframe.c +++ b/libavfilter/vf_blackframe.c @@ -32,6 +32,7 @@ #include "libavutil/internal.h" #include "libavutil/opt.h" +#include "libavutil/mem.h" #include "avfilter.h" #include "filters.h" #include "video.h" @@ -45,6 +46,14 @@ typedef struct BlackFrameContext { unsigned int last_keyframe; ///< frame number of the last received key-frame } BlackFrameContext; +typedef struct ThreadData { + const uint8_t *data; // Pointer to the image data + int linesize; // How wide is the memory line + int bthresh; // The black threshold + int width; // Image width + unsigned int *counts; // POINTER to the array where threads write results +} ThreadData; + static const enum AVPixelFormat pix_fmts[] = { AV_PIX_FMT_YUV410P, AV_PIX_FMT_YUV420P, AV_PIX_FMT_GRAY8, AV_PIX_FMT_NV12, AV_PIX_FMT_NV21, AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV411P, @@ -55,22 +64,72 @@ static const enum AVPixelFormat pix_fmts[] = { snprintf(buf, sizeof(buf), format, value); \ av_dict_set(metadata, key, buf, 0) +static int blackframe_slice(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs) +{ + ThreadData *td = arg; + // Calculate vertical slice + int slice_start = (ctx->inputs[0]->h * jobnr) / nb_jobs; + int slice_end = (ctx->inputs[0]->h * (jobnr+1)) / nb_jobs; + + // Safety check for pointers + if (!td || !td->data || !td->counts) return 0; + + const uint8_t *p = td->data + slice_start * td->linesize; + unsigned int local_nblack = 0; + int x, y; + + for (y = slice_start; y < slice_end; y++) { + for (x = 0; x < td->width; x++) + local_nblack += p[x] < td->bthresh; + p += td->linesize; + } + + // Save my private count + td->counts[jobnr] = local_nblack; + return 0; +} + static int filter_frame(AVFilterLink *inlink, AVFrame *frame) { AVFilterContext *ctx = inlink->dst; BlackFrameContext *s = ctx->priv; - int x, i; int pblack = 0; - uint8_t *p = frame->data[0]; AVDictionary **metadata; char buf[32]; - - for (i = 0; i < frame->height; i++) { - for (x = 0; x < inlink->w; x++) - s->nblack += p[x] < s->bthresh; - p += frame->linesize[0]; + ThreadData td; + + // 1. Get thread count + int nb_threads = ff_filter_get_nb_threads(ctx); + + // Allocate memory for thread results + unsigned int *thread_counts = av_calloc(nb_threads, sizeof(*thread_counts)); + if (!thread_counts) { + av_log(ctx, AV_LOG_ERROR, "Failed to allocate thread_counts\n"); + return AVERROR(ENOMEM); } + // 3. Prepare the data package + td.data = frame->data[0]; + td.linesize = frame->linesize[0]; + td.width = inlink->w; + td.bthresh = s->bthresh; + td.counts = thread_counts; + + // 4. Run the threads! + // We calculate the exact number of jobs we are about to run + int nb_jobs = FFMIN(frame->height, nb_threads); + + ff_filter_execute(ctx, blackframe_slice, &td, NULL, nb_jobs); + + // 5. THE REDUCE STEP: Sum up the results + s->nblack = 0; + // Only sum up the jobs that actually ran + for (int i = 0; i < nb_jobs; i++) { + s->nblack += thread_counts[i]; + } + + // --- FROM HERE DOWN, THE CODE IS THE SAME AS THE ORIGINAL --- + if (frame->flags & AV_FRAME_FLAG_KEY) s->last_keyframe = s->frame; @@ -89,6 +148,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) s->frame++; s->nblack = 0; + + av_free(thread_counts); + return ff_filter_frame(inlink->dst->outputs[0], frame); } @@ -118,9 +180,9 @@ const FFFilter ff_vf_blackframe = { .p.name = "blackframe", .p.description = NULL_IF_CONFIG_SMALL("Detect frames that are (almost) black."), .p.priv_class = &blackframe_class, - .p.flags = AVFILTER_FLAG_METADATA_ONLY, + .p.flags = AVFILTER_FLAG_METADATA_ONLY | AVFILTER_FLAG_SLICE_THREADS, .priv_size = sizeof(BlackFrameContext), FILTER_INPUTS(avfilter_vf_blackframe_inputs), FILTER_OUTPUTS(ff_video_default_filterpad), FILTER_PIXFMTS_ARRAY(pix_fmts), -}; +}; \ No newline at end of file -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org