From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5E69C4DABF for ; Tue, 23 Dec 2025 15:31:00 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'6WTT/N2UFlMP+nrqrMw0VkypAR0LKeECA/R3aIuuKdY=', expected b'ghZQTgGeyO9ltMlEkN0nZ//xeZMDCZeXZECj0fx4q5I=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1766503846; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=wvpwa11ZzWhY9U9BccHhRvWOXua5HMc5qBvVB7IqSDI=; b=3Dh25nnW53HjonRwJJBcN52BZ/IZt0JfSYmsAL/fdw/1a9eQj88EZdonA8Q57f9E+G2xh mwu/nK5wWcub1VSmkOk8vHSACK+P4WB2rM19McxFDy2RPK3XYbsU/gmCtxUx/+4FvWmZ0sb JPbwe95IVO+RNxaapFre+V1ZL/53Oj9hzw9cemRd3uqbZbsT6Hcv/iGFfneBx/InoBXicQj RYSzhsNSJOxunA7+gpbCukiyAgTZBBWiJaVElkpEoo13BxsZ8WAPjVqj8lHMAkf68mt+kRc MxWhSKo4PUouQ3CC8wYfDYoYMuRN015lg8y4pgCa72J8YvhiK+vTLSzVvJ8A== Received: from [172.20.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id AB59A690ADE; Tue, 23 Dec 2025 17:30:46 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1766503838; b=S+U6cDFNJY0qz13tBHKbXJtVHHKpgT3ecvCNnGKM0T8XdRFds+d8wOSFgcnp5KYt8lDrq hsDNzNlo1C+XfGnpszwFnBs1A9X9Hb0O8oIO14j/MqWXxw+JbDF2mgXD5afO7epyKur9XNA LSqJRj8Ki0zvftN9HBytsKcoljXJkDlC35U0g5OCE0+vLWavXY7MIy+5L74CQFaNIx/O+ei uWUGVauoWldStSk3ZRxVBuhHcJiSiI1QUPpkCOoP/jXHBHzuoEwdotHIbTcRJ1rNNd68qze hDoizOcQFdHCy+RqDWBvLuAKnswsW/HKxcXNVEo6f2TM7DnQGoFwcvrUSd+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1766503838; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=6WTT/N2UFlMP+nrqrMw0VkypAR0LKeECA/R3aIuuKdY=; b=C/jCRyZSXgiwdxMSqJOHF6+Nw79jvkzAkJNz/22GbpsW3lUwCE8xCKSaAPENFFFKWy2xF o7vGLTR5EKK24oj9FhdbkeqHJkvfiUPZO9Vlxpq1looQ0D5HtAr7yQy4nb66K44QYXaoyv1 OQNpDTHzR19BCZ7KxecL4sUKkT3L+Tunq9TXi1pjrYBIr5pXXTwltxTsxGWU1sc4Mc1PNE1 Ig3eplDK7hlB9Vhr0VwE4mYfDd9/v9adOvWpzpTtcgKXjXVkCFJszZrZsWnl/QeH4mzsdsW q3iJMlnXjKxPd9//WMDFju83leo7U7u73TEZWVHjvVBue/HaIiDHoNzvGSig== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 65A066909B1 for ; Tue, 23 Dec 2025 17:30:25 +0200 (EET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a0833b5aeeso69237495ad.1 for ; Tue, 23 Dec 2025 07:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766503823; x=1767108623; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ghZQTgGeyO9ltMlEkN0nZ//xeZMDCZeXZECj0fx4q5I=; b=gK5xiszA482l7GBfEVaAKauDToDjpZAgjZ35OCFOYzXWMlz7aBqvo7dpU6BUGGvA/N K2WeryGJNqfdOqos7cKTu3JVt76ifAVAV2Zavk8n7/WxUajjqePW1Wpkz6qXglaG593E pzxGsU0/gXIzeKAqluSrWkeg+5z5fcqm1kB4xI0Y8KUTl+JncLW3uMp6VvjPqXBJKd7x BaPyH4YSC1VrQW0Et5Ek3NQlYLpY5R3G08iwDmNTC1eBWlXzN/JmeolupNRPdAU6Cupp QGtEL4u+tpIVeapTgXE00h2wyafXVC+n4Ts7CP86tPagvolDpI/aNvfpsjJw+3EYtLUI PlhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766503823; x=1767108623; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ghZQTgGeyO9ltMlEkN0nZ//xeZMDCZeXZECj0fx4q5I=; b=qMc7hmxGP4Sc1yW3WF5nR8rEIHK5T9gl6UMTVQbZfWH7xgF/m9nmdOkWsWTSYbhKM9 X6oEdD18BKmVw6IebhtoeZu5HB7GadWkX8TXv036RLVkRclpYe8UrjVFmt/RT4359HFx sf74wNVxLMnLlf/j0YGc0sjkC8NYFWbLDvUVzbtFoK24yi6S6lgr0HhObL63Z1I8q/rA Ca7s/dwIzdUSQj1MVyv9bWLAvwrwnA6FToczK5/RzrkA/8AJPodY7X4/PM/UnOActlX7 9U+sNpe/Lp+2OsdPn9OPPs5tKc0vdFvEH3AjVc08c4SCI0g0m5CKg1XWbxBT/LR2GyQW j65g== X-Gm-Message-State: AOJu0YxHE/7I39KGxRRYeS1VHrHyaV6a8PX7muV1croXe50PZWVLDx1X eOM4Tyoo2ru29hnzKmQC0CyR0to/EQmFcU4sS9d7AKxGzcYm/61fPr1xkZD7aQ== X-Gm-Gg: AY/fxX4oy27E/YIWoPotbVOYqu1hQk9TedlyyWqwNWg/y9mdO/JhZ2qPO+qJRqUZYO7 PDbF2OwVBMKpi+GCCfqTpzkwA95qz5UCZchgHFKHX1swaecxjkHjp7fL2Osh4K6E75ANeViWcMS HFwJLuK9xMS8lRDpg+vgAFXLUuF/uar7GRwJ5/1Erljyr3zcRQ/hM5qx9RQewYgzT0Vqk9KuvSW o1FSR1MNhkNHtJV8VTYmRpJa8NrDHyUlrSyxRMnQ76FDQAnLMr9vgf7Z2STIVfbA32qE+QW0LKE CFYzZaG7EyIUu7jnEBgUO4O6bbnXWtPMGeb7e2YdaSbIck2cE9x34Hd7t9yZQE1DLpDqHPQS45Y T8OMM8prxua/EdDbT8sdmc22OOcqrF2oQY9IiwAupGguZ3L4/hg3gGC6WaOF82pzyZtgyrGnUj4 mprxwLRTDQWda0t+XEVyTqJ+3IcpkS40cKcHNlqPQ= X-Google-Smtp-Source: AGHT+IGeUukYAFTHqkSuiDSv991AawYzCQSJRLzoYdYamysEpH6zB6FGcnAUtpPYRETAFBr07F+SoQ== X-Received: by 2002:a17:903:a85:b0:29d:df04:fcdf with SMTP id d9443c01a7336-2a2f2a34ee6mr95113385ad.42.1766503823146; Tue, 23 Dec 2025 07:30:23 -0800 (PST) Received: from Raja-Rathour-ASUS-TUF-Gaming-A15.. ([150.242.65.63]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c65d71sm133220295ad.17.2025.12.23.07.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 07:30:22 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 Dec 2025 21:00:09 +0530 Message-ID: <20251223153009.91497-1-imraja729@gmail.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Message-ID-Hash: NJVL3RAX66LNUDNLSHUQ7UKJ74PAPTXO X-Message-ID-Hash: NJVL3RAX66LNUDNLSHUQ7UKJ74PAPTXO X-MailFrom: SRS0=JFHy=65=gmail.com=imraja729@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH v2] avfilter/vf_blackframe: add slice threading List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Raja Rathour via ffmpeg-devel Cc: Raja Rathour Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: Move the main rendering logic into a slice function to enable multi-threading support. Signed-off-by: Raja Rathour --- libavfilter/vf_blackframe.c | 80 ++++++++++++++++++++++++++++++++----- 1 file changed, 71 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_blackframe.c b/libavfilter/vf_blackframe.c index f0aa53e133..cb566d103d 100644 --- a/libavfilter/vf_blackframe.c +++ b/libavfilter/vf_blackframe.c @@ -32,6 +32,7 @@ #include "libavutil/internal.h" #include "libavutil/opt.h" +#include "libavutil/mem.h" #include "avfilter.h" #include "filters.h" #include "video.h" @@ -45,6 +46,14 @@ typedef struct BlackFrameContext { unsigned int last_keyframe; ///< frame number of the last received key-frame } BlackFrameContext; +typedef struct ThreadData { + const uint8_t *data; // Pointer to the image data + int linesize; // How wide is the memory line + int bthresh; // The black threshold + int width; // Image width + unsigned int *counts; // POINTER to the array where threads write results +} ThreadData; + static const enum AVPixelFormat pix_fmts[] = { AV_PIX_FMT_YUV410P, AV_PIX_FMT_YUV420P, AV_PIX_FMT_GRAY8, AV_PIX_FMT_NV12, AV_PIX_FMT_NV21, AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV411P, @@ -55,22 +64,72 @@ static const enum AVPixelFormat pix_fmts[] = { snprintf(buf, sizeof(buf), format, value); \ av_dict_set(metadata, key, buf, 0) +static int blackframe_slice(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs) +{ + ThreadData *td = arg; + // Calculate vertical slice + int slice_start = (ctx->inputs[0]->h * jobnr) / nb_jobs; + int slice_end = (ctx->inputs[0]->h * (jobnr+1)) / nb_jobs; + + // Safety check for pointers + if (!td || !td->data || !td->counts) return 0; + + const uint8_t *p = td->data + slice_start * td->linesize; + unsigned int local_nblack = 0; + int x, y; + + for (y = slice_start; y < slice_end; y++) { + for (x = 0; x < td->width; x++) + local_nblack += p[x] < td->bthresh; + p += td->linesize; + } + + // Save my private count + td->counts[jobnr] = local_nblack; + return 0; +} + static int filter_frame(AVFilterLink *inlink, AVFrame *frame) { AVFilterContext *ctx = inlink->dst; BlackFrameContext *s = ctx->priv; - int x, i; int pblack = 0; - uint8_t *p = frame->data[0]; AVDictionary **metadata; char buf[32]; - - for (i = 0; i < frame->height; i++) { - for (x = 0; x < inlink->w; x++) - s->nblack += p[x] < s->bthresh; - p += frame->linesize[0]; + ThreadData td; + + // 1. Get thread count + int nb_threads = ff_filter_get_nb_threads(ctx); + + // Allocate memory for thread results + unsigned int *thread_counts = av_calloc(nb_threads, sizeof(*thread_counts)); + if (!thread_counts) { + av_log(ctx, AV_LOG_ERROR, "Failed to allocate thread_counts\n"); + return AVERROR(ENOMEM); } + // 3. Prepare the data package + td.data = frame->data[0]; + td.linesize = frame->linesize[0]; + td.width = inlink->w; + td.bthresh = s->bthresh; + td.counts = thread_counts; + + // 4. Run the threads! + // We calculate the exact number of jobs we are about to run + int nb_jobs = FFMIN(frame->height, nb_threads); + + ff_filter_execute(ctx, blackframe_slice, &td, NULL, nb_jobs); + + // 5. THE REDUCE STEP: Sum up the results + s->nblack = 0; + // Only sum up the jobs that actually ran + for (int i = 0; i < nb_jobs; i++) { + s->nblack += thread_counts[i]; + } + + // --- FROM HERE DOWN, THE CODE IS THE SAME AS THE ORIGINAL --- + if (frame->flags & AV_FRAME_FLAG_KEY) s->last_keyframe = s->frame; @@ -89,6 +148,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) s->frame++; s->nblack = 0; + + av_free(thread_counts); + return ff_filter_frame(inlink->dst->outputs[0], frame); } @@ -118,9 +180,9 @@ const FFFilter ff_vf_blackframe = { .p.name = "blackframe", .p.description = NULL_IF_CONFIG_SMALL("Detect frames that are (almost) black."), .p.priv_class = &blackframe_class, - .p.flags = AVFILTER_FLAG_METADATA_ONLY, + .p.flags = AVFILTER_FLAG_METADATA_ONLY | AVFILTER_FLAG_SLICE_THREADS, .priv_size = sizeof(BlackFrameContext), FILTER_INPUTS(avfilter_vf_blackframe_inputs), FILTER_OUTPUTS(ff_video_default_filterpad), FILTER_PIXFMTS_ARRAY(pix_fmts), -}; +}; \ No newline at end of file -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org