From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EE4674DAB1 for ; Tue, 23 Dec 2025 15:27:45 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'apnOxW+yG5DQs/KYYdlPwFKmJq/39IlUG5W20U+dbYQ=', expected b'oGBtFLuY2OvlwiWSWTyso4jBcLdsKShHYsyYCyzR4Do=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1766503661; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=QgaPIflofOlgIf48uDAAtaApgmL45WE5gDINm7tfrOU=; b=IWO3zoJ0lYmeqIy5hgkWfdkWbOLJqjybso9OlwUHlqsqq5WbxCUTHYmvmJSv5R8b2gLav UZNurXbhOEz9MPNJ/CJyZieSr57X1JKPmHbcqikYrPY/7y+EZXkPZM25ZJ85Af3Q6qNSCdy 7N7dAe4/btqEGzHlFEWjMdF/mey4dYL9Z+TYqHifyETdsrnVJqHH1MfT2Nvm6azaZpWvPyH Cgvin5mgQ6g7ZtqygMu8TrpdtMiwSqk9RQ0718jcIrclDsm1t6xo3B5MBPOUZBu4At7gmC2 ATf8eHXQLF3mrm3BmNH33M6THPrxvBz3jqI6UEMTUBCLg12SBjQvzqGrhklw== Received: from [172.20.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3CBF8690ADE; Tue, 23 Dec 2025 17:27:41 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1766503655; b=jzL3vwsZaOO1raWK29HeYS+7a74iftjLaoZl6jXGygCbjnFOFn/Om1Xv3Hh6pbPiw9eXP V95juh2AL3BneTkZTL0wKgfEVcwPMJhin94JIAUFxtSJN2DVRIxkXER5UNMc9aTtHWm28dD xkLxysEFO1EXa33LsWLbiPTw9zXCrMzsYTqoJ47MIiOLYT5r36tIHzv1rvbhS/BS/OU2pTm MmGFSz8odr8sWp1BEn9z67/LvYjkicNkcsFT8Fvsjo38EndwyhoZNOxFrrDQuKfUt4INpZ3 z3DPKXhFFq8zK/Eo0SAL2GNvbAlRyQxm+4HnLO2Ot9Dme/bWpEJ6rxsSp3cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1766503655; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=apnOxW+yG5DQs/KYYdlPwFKmJq/39IlUG5W20U+dbYQ=; b=FsmSlNPpxZyGCa0KpjIzTHR1KVhAoxE269UatF1OG2c8sGEuxFDYw4MaGC/jKesDvmQaF LeFjBGnn3L+xkoklYes09Ps5X406u1r+JJ7OIegjJ/rY6khVxAFumkGb6LKROGBcI2nPOH6 wa4wa14m1XTvYSNn3NZPFfokXtpvMbu6y/KmQDg8ETOwVN+TRJiSTcFpB+XC6z61dVnixwC 6ObwRiV4foInbMjuPQsXHHPTrd3kyhs0h8cNTCRRmUhaZaYiUZvlNdsQyoTQ9sSle39i7JA bgGqLOiWQPMg2jzdCEA7gB3OndAzj+ILw5uHNoYsxIYKmfHSpQwdQitctzQA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id C51146909B1 for ; Tue, 23 Dec 2025 17:27:22 +0200 (EET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-29f102b013fso62713695ad.2 for ; Tue, 23 Dec 2025 07:27:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766503641; x=1767108441; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oGBtFLuY2OvlwiWSWTyso4jBcLdsKShHYsyYCyzR4Do=; b=lLxPbAyOHk/7WyYYfM9uHeyegoxZcxMkv5FX1fdZoXMSuMOfB0EpZNoR7yYBGh+yAk WQUOC4N32mM4OGjBbMLW6hBCY59OceYr5X/4U2l2bxNLmOtRRg3QDIngIIorox9yU2R1 +3iz0cGG7KG8UEaetEKMxlt600NWzz79Jj1ac8YCBysRe1GkFtUJHOTeWG3GKCF6Ewpz /vH5fE5M7vxNsOEPa//rWZDNFtQRsZ4XOI6SG7s5ex1HnP9fndmh07qW8K8kAE/aJgNY rMch+qucFa2lRVL/A3AjArwpVmg3JYX2HHvveAZrNeOJagpwsYPN0tEbejYec+hG10s2 hIDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766503641; x=1767108441; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oGBtFLuY2OvlwiWSWTyso4jBcLdsKShHYsyYCyzR4Do=; b=lDyyCoaXDjc/heb8Bpz+RkhanwVx4hoSHJmw5mWxxpugbO9hneJfzz75R1wkU4dWW1 vP19spXk2jRGIYmhjrOuwlh3NTBD5mkdfKyZQ31Rjg7CzYSqCFK5UVhvVY3IC0g4Cx3v dP6ugQBKmf+g0aoS3VA/PhJv6B1r/JJEzDPUxe8QLryHrwHNhu69UZadHsXNDVKGWBuC fVZj5hRZubHmEi9Zte8kkRlqxKZS2vSXuanFkI6t5+A7hJ8Rlu46N/Ah7hdrrnetPKeD jlOlwDRSNkX/7lgag5dtHKKFCFoCiZS/PPXbmBjPgM7E5Ndq3tsHJQIvY8m5U8sBwHJ1 OPDQ== X-Gm-Message-State: AOJu0YwacDDxCCx2Q5qLs/bAoLa+2B6epjNrTSICAsGNPNtrce5nidPy Q2J9Q7+K+4L+EzuULJvxhOW/uQgdqXi8QIFN/2/mJgbLfdDYCWvpRQho4gVEWA== X-Gm-Gg: AY/fxX4SK0Z0MbirYgKJ9AuJ82nLxzwMKEUg5MI7jMUr4mWV3ts1RuhP9AlcurRPtNM iWX3HwjJZgHbOdrcmuWr9YkTyael2pkONKj8SPxVhD9uKyhB91BnMK8gu7RZnoD69lktIBGRzXE 0bh1mlRg9v0cqoalhGFI2KTGH65u8YVjJjZTozHR1Kk36746T65gXO/k1/YGTGy7uG300HVBwLk CF1CLTPzy7ROqH9eFlQ4aEHJY521G6ejqDyqb4UQ6bGK8CUdKhIewcXaFKv578TbGyFKJT+vvxX WiN9RUgvImms3YEy3wXIMpScbtmXu5WlRJ/KULScijEjTg0fhC05mz8Vg517ZkH5su5KkOy274w tiGty3o7rU689rPMRHxDxfBjmc9J34ZiHQoX+AgRe6VjJwGT79Pi6vOBqz57Rkse7gOyKESsfn9 yytReiZESfTEdHGKtTk/jse9aWqMDCsGMeiSpWs6E= X-Google-Smtp-Source: AGHT+IGk2AOjAc9e+ReEpFbCVvvpNi/Gh+owkLRwpEoYmvxvFkjlrRpy1f81wqhlwsVVJio5QtVyWA== X-Received: by 2002:a17:903:a85:b0:29d:df04:fcdf with SMTP id d9443c01a7336-2a2f2a34ee6mr95050495ad.42.1766503640563; Tue, 23 Dec 2025 07:27:20 -0800 (PST) Received: from Raja-Rathour-ASUS-TUF-Gaming-A15.. ([150.242.65.63]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66834sm128255415ad.9.2025.12.23.07.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 07:27:20 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 Dec 2025 20:55:51 +0530 Message-ID: <20251223152551.89642-1-imraja729@gmail.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Message-ID-Hash: VQJ2LAFXIMJMIPKTVFTG6RBD52DFMEEP X-Message-ID-Hash: VQJ2LAFXIMJMIPKTVFTG6RBD52DFMEEP X-MailFrom: SRS0=JFHy=65=gmail.com=imraja729@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avfilter/vf_blackframe: add slice threading Move the main rendering logic into a slice function to enable multi-threading support. List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Raja Rathour via ffmpeg-devel Cc: Raja Rathour Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: Signed-off-by: Raja Rathour --- libavfilter/vf_blackframe.c | 80 ++++++++++++++++++++++++++++++++----- 1 file changed, 71 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_blackframe.c b/libavfilter/vf_blackframe.c index f0aa53e133..cb566d103d 100644 --- a/libavfilter/vf_blackframe.c +++ b/libavfilter/vf_blackframe.c @@ -32,6 +32,7 @@ #include "libavutil/internal.h" #include "libavutil/opt.h" +#include "libavutil/mem.h" #include "avfilter.h" #include "filters.h" #include "video.h" @@ -45,6 +46,14 @@ typedef struct BlackFrameContext { unsigned int last_keyframe; ///< frame number of the last received key-frame } BlackFrameContext; +typedef struct ThreadData { + const uint8_t *data; // Pointer to the image data + int linesize; // How wide is the memory line + int bthresh; // The black threshold + int width; // Image width + unsigned int *counts; // POINTER to the array where threads write results +} ThreadData; + static const enum AVPixelFormat pix_fmts[] = { AV_PIX_FMT_YUV410P, AV_PIX_FMT_YUV420P, AV_PIX_FMT_GRAY8, AV_PIX_FMT_NV12, AV_PIX_FMT_NV21, AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV411P, @@ -55,22 +64,72 @@ static const enum AVPixelFormat pix_fmts[] = { snprintf(buf, sizeof(buf), format, value); \ av_dict_set(metadata, key, buf, 0) +static int blackframe_slice(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs) +{ + ThreadData *td = arg; + // Calculate vertical slice + int slice_start = (ctx->inputs[0]->h * jobnr) / nb_jobs; + int slice_end = (ctx->inputs[0]->h * (jobnr+1)) / nb_jobs; + + // Safety check for pointers + if (!td || !td->data || !td->counts) return 0; + + const uint8_t *p = td->data + slice_start * td->linesize; + unsigned int local_nblack = 0; + int x, y; + + for (y = slice_start; y < slice_end; y++) { + for (x = 0; x < td->width; x++) + local_nblack += p[x] < td->bthresh; + p += td->linesize; + } + + // Save my private count + td->counts[jobnr] = local_nblack; + return 0; +} + static int filter_frame(AVFilterLink *inlink, AVFrame *frame) { AVFilterContext *ctx = inlink->dst; BlackFrameContext *s = ctx->priv; - int x, i; int pblack = 0; - uint8_t *p = frame->data[0]; AVDictionary **metadata; char buf[32]; - - for (i = 0; i < frame->height; i++) { - for (x = 0; x < inlink->w; x++) - s->nblack += p[x] < s->bthresh; - p += frame->linesize[0]; + ThreadData td; + + // 1. Get thread count + int nb_threads = ff_filter_get_nb_threads(ctx); + + // Allocate memory for thread results + unsigned int *thread_counts = av_calloc(nb_threads, sizeof(*thread_counts)); + if (!thread_counts) { + av_log(ctx, AV_LOG_ERROR, "Failed to allocate thread_counts\n"); + return AVERROR(ENOMEM); } + // 3. Prepare the data package + td.data = frame->data[0]; + td.linesize = frame->linesize[0]; + td.width = inlink->w; + td.bthresh = s->bthresh; + td.counts = thread_counts; + + // 4. Run the threads! + // We calculate the exact number of jobs we are about to run + int nb_jobs = FFMIN(frame->height, nb_threads); + + ff_filter_execute(ctx, blackframe_slice, &td, NULL, nb_jobs); + + // 5. THE REDUCE STEP: Sum up the results + s->nblack = 0; + // Only sum up the jobs that actually ran + for (int i = 0; i < nb_jobs; i++) { + s->nblack += thread_counts[i]; + } + + // --- FROM HERE DOWN, THE CODE IS THE SAME AS THE ORIGINAL --- + if (frame->flags & AV_FRAME_FLAG_KEY) s->last_keyframe = s->frame; @@ -89,6 +148,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) s->frame++; s->nblack = 0; + + av_free(thread_counts); + return ff_filter_frame(inlink->dst->outputs[0], frame); } @@ -118,9 +180,9 @@ const FFFilter ff_vf_blackframe = { .p.name = "blackframe", .p.description = NULL_IF_CONFIG_SMALL("Detect frames that are (almost) black."), .p.priv_class = &blackframe_class, - .p.flags = AVFILTER_FLAG_METADATA_ONLY, + .p.flags = AVFILTER_FLAG_METADATA_ONLY | AVFILTER_FLAG_SLICE_THREADS, .priv_size = sizeof(BlackFrameContext), FILTER_INPUTS(avfilter_vf_blackframe_inputs), FILTER_OUTPUTS(ff_video_default_filterpad), FILTER_PIXFMTS_ARRAY(pix_fmts), -}; +}; \ No newline at end of file -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org