* [FFmpeg-devel] [PATCH] libavcodec/x86/vp8dsp.asm: Revert syntax causing assembly errors in OSS-Fuzz
@ 2025-12-10 12:12 xingyaner via ffmpeg-devel
0 siblings, 0 replies; 2+ messages in thread
From: xingyaner via ffmpeg-devel @ 2025-12-10 12:12 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: xingyaner
In commit 99fb257 and commit 3135bc0 of FFmpeg, New changes introduce syntax that relies on the assembler preprocessor to evaluate Boolean logic operations (== and !!).
However, the assemblers (NASM/YASM) within the OSS-Fuzz environment, or the x86inc. asm macro expansion mechanism, cannot correctly parse these complex expressions,
resulting in an expecting ')' error.
To fix the fuzzing build error, I suggest keeping these two lines of code in their original version.
'cglobal put_vp8_epel%1_h6, 6, 6 + npicregs, 8, dst, dststride, src, srcstride, height, mx, picreg'
'cglobal put_vp8_epel%1_h4, 6, 6 + npicregs, 7, dst, dststride, src, srcstride, height, mx, picreg'␋
Signed-off-by: xingyaner <longfor2025@gmail.com>
---
libavcodec/x86/vp8dsp.asm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/x86/vp8dsp.asm b/libavcodec/x86/vp8dsp.asm
index 22356f687b..d758b84afa 100644
--- a/libavcodec/x86/vp8dsp.asm
+++ b/libavcodec/x86/vp8dsp.asm
@@ -173,7 +173,7 @@ SECTION .text
%define MOV movq
%endif
-cglobal put_vp8_epel%1_h6, 6, 6 + npicregs, 6+2*(%1==8), dst, dststride, src, srcstride, height, mx, picreg
+cglobal put_vp8_epel%1_h6, 6, 6 + npicregs, 8, dst, dststride, src, srcstride, height, mx, picreg
%if %1 == 4
mova m3, [filter4_h6_shuf]
%if PIC
@@ -228,7 +228,7 @@ cglobal put_vp8_epel%1_h6, 6, 6 + npicregs, 6+2*(%1==8), dst, dststride, src, sr
jg .nextrow
RET
-cglobal put_vp8_epel%1_h4, 6, 6 + npicregs, 6+!!(%1 == 8), dst, dststride, src, srcstride, height, mx, picreg
+cglobal put_vp8_epel%1_h4, 6, 6 + npicregs, 7, dst, dststride, src, srcstride, height, mx, picreg
mova m2, [pw_256]
%if %1 == 8
shl mxd, 4
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* [FFmpeg-devel] [PATCH] libavcodec/x86/vp8dsp.asm: Revert syntax causing assembly errors in OSS-Fuzz
@ 2025-12-10 12:58 xingyaner via ffmpeg-devel
0 siblings, 0 replies; 2+ messages in thread
From: xingyaner via ffmpeg-devel @ 2025-12-10 12:58 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: xingyaner
In commit 99fb257 and commit 3135bc0 of FFmpeg, New changes introduce syntax that relies on the assembler preprocessor to evaluate Boolean logic operations (== and !!).
However, the assemblers (NASM/YASM) within the OSS-Fuzz environment, or the x86inc. asm macro expansion mechanism, cannot correctly parse these complex expressions,
resulting in an expecting ')' error.
To fix the fuzzing build error, I suggest keeping these two lines of code in their original version.
'cglobal put_vp8_epel%1_h6, 6, 6 + npicregs, 8, dst, dststride, src, srcstride, height, mx, picreg'
'cglobal put_vp8_epel%1_h4, 6, 6 + npicregs, 7, dst, dststride, src, srcstride, height, mx, picreg'␋
Signed-off-by: xingyaner <longfor2025@gmail.com>
---
libavcodec/x86/vp8dsp.asm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/x86/vp8dsp.asm b/libavcodec/x86/vp8dsp.asm
index 22356f687b..d758b84afa 100644
--- a/libavcodec/x86/vp8dsp.asm
+++ b/libavcodec/x86/vp8dsp.asm
@@ -173,7 +173,7 @@ SECTION .text
%define MOV movq
%endif
-cglobal put_vp8_epel%1_h6, 6, 6 + npicregs, 6+2*(%1==8), dst, dststride, src, srcstride, height, mx, picreg
+cglobal put_vp8_epel%1_h6, 6, 6 + npicregs, 8, dst, dststride, src, srcstride, height, mx, picreg
%if %1 == 4
mova m3, [filter4_h6_shuf]
%if PIC
@@ -228,7 +228,7 @@ cglobal put_vp8_epel%1_h6, 6, 6 + npicregs, 6+2*(%1==8), dst, dststride, src, sr
jg .nextrow
RET
-cglobal put_vp8_epel%1_h4, 6, 6 + npicregs, 6+!!(%1 == 8), dst, dststride, src, srcstride, height, mx, picreg
+cglobal put_vp8_epel%1_h4, 6, 6 + npicregs, 7, dst, dststride, src, srcstride, height, mx, picreg
mova m2, [pw_256]
%if %1 == 8
shl mxd, 4
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-11 3:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-10 12:12 [FFmpeg-devel] [PATCH] libavcodec/x86/vp8dsp.asm: Revert syntax causing assembly errors in OSS-Fuzz xingyaner via ffmpeg-devel
2025-12-10 12:58 xingyaner via ffmpeg-devel
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git