From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A002846946 for ; Sun, 16 Nov 2025 10:49:43 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'yTJS4EdjYehn1u6ujtCGOuI8jY6hm+Q3qnT3yYkxclA=', expected b'+fMpud5nRYR09kW8lGDhUQu4GUKHsEDTXnrAIWBrJUw=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763290176; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=WIy0GeL0HMriawSBHegEBqysatPB1IK9TKapiLYkHgU=; b=kd2jJU7O4zkFs+TO4EYXhjUGvNGy2oFl+H4GSYxB6GQN376WZLjR4fHl7Q7PdWItZJzXJ ZZgsCmimgcJgCA08jWwvv9kwjn4GtcfUvVEogjalHcZkxkwLsoeoE918C4zhIpNiYa7TuwY P1HBTV5CdZPmz2+zCSsrt6FqqYx/kWWcDFr012CjqSG1qfWvCIDWAT3mIucjk90sKcLYDBP S7VNYzTLH3X8Oi7JjBAs7WtPJi9QWQ/LArRlxWs0SRN0d7egAZEZYf4oRavAwwI+iVekd09 juRc1F/x67brfj9rRVy17pgO+5G2GI6iDsIMYB0mhWPbDMiTkV9+Gn4E3eJw== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0D8F668FE30; Sun, 16 Nov 2025 12:49:36 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763290160; b=R3vl1nHhZ/LMynKq/3V0pRz9Jv83HV6OVH+Lyahyzyng0QxYHv5Ddx97y4jMe/Avx3bbe ENmlfjBPhuroxAg/R6ozrNjidfKMSlu0GnMHu203WiFmwjmJYFgz/Aw0f3JBJuFZGz4nyB3 AQg6axhD9ZHpZ1zevEBLVPMnKAfnLo4LR9MXaTQxmL9nqi8oZtHs+pFi1iZhIm9RVim0nGI fT8PIWFEhoWorR4eKdU5OYTBz6QfL28uArdfZgG55M5kj/otuDqM8pqrk5pSp26rzvLE7fb qqelZ2dj33bj9EUSVtdvnD/k9LhWZnl+0dKh4jIe3cX7xCBAMNlEptZGpQkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763290160; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=ZXljSf+/Ylq+Fh/ZwWkZHhjJ54vzSpDJUtlR2OGWmt0=; b=dKwieJ7Tn0bx9RkyKa0fxm2sbSjnhPvY5hJ1Vp0CB+npWO9vRAcpj5728PH+I1/ET5Wkm K4ZJiQlyWsMgmxn3X+AZbfa1QcIVFBQ9cw56Axj4+oInchhlGdBwQUkQcgNkVbtlySCPMvB eEsMqI2hQkIT2HFWuxvcpbRrgGIGR6TR7YN7WlbgZDJbAO9SzfETmoLe/2vH1/em3tY7yVy LYe1XX7MzakKIbTQGiGqX6H6Uo8sVo/LhZfBEOGhoKMw4QwusDOwIYWqbp0q3WS/W0Z+ryo WFcswJpLa/9rE2bfMJ2toUdwO3JymJ7wzJD5fa6d6xhqcqqt5r4otpDhHrOg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 614B068F645 for ; Sun, 16 Nov 2025 12:49:06 +0200 (EET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2958db8ae4fso31575205ad.2 for ; Sun, 16 Nov 2025 02:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763290142; x=1763894942; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+fMpud5nRYR09kW8lGDhUQu4GUKHsEDTXnrAIWBrJUw=; b=MlU21NuODFy/s1C+fH1Uqf7s/MGkUlR8ZtlovrEtBqRD0IN9bOznO8lvZoUuTHendF 0Z3+WRAZOUxXY1ExwbaeIPlkOKKC+oJU8+35QWxE6eGSKj4Mud0jIDk7qpGZ/XQWvFrf fHvF9YVlhY2y/yjvaj56Ab+0935KsKSdYS+E1w0AdC7+qJVOobj5Q9Q+KB0Dp3Ck0IWj nEHFfwFXJx7Kj4oa5X8KQ1l1p4ovnfla/N6UgRbzD9dhzZ1uhBejCTcC+iT6u6MXdRLk qH1Xm60kTFRrDFhzRnWYYja+hncdEl9LYWETWUpH5+UfUy4R7JnQRvmxC4oj1H2jd0mK JXOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763290142; x=1763894942; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+fMpud5nRYR09kW8lGDhUQu4GUKHsEDTXnrAIWBrJUw=; b=t3x7dC7hC0FpJp5cASgr+Q3TgU46/NTuYjZSItBIy+sXnHjUYKYQdzZirR67CcqKu6 AHKC+OWIiYNCzs3eRetcQQU/Rb2ByIkax4cNQf+sl4aZIjTAtFAfKj7NsVcXj3jQpu6W x1G18z8FT8WXYCqUzfnFjKVWKfIr9CKk+k7eX13XbXvyrIlHf4n0Z3zDEhcLXNHzNDIE cZH1V/CWyhlNtLz0uJFdc59dP7ffHOULKgrr6HO9jDR5bKtJ1op8hGTYWHl5UwG+JgsQ Iwv354t7pQLccuXtHj76BaPAr0Gaq+oVDov6E3xB6RRu6OOSETIma5h/kDdRhOhzpOml zhsg== X-Gm-Message-State: AOJu0YyhIoXhUunMNbhnpISwRqrsPxgC72v5vXXZanNck4xLE0l/jFW8 xHKUzKN0++IYZ1ZK7fYb9c9A8oRECMJtOatZAHQDKqUMUAYo/ZdvopCAOnHycg== X-Gm-Gg: ASbGncsUw2GYCr4OJ2W2NQm0ub84QJR2a6Lnu7WRY7W2A5XaHwr1Vd6JEkSHE3j/HbK r8tC1uNOvWKZ5yvUoPOjk9K8QCEN3N4CNUnD2hwWeJZ2lre+2iV9MpN/viv400iY8P5LUcaLUjN JIscSC/++jy59ByccVGPp6xnGQGVRKKC8RG9zfJF8Geu4aelnBo6nvK1MekM05nc6NhtL7cv7ob a/C/T5Kz8mnZ3HBl6EMsOjBpDWHemTVgyAajaQkjvpzyhkkJbs6bu/eD1+nJga5PciijQ1Gb6Cb HYeDAI1cObFEcbzKbCJHuhB7hnjl6q1OgnKc7VCHRQUQ3zAeQo+XqSHjn5i06QKwGoix1ME66aV ADFsotTtgwVdCp4UlkPXteRQ9TjHU7xmcyEqyIu9+Vulff1ZuJse+/+HvAIiRLOHSY3KfJ2pOuT kKIiYDTIUXg+Jp3A== X-Google-Smtp-Source: AGHT+IEQzZrYHIt0jhxnsnlo025KqlOlxzBwOao0Q2bjJ/yXmavMTtnuuTsl9EBDHMk/BdpyE2yDDQ== X-Received: by 2002:a17:903:2f88:b0:298:60d5:d272 with SMTP id d9443c01a7336-2986a6d0e55mr86982525ad.17.1763290141690; Sun, 16 Nov 2025 02:49:01 -0800 (PST) Received: from nevers1dd ([122.187.117.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b9271506b1sm10140147b3a.45.2025.11.16.02.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 02:49:01 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Sun, 16 Nov 2025 16:18:55 +0530 Message-ID: <20251116104855.300902-1-sid9.karanam@gmail.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Message-ID-Hash: 5OFTARNOPXUHXYNPFEWKJ456Z4LKIVD3 X-Message-ID-Hash: 5OFTARNOPXUHXYNPFEWKJ456Z4LKIVD3 X-MailFrom: SRS0=d0WC=5Y=gmail.com=sid9.karanam@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avfilter/af_afftfilt: fix the overlap buffer size List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: nots1dd via ffmpeg-devel Cc: nots1dd Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: >>From what I understand, we only need to be moving N bytes as window_size - s->hop_size after inverse fft to the buffer for overlap. Currently the compiler throws a warning regarding possible overflow and this patch fixs it. --- libavfilter/af_afftfilt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_afftfilt.c b/libavfilter/af_afftfilt.c index 08cdcae2f7..4fc28c6143 100644 --- a/libavfilter/af_afftfilt.c +++ b/libavfilter/af_afftfilt.c @@ -250,6 +250,7 @@ static int filter_channel(AVFilterContext *ctx, void *arg, int jobnr, int nb_job { AFFTFiltContext *s = ctx->priv; const int window_size = s->window_size; + const int hop_size = s->hop_size; const float *window_lut = s->window_func_lut; const float f = sqrtf(1.f - s->overlap); const int channels = s->channels; @@ -294,7 +295,7 @@ static int filter_channel(AVFilterContext *ctx, void *arg, int jobnr, int nb_job s->itx_fn(s->ifft[ch], fft_out, fft_temp, sizeof(*fft_temp)); - memmove(buf, buf + s->hop_size, window_size * sizeof(float)); + memmove(buf, buf + hop_size, (window_size - hop_size) * sizeof(float)); for (int i = 0; i < window_size; i++) buf[i] += fft_out[i].re * window_lut[i] * f; } -- 2.51.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org