From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1589D4D2B7 for ; Sun, 16 Nov 2025 06:29:12 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'7YZO9e2D3U0XoR/GfpNL8HufTVHOb292xw8t8gbpBZ4=', expected b'q/HWmQYcBWHWoRzSCudu8HF8yB6VzbF9TDH31Bs0vUs=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763274530; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=ULBd3Squwa9iVAp3vQh94ZIkymffKxq+ih0jr3uUuxg=; b=Nwak3LpvEgUBBamS4YU4alS7A9E0xHlgqrj2vXVaoNNofgddXQYXDtbAjlToe4XYM7LlD abzObT7SVkqPh39cWJLcc5Bej1wZKejI1GGrlZIMjWGzUmSqFBbEvW3vTbZiT1wCo12/Sw4 w8wg/xH8/Ojb4+CoHS11w3BLfLU8RQmbEJdhNcSirdOglzW87DpLwZ3LgA0DUOAazswDekK 6ecnA1SFI8P/afvw/roKBQ2V1mJPLe2yZXv9QBafJI05V2j85m7Wj2qJar5EKl/6XUX781+ lXEUKcItt/sPLk7zB4xYBfQttbdq4QVETlj2BsK6hgq8Sko5v1ClI4MmNluw== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 35A3168FE44; Sun, 16 Nov 2025 08:28:50 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763274498; b=LeL8YfPBb7hPJZ6El+qta7zxAJZt9zy4w7Gp7NuBNcA5pbTjUDl/U0eVRHm5repj9Do99 ANQdR3hPFRo3XoP5SKtewqAaf5SY2s4PnPVXOKujw7fAVgqmBZwT/3h6E89TwEu05CAV/gv Le+xNOfYCBIZZ3nFq4IeSHlFnOT8ivFBEc1pITagiSq+qqXu/rotHKGY0GKRjNJ/0E3fh5n mjRzPk3W/9OROdfAAcOfkRtYSreu5oiirRSQD0O6i6dXsIuoDuVWDBxfw/cFhxj6mY7Ah2W T/R1rFyhi6EvVN0QPpNsGYUhqxfD+iQbTPNsoKZPwzEjnfhwyKbueUe3G7Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763274498; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=7YZO9e2D3U0XoR/GfpNL8HufTVHOb292xw8t8gbpBZ4=; b=bXoJUJ3iJXFgu3N4HAiozJR4yjrViS4tZTt1BTnY/K7K1OAk6OI2GjzhBVJ30XuYYiyWR Y4szAa7L80p6aHGTutHYelx7hl/IbA7X0VmV7ZYl5OX07gNKmemWsf2Uzey3QVwLmX03mFs AiYxmD3jJE/rsCBLko6nETsHMGAcXRqI3sE6D4Xx8/1qNPsEvOywV8mNISz72Bfee+SSatP G6AJj5BDGNvfbZ/6jTLbSAL5Y998G6Q05CboeBWw2DEiUFEJB0thTOK8bfPFmVjCJYoJuKk 78hDshnu4PDFQKRUpVQ1Ib25f2e9jRnBR6dPnU9UBLNEE1LGf7WHqR5IGEeQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2519D68FCD8 for ; Sun, 16 Nov 2025 00:32:46 +0200 (EET) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47755a7652eso21877035e9.0 for ; Sat, 15 Nov 2025 14:32:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763245965; x=1763850765; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=q/HWmQYcBWHWoRzSCudu8HF8yB6VzbF9TDH31Bs0vUs=; b=l+fAzFXM6iOyVuAbVUpAS4KdcHrx4sSGcytXzDbw945vxYzUJcWJbB8wB2wCqYKQFW C1gwlHiXnvsi4tYepXenbT+EGKUVSiLO4q41MhzXq0lEcGvyeQx4V+4Z9iBG1A6zW7n9 Zi5awAGIHdPadKffB+9nNaMTK5Jd4sINKtRCQ/Bx5WV5tqYEkMcTH56tMtlLJ5YL2LHk 0ZZC02qdZrg1uBuqp2rb6C6ACexNlOP0+JJGmYpdgqnDD7cetat8bCmidkOEUTHJQFxz /ZuqJxvD6LqmJlI/Mh5EyNZ98lQj2GHVkJP0ABT38I34ccDpYEUEnKecxZXRDIe+Rs6X Jyyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763245965; x=1763850765; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q/HWmQYcBWHWoRzSCudu8HF8yB6VzbF9TDH31Bs0vUs=; b=LKgiPqmz3dtw4AfrwqrLCqNla6mfkdH2y63/y6br0BFZbifTm70N/eRyi9ZYSozTwE 9jcMC24YBMRqjmCki8rGP+4gSupfvY5gAcEDi4S86jcMvlikMrSToX74m08S057hWsBo AliH/mUlb0mVWh/jhqesqzb6LoPEzNWhDlnEqpTFsqYKjectqnCspcGqUT5IAPBzurvs L66V20xMCVUiuLbdt4C2jWtRyvQe1Ype4Z9r+Sh90ospUWUs/IfxSydsPMadcgjIYAi9 jdd1EH13k3LGfr3x0C3sV1cdAsjLQWbr9qxDAC2GEWtPNiPPZ1h0FwUzurv+jkM7ClDH UHIQ== X-Gm-Message-State: AOJu0YxSrDsa/N4ubqSWzZmxbtqXHa/1w2mafynNYZc2dE1HMlRVtTUO /2ukdtgM/zYVri2U3bYcgSkh08K/JcXR1eQjyR8calA+YO7BtYUDmiTZcSJrK+vysq8= X-Gm-Gg: ASbGnctJRjl/WsolTifn3aDEGSXBDqIrZS4EVxjkvW7NgbfnNLAjd1sL8On5wNl9VCU QMPmzdySrbV1ROmjans/i7SEfuqsgAZ0YteU2yTSTQi1AcP+FIVhzncjVMN6GaVSKuWwFB2krXF SsS9+MF4K5369TAKjXSGCHisvuchmBJ+fIfvh3L4YnTtm/J3xTlYrmEvzyuexbZ5NAkHtWxf7py byhHErnfKyj0umnUVGbkxqQ9xUqlibW6qIQabHwmqv+Na/Su5MNWM0SfgM3Vw9KU/reRMgYkwtH kLJ2W0DNuTv8/sv21JXPghQJ4blU3II5w6OKkQ+h1GgaP5uYLxWYX9PtT9s/UfOaAJn6/LQBX7S LOmX6H0jIt2D0yilBLVSXXQEov4IjDN38O3GAeoGp4g78eKwsSJRDHOyJYn/8HzRW+e2urLUdJX YStv4a3mcDZSNLwAILCkziLxG06rj7snK673PCmRmyXFY3wgKuNNccoxKvBo+6WKx8PXOiy33PW rHWVnOPsL8iy9bi X-Google-Smtp-Source: AGHT+IGIjoDcewx2qJV49BfpDNTIWTcoNcSChYVGVKz3UNp8YKvR7+gJrMLruA4xV4Y7uudDHYZ6Fw== X-Received: by 2002:a05:600c:350d:b0:475:dd59:d8d8 with SMTP id 5b1f17b1804b1-4778fe4f716mr74803525e9.8.1763245964771; Sat, 15 Nov 2025 14:32:44 -0800 (PST) Received: from localhost.localdomain (host-92-25-151-132.as13285.net. [92.25.151.132]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e953e3sm218060105e9.14.2025.11.15.14.32.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 15 Nov 2025 14:32:44 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Sat, 15 Nov 2025 22:32:42 +0000 Message-ID: <20251115223242.90376-1-celebitolgakaan@gmail.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 X-MailFrom: SRS0=P9DX=5X=gmail.com=celebitolgakaan@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation Message-ID-Hash: XW67FJ4ESOFGXUHYPDQNRIIG3YVXDPJ2 X-Message-ID-Hash: XW67FJ4ESOFGXUHYPDQNRIIG3YVXDPJ2 X-Mailman-Approved-At: Sun, 16 Nov 2025 06:28:08 +0000 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: do not write encoder metadata for ogg files with bitexact List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Tolga Celebi via ffmpeg-devel Cc: tolgakaan12 <70590077+tolgakaan12@users.noreply.github.com>, Tolga Celebi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: From: tolgakaan12 <70590077+tolgakaan12@users.noreply.github.com> The set_encoder_id function in fftools/ffmpeg_mux_init was writing a shortened encoder tag even when -bitexact flag was set, instead of omitting it entirely like other formats (flac, mp3, wav) do. This patch makes the function return early if bitexact flag is set, ensuring no encoder metadata is written. Fixes ticket #11656. --- fftools/ffmpeg_mux_init.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index bcbbee9126..3d13c9c257 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -1167,15 +1167,15 @@ static int set_encoder_id(OutputStream *ost, const AVCodec *codec) uint8_t *encoder_string; int encoder_string_len; + if (ost->file->bitexact || ost->bitexact) + return 0; + encoder_string_len = sizeof(LIBAVCODEC_IDENT) + strlen(cname) + 2; encoder_string = av_mallocz(encoder_string_len); if (!encoder_string) return AVERROR(ENOMEM); - if (!ost->file->bitexact && !ost->bitexact) - av_strlcpy(encoder_string, LIBAVCODEC_IDENT " ", encoder_string_len); - else - av_strlcpy(encoder_string, "Lavc ", encoder_string_len); + av_strlcpy(encoder_string, LIBAVCODEC_IDENT " ", encoder_string_len); av_strlcat(encoder_string, cname, encoder_string_len); av_dict_set(&ost->st->metadata, "encoder", encoder_string, AV_DICT_DONT_STRDUP_VAL | AV_DICT_DONT_OVERWRITE); -- 2.50.1 (Apple Git-155) _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org