From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1AD2B4D27F for ; Fri, 14 Nov 2025 20:37:03 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'heGmc/rOuzAVxfzdTVRw0s3Cc7RWGD+tkMX4YFBNurU=', expected b'vKyXw+oyQMn+Ij8fPLUQoLD+/NCerJNhBprjBfzY5vQ=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763152614; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=qDxcFpCdfcr5zwzdQaGbB8UCvmCz/Z+RXFEb0mYC6CY=; b=5X8qSGq6OY0xfM1fxvJUeC4NIL55apAgieFulC8P0vG5L2Is+0BkElRIi5SAzc8Jsmr0n T5bgYcRlzqb9I92zs8+khBDiolralLOLW4U8wfjozP6y2OzFtUBzfek5en7w47zwjCeXY49 dl76T+ccPg3kvv7Kk5aFTio/VUaqCW4nqIUpTyPNRPfWWRQcFKaLw8DG0JuXQU02mxX41rp zTbZTChWrwt2prcSjxi6hVtoDZlkXXY56AFO4B5ivgQtk/GTypBqq1U5ubf8iaFydplLMXm xB0F4/Nd8TinFUMjJBXRBQlrlNjmzrjq4vIfNb2q4p1RLb50vWEpP5q0SUKQ== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BE4DA68FE1F; Fri, 14 Nov 2025 22:36:54 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763152598; b=aFP2sb/L01PcWmQNAQsyIU3jBw5PaM+ATF/417I77/WKBNeNYxYXtJLqT0j0g2RBD5Xbw MbBLbmegnezBAXrOqrIvCUe7ZVuWVEGNTiaBV3GEIwJ9E5mvOWeR5lRBBPGNv87/ci/hmtf tzc0Iq/cRxr6PM9s3A4PHSkvV3LomGAvi1+pYzuB/El+CcXQZVhzgD3fT4IrVZUyapVzlY+ IGV2+wWkA2PjwhlnZ9zKxtiUu1F1y9iGc9VW+R0ykS0tmn/6jjS4ekPBjvYKUjFCM8isBdY z8YYTi0Y4E+9D7lVH0m02FynRdi8tGOnHuexa7/nboMOHqv7OkP533Gesp8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763152598; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=heGmc/rOuzAVxfzdTVRw0s3Cc7RWGD+tkMX4YFBNurU=; b=JsL4Yxv1fKktXkwOQ6E62KV3N/vNlPR4zHTj0YFp/ChmwQa1ocAqn+FJtK8R7Yxo48IG3 MTQeUqkt/BOAd1Tz7hjQhS9DhsqACYYcRSFmTrxEEJB/zPzyom0fkQcZbhzUi1L9UMJttu5 YuHGfp2Wi2xvqsye/Njt952VJyF3yUZmyy8I2vWiXA7ZMyN+QzjqdyHJASvT9+KenSriekd PtyirQNN0DOccqjgdj7Otj4HcHfSzjC9K0ud/8HnqMeKchIZzEWJgN9gm8QcKF+wRJEIUF4 YXxLYpmQkAANzYFJPH49ReAyGLxLVkgUOcuwidVfm+HYHBXKjal2G6sUidcg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id ACBCC68FD94 for ; Fri, 14 Nov 2025 22:36:24 +0200 (EET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2953e415b27so22803835ad.2 for ; Fri, 14 Nov 2025 12:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763152582; x=1763757382; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vKyXw+oyQMn+Ij8fPLUQoLD+/NCerJNhBprjBfzY5vQ=; b=lMw+h2D4xLLJzVYTzryapl2qhHXa33OevS78rP5RCC52S49dTIJ0w1yiRz/FfHFvoS Cpp0E1rzBnTKMsGmV9Ti2g0Wc1XXCPvaIZDuHaxm++u01A8XRdaewBNbhTEdADUIEgFC Zl6ZWixwanTQDFUhcY/mGeNXykr/B4qTaQ0P0C8pxZs41t1vx4xC9rxvsHyvogUYu+8w +kCseFtL/VN8HgqVoELaft0rjeY6URqKkwa3LPewbA4zQKk+rb/aaw2zRSPHYs150gs9 vXEp5k934+xHxfI6zJAA8dO2qO4gTRSkQuP5ilemEPzXGqw3PzfKTONfFfxondzz2wrG ZHSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763152582; x=1763757382; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vKyXw+oyQMn+Ij8fPLUQoLD+/NCerJNhBprjBfzY5vQ=; b=rDvv2vySo5vf9eevl9FJTu/z6Dus4E71fkQZWgUmBXtBk8S3N1iqMNmJUNSQ+TJPHd X+GKgqFgyqLPGnwNLZc5Gek80ylts+2ijBixKj3B9Aj3Fhrk8gpqKa+X2vKM4LYzgoBn oBXdLd4ZuHNHGVFJtGYmLVRAlI/RUPJ02WGiJVH+/VA/tex4/I68KsAHsFgF9IE24ngH aPTaIEB4IkYqSitcP9R4tYlc3OErVXPTPuMhWfEom3HzmUCO59cVEHPkqsDYDOuwAAWD LKrtGysFmv7C1kVaINmesK5GLNk5Zd7iBbxsr7ZPnhzSXYV6QFFe5DOSurliaFhW4BH2 WrOQ== X-Gm-Message-State: AOJu0YwlTpEfDyVvdcbj7uIymEFqxvME3IM8CLAMDuCW5rvhhFRwbDJy Lrl1pt/8pmTHKl5XAczxZhM48DfaTmMoJ0dy9UtKfa86o2w3/j9eqLv0APBoYw== X-Gm-Gg: ASbGncvkBjzzdQp3KPl+NxZ4pfJ8grSbwtZG5/OCO6/VKIuHzxeYnPevfuX7aLXN+Pb wYMZyE9lsI5d+Jg9zPXmLtt0qZ4hYn0lwzDGHnqgmfjcpgU0LaVT0Vtcftj8n7rM8xNhrvhi76x aWhgIGHuQIi8kEjCjliEmSiw3O7gwYqGFEviZA589XYjWNAv/S5z0bnm+RJT6sfsfoa1laulCSK 2L4qMETDeRmWKQJjkmZEYV/3UFIcQY4GKDI8ck62V3ppM4/A1K1BwggbIHzOsoYNmm4yOCNFq9S vp7r89/tgtoi/wCmJiF9hVx6/tInPiZHlP0a1pRLUqCHKJyniADpyjTyFPMiPMSfwqwHlMhMCZ2 iDKCqgk3r87dPV8IKlxBuxKnC9x1LeFIMxMqfx8dGm8m2rsq4M5usMjtOi3ocoYdfi7JXl4bncQ j7poGh0Q3/iqZrCZQZD65TR9Seo/yFmhDhBWhmsiwi+b5Tec0H1uUPnKw= X-Google-Smtp-Source: AGHT+IEGBUd7jGgguKCygu3uMrPXOXfmlPJffupWOoscAhR3lXmYjP0598A9/JaboG2aPPHYMbJNJQ== X-Received: by 2002:a17:903:1a10:b0:272:dee1:c133 with SMTP id d9443c01a7336-2986a6d29a3mr49633925ad.22.1763152581831; Fri, 14 Nov 2025 12:36:21 -0800 (PST) Received: from SHUBFRACTAL.localdomain (S01067013010a5f62.gv.shawcable.net. [96.54.80.232]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2bf1ddsm63838155ad.92.2025.11.14.12.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 12:36:20 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Fri, 14 Nov 2025 12:35:38 -0800 Message-Id: <20251114203538.551705-1-wangshubin130@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Message-ID-Hash: GRSLX7EB5PXLVGVLEICZPEOJQ2JEEZJO X-Message-ID-Hash: GRSLX7EB5PXLVGVLEICZPEOJQ2JEEZJO X-MailFrom: SRS0=o4Gt=5W=gmail.com=wangshubin130@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avformat/segafilmenc: Fix division by zero with malformed Cinepak data List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Shubin123 via ffmpeg-devel Cc: Shubin123 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: The film_write_packet() function reads encoded_buf_size from packet data via AV_RB24() and uses it in a modulo operation without validation. When the data contains zeros at this position, it causes division by zero. Add validation to return AVERROR_INVALIDDATA when encoded_buf_size is zero. Signed-off-by: Shubin123 --- libavformat/segafilmenc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c index 88a5b9f972..2206ff9033 100644 --- a/libavformat/segafilmenc.c +++ b/libavformat/segafilmenc.c @@ -58,6 +58,10 @@ static int film_write_packet(AVFormatContext *format_context, AVPacket *pkt) if (codec_id == AV_CODEC_ID_CINEPAK) { encoded_buf_size = AV_RB24(&pkt->data[1]); /* Already Sega Cinepak, so no need to reformat the packets */ + if (encoded_buf_size == 0) { + av_log(format_context, AV_LOG_ERROR, "Invalid encoded_buf_size 0\n"); + return AVERROR_INVALIDDATA; + } if (encoded_buf_size != pkt->size && (pkt->size % encoded_buf_size) != 0) { avio_write(pb, pkt->data, pkt->size); } else { -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org