From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DF4134D2C0 for ; Sun, 16 Nov 2025 06:27:23 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'heGmc/rOuzAVxfzdTVRw0s3Cc7RWGD+tkMX4YFBNurU=', expected b'vKyXw+oyQMn+Ij8fPLUQoLD+/NCerJNhBprjBfzY5vQ=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763274408; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=qDxcFpCdfcr5zwzdQaGbB8UCvmCz/Z+RXFEb0mYC6CY=; b=BLyRl4n/r5iaHZFi6wcKHf8NYEyT0GeR0d6IkxrkSKt3GH2SEIt3r+xOyOGiTIyjNOcWu XHKNsajxv3FWG/4R4dQCZiWobbTTEe+6GQEf+gSZyCSBjuVZ/MDaLyD1l6MQ1665H/2twyz QMV90d6oLo+9Yf63vaW7Hu9YDpEyUf4pA59ouKezPwTXNVvrKDO1ShYeOzjNR6KEEEQ1lmm 0wAAwmUeLNlnXoGr87yBJXJwWMEdhQ769i/s7SseOdsE+DtAU8K+PMFBTKkGw8tOV15Fgbq 0CooBibPZGBiZoTBMvK2sY6/YayiXBNRCA5uL6Yo2JLs/ATCz6JDVK2acO4g== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4E7BA68FE42; Sun, 16 Nov 2025 08:26:48 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763274375; b=jsHMlcROjWC7SSErXUvjVFVlpYaQuwECGpAX1yjV1y1IzQPNT95F9yGRcDvHXGPG4gm2J ChQYVeY6azKmC1+DjXZfxodxqhXOmtbKZqFl10cq/nTYI/bf089vIFux3RMS/TQfyXlJkq2 2/v13snDjbQqaPvV/ZHzMzLo3IEC7mEiZKpq9ZkzdGP/0dbCfkecEMtazbQClbND3JXFAuw QPh5mpdyBHNWC2sz+84jEfxfNPzX94IOmy1fNDS5N0Z1LAPmD4lGfwIXbxn+n4Yc3t3Fleo 8T1rKAU7c+sq8mK9WlXPXb8igU3QnGkz8oZI5hJeVM83VbKvlg15+TXZ3oMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763274375; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=heGmc/rOuzAVxfzdTVRw0s3Cc7RWGD+tkMX4YFBNurU=; b=OJFjZk0Ya3YNeV2q30yPu8gD/Q3HOBYwT3zsl7G0HsXjFBO7UmFpZV7SGlmViYXeqThKs LrWNChcJXcnRkAINvb4NPrSNbPnkBnVhiBnM8oO5NAWRIGl58byV4Yf95Mv6YuMuVZT4ThV hVySQr4xp6vTzPqh7rnoVeyxLCI+sGdDcXKkE3OyP7Q+wyBaxPaLrY1zB1qJ3gkxTnZGHY7 uwrtYz7CE3QrKDPx7s/7VPEQBs7vureIyDoEIlOlAePeUM3TIROZFbRSDcqUTDAA+29Yw4c Ud7t3zvthZLzpRL5Tu059DUsTE9dpiW27FjLBdDWYdvEdoHAEulu8J6zb93g== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id F199E68FCCD for ; Thu, 13 Nov 2025 23:10:27 +0200 (EET) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7af603c06easo1477584b3a.0 for ; Thu, 13 Nov 2025 13:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763068225; x=1763673025; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vKyXw+oyQMn+Ij8fPLUQoLD+/NCerJNhBprjBfzY5vQ=; b=QkiXd7fZ0b5r+boF3j3OQJ8g3J2f+mkCEjSJkZMHctm4wQXDhhf/GnSMBQFQWBDorP mwLFAD+kkYBTVqoQPtJPQalEhYPkyzWfT/zn9yZddXuwWAhlHDLuijm0jMT+ouyShObo jitzl7esxUdhSmAqKuprZg/fu8aZvBZZWn+mb56zNRxoJFL0gCgFlroRpcv3GxP4225p DxgZ0Iw1kcmZTZzOfMQS/7QYvQyuXyKvHkVndCFBO2+JLEpETAOulvLVOZR6HsiRzHzc jX+l7B+u6ncqOlrIRX8IMliDUfjlK30AQHtKtURTQ10g6V23yc6/pQ6rwvdKQdjZU9Ly yX2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763068225; x=1763673025; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vKyXw+oyQMn+Ij8fPLUQoLD+/NCerJNhBprjBfzY5vQ=; b=QXRGzIpMU9zmat/ZW1lYP3ks6AdO6mxBGZLRpOpNawJ0ZCUes1lOvGiKgybJs07SBx b18GcYPCBlc5UKXOp+6FLELENNYhm+ZhV/0nSRfM6ei29xbW+FfBGaEUcjQtXwgaqsFm MGdcrNOAxa+dKm3JPjXWmgmPbPPzT3k0Q56eaY74PM9MiOdbqGkAL4cMj+Ntw4OdkzdR /cYfATgnouTTTEw085lSLwc0EZ8RqDhULfrPcnckNKfacdUpQYVnbLESKcjAXR6Na0CP SbLSqyUtGR82D4gSxOa7/9mXUBCyjxO6xrqcCPXmMFA+WVyZ7Q+aVfpbZG4hVpTX2oPn lb8A== X-Gm-Message-State: AOJu0YzqSp65M/mdn+wUkl1rGelbfYARVhCeQUfuDiPcRLtoXZYlIrbN YxKBP7cnHCIaAOzfgwh+uRgbtLtLu+SqwnLiuCOzwC6GzM6UYQNOHB24XKXyLQ== X-Gm-Gg: ASbGncsoVKV9h7XJHOftVyU/XRY+WbrJU0sqiPEnqg6/ehbwNr5meJ2drdj4WxmKc3K //o08g2/zHnE37RjC0LbyJMEUtMxpFYo4HxlytO3OYwk8GzWnVx457fp6/Z69uWsJuvcLq6bOKc D3mHfIBYaLa/gZ8zlAqNl2V3WRaF7X/XEjgafcw5eQBs9DnqDqgjMuKQDSzJ0jLTuu0BtiiqWo+ vABol3Nlwx/iZb8OE6AzxmFtTpkvBSKnOda20HRdGuWv7i8TjASWE6ZydAurwu+ryewYf/KEKbJ RBF6y4PKPPUlAfrmQYWE/SX0t73zgEOe+ITFgH4rP2iuATcobtHxYqZoD1zH2KO8m6UnCjF9rgY g2NmnmWBSo63ONeRnUSu9ArzdU4vT0PcHGu8QS0MaYjfqPePIgchlcbdIllRyN+Wob5R50UDtVs +aF3h1uBW+cUBW1bZjv9lm6KVOcda8TvhTkMjykLCsQ7rtJWQF3uq4sS8L4Q+VL1RE3g== X-Google-Smtp-Source: AGHT+IFawlq/mMmRdvjEFaC4dGxC18e+BkMTAzx1wshoENl7U38rfyBOfx7IYP+t4L12SbzkPP3GRQ== X-Received: by 2002:a05:6a00:1391:b0:77e:d2f7:f307 with SMTP id d2e1a72fcca58-7ba3419a6d9mr1165812b3a.9.1763068225356; Thu, 13 Nov 2025 13:10:25 -0800 (PST) Received: from SHUBFRACTAL.localdomain (S01067013010a5f62.gv.shawcable.net. [96.54.80.232]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b9251ca3e9sm3225835b3a.29.2025.11.13.13.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 13:10:24 -0800 (PST) To: ffmpeg-devel@ffmpeg.org Date: Thu, 13 Nov 2025 13:10:18 -0800 Message-Id: <20251113211018.535464-1-wangshubin130@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-MailFrom: SRS0=dn4U=5V=gmail.com=wangshubin130@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation Message-ID-Hash: 3MF5PFOGGY5FCBMHSBH5VCG6CP56QQNS X-Message-ID-Hash: 3MF5PFOGGY5FCBMHSBH5VCG6CP56QQNS X-Mailman-Approved-At: Sun, 16 Nov 2025 06:26:05 +0000 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avformat/segafilmenc: Fix division by zero with malformed Cinepak data List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Shubin123 via ffmpeg-devel Cc: Shubin123 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: The film_write_packet() function reads encoded_buf_size from packet data via AV_RB24() and uses it in a modulo operation without validation. When the data contains zeros at this position, it causes division by zero. Add validation to return AVERROR_INVALIDDATA when encoded_buf_size is zero. Signed-off-by: Shubin123 --- libavformat/segafilmenc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c index 88a5b9f972..2206ff9033 100644 --- a/libavformat/segafilmenc.c +++ b/libavformat/segafilmenc.c @@ -58,6 +58,10 @@ static int film_write_packet(AVFormatContext *format_context, AVPacket *pkt) if (codec_id == AV_CODEC_ID_CINEPAK) { encoded_buf_size = AV_RB24(&pkt->data[1]); /* Already Sega Cinepak, so no need to reformat the packets */ + if (encoded_buf_size == 0) { + av_log(format_context, AV_LOG_ERROR, "Invalid encoded_buf_size 0\n"); + return AVERROR_INVALIDDATA; + } if (encoded_buf_size != pkt->size && (pkt->size % encoded_buf_size) != 0) { avio_write(pb, pkt->data, pkt->size); } else { -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org