Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Jeremy James via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Jeremy James <jeremy.james@gmail.com>
Subject: [FFmpeg-devel] [PATCH] avcodec/qtrle: set keyframe flag in output frames
Date: Thu, 30 Oct 2025 14:12:37 +0000
Message-ID: <20251030141237.1348827-1-jeremy.james@gmail.com> (raw)

This was broken by dc7bd7c5a5 because it was depending on the behaviour
of all frames setting key_frame by default, although that was also wrong
because it didn't unset the flag for duplicate/repeated frames.

Signed-off-by: Jeremy James <jeremy.james@gmail.com>
---
 libavcodec/qtrle.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/qtrle.c b/libavcodec/qtrle.c
index 1c2fbc357e..c8bee8ce44 100644
--- a/libavcodec/qtrle.c
+++ b/libavcodec/qtrle.c
@@ -557,6 +557,10 @@ done:
 
     if ((ret = av_frame_ref(rframe, s->frame)) < 0)
         return ret;
+
+    rframe->pict_type = !duplicate ? AV_PICTURE_TYPE_I : AV_PICTURE_TYPE_P;
+    rframe->flags     = AV_FRAME_FLAG_KEY * !duplicate;
+
     *got_frame      = 1;
 
     /* always report that the buffer was completely consumed */
-- 
2.43.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2025-10-30 14:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251030141237.1348827-1-jeremy.james@gmail.com \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=jeremy.james@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git