On Tue, Sep 09, 2025 at 02:38:53PM +0200, Jerome Martinez via ffmpeg-devel wrote: > libavformat/matroskaenc.c | 8 +++---- > tests/ref/lavf/mka | 4 +-- > tests/ref/lavf/mkv | 4 +-- > tests/ref/lavf/mkv_attachment | 4 +-- > tests/ref/seek/lavf-mkv | 44 +++++++++++++++++++++--------------------- > 5 files changed, 32 insertions(+), 32 deletions(-) > 5640f0c46b6393637f17285da9bfbc84266c5054 0001-matroskaenc-remove-unused-MaxBlockAdditionID.patch > >From 305cce5e1db5e6ae48497398bec024da206b9035 Mon Sep 17 00:00:00 2001 > From: Jerome Martinez > Date: Wed, 3 Sep 2025 19:54:10 +0200 > Subject: [PATCH 1/7] matroskaenc: remove unused MaxBlockAdditionID > > For non video tracks: it is never used, let's save 4 bytes > For video tracks: simplify the temporary storage with only a void element and MaxBlockAdditionID will be written when finishing the track if needed (not the default value) > --- > libavformat/matroskaenc.c | 8 +++---- > tests/ref/lavf/mka | 4 ++-- > tests/ref/lavf/mkv | 4 ++-- > tests/ref/lavf/mkv_attachment | 4 ++-- > tests/ref/seek/lavf-mkv | 44 +++++++++++++++++------------------ > 5 files changed, 32 insertions(+), 32 deletions(-) seems to break fate: make -j32 fate-shortest-sub --- ./tests/ref/fate/shortest-sub 2025-09-11 20:05:21.708975764 +0200 +++ tests/data/fate/shortest-sub 2025-09-12 16:44:16.370841163 +0200 @@ -1,5 +1,5 @@ -d6608277c93097383e62388196dc62f0 *tests/data/fate/shortest-sub.matroska -139260 tests/data/fate/shortest-sub.matroska +24443d70a3750ce14b918a6e3d9e9926 *tests/data/fate/shortest-sub.matroska +139256 tests/data/fate/shortest-sub.matroska #extradata 1: 167, 0xf7272d5f #tb 0: 1/1000 #media_type 0: video Test shortest-sub failed. Look at tests/data/fate/shortest-sub.err for details. make: *** [tests/Makefile:321: fate-shortest-sub] Error 1 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Homeopathy is like voting while filling the ballot out with transparent ink. Sometimes the outcome one wanted occurs. Rarely its worse than filling out a ballot properly.