[FFmpeg-devel] [PATCH] avcodec/decode: fix enum conversion warnings in side_data_map.

[FFmpeg-devel] [PATCH] avcodec/decode: fix enum conversion warnings in side_data_map.

[岑湛权 via ffmpeg-devel]

From: zhanquan cen <cenzhanquan2@gmail.com>

Fix two -Wenum-conversion warnings:
- Implicit conversion from AVPacketSideDataType to AVFrameSideDataType
- Implicit conversion from AVFrameSideDataType to AVPacketSideDataType

The packet side data type should be cast explicitly when used in
packet_side_data_get(), as the function expects AVPacketSideDataType.

CC: ffmpeg-devel@ffmpeg.org

Signed-off-by: zhanquan cen <cenzhanquan1@xiaomi.com>
---
 libavcodec/decode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index f395948d60..f6ed1b4600 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -1469,12 +1469,12 @@ static int side_data_map(AVFrame *dst,
 
 {
     for (int i = 0; map[i].packet < AV_PKT_DATA_NB; i++) {
-        const enum AVPacketSideDataType type_pkt   = map[i].packet;
+        const enum AVPacketSideDataType type_pkt   = (enum AVFrameSideDataType)map[i].packet;
         const enum AVFrameSideDataType  type_frame = map[i].frame;
         const AVPacketSideData *sd_pkt;
         AVFrameSideData *sd_frame;
 
-        sd_pkt = packet_side_data_get(sd_src, nb_sd_src, type_pkt);
+        sd_pkt = packet_side_data_get(sd_src, nb_sd_src, (enum AVPacketSideDataType)type_pkt);
         if (!sd_pkt)
             continue;
 
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

[FFmpeg-devel] Re: [PATCH] avcodec/decode: fix enum conversion warnings in side_data_map.

[Michael Niedermayer via ffmpeg-devel]

[-- Attachment #1.1: Type: text/plain, Size: 1454 bytes --]

On Thu, Sep 04, 2025 at 07:43:36PM +0800, 岑湛权 via ffmpeg-devel wrote:
> From: zhanquan cen <cenzhanquan2@gmail.com>
> 
> Fix two -Wenum-conversion warnings:
> - Implicit conversion from AVPacketSideDataType to AVFrameSideDataType
> - Implicit conversion from AVFrameSideDataType to AVPacketSideDataType
> 
> The packet side data type should be cast explicitly when used in
> packet_side_data_get(), as the function expects AVPacketSideDataType.
> 
> CC: ffmpeg-devel@ffmpeg.org
> 
> Signed-off-by: zhanquan cen <cenzhanquan1@xiaomi.com>
> ---
>  libavcodec/decode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/decode.c b/libavcodec/decode.c
> index f395948d60..f6ed1b4600 100644
> --- a/libavcodec/decode.c
> +++ b/libavcodec/decode.c
> @@ -1469,12 +1469,12 @@ static int side_data_map(AVFrame *dst,
>  
>  {
>      for (int i = 0; map[i].packet < AV_PKT_DATA_NB; i++) {
> -        const enum AVPacketSideDataType type_pkt   = map[i].packet;
> +        const enum AVPacketSideDataType type_pkt   = (enum AVFrameSideDataType)map[i].packet;
                      ^^^^^^^^^^^^^^^^^^^^                    ^^^^^^^^^^^^^^^^^^^
This is not the same type, how does this fix a missmatch ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org